From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F80C35E1A3 for ; Fri, 15 May 2026 19:14:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=193.142.43.55 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778872453; cv=none; b=Q8Ru2wR+yUtfh4IxARgjifoffw+QsYVdWGmekdLjYJKtD9fH9GcE1T3UoloCMms69Ru863S1qfFLwgr0MyguJ5c1IdOmB2SbYBIZa09elUzKTSuYcjH+CFiIS9Zvdp2jqXCpOxgZ24gFOXnKNSLkGlSAlzUd2+8tc4Tqcbf1Ydo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778872453; c=relaxed/simple; bh=d7LQCUaMbSjOXZJImijOmNu8E70KKIdsNEjU+JFveRw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=dYbNykA7n8aX1cBxbuWR1R1LFFTCol6s2omOHoPfOvQuiS1bJCtpQznN+xoy20oqAx83Q1jBb0PtLqpmh3pkmCUQ4AI3BbJrd1/XQpj6JHlgZv3aAd6YjiQGr17FnbpHlL/+Zbg5J4+q7rRUa5IMxGaFdYW3iipNGF80wkBeRuI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de; spf=pass smtp.mailfrom=linutronix.de; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=ypjW1vFB; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b=QjJcf13N; arc=none smtp.client-ip=193.142.43.55 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linutronix.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linutronix.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="ypjW1vFB"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="QjJcf13N" Date: Fri, 15 May 2026 21:14:07 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1778872450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gRAPuZ9dq/BIdlj8slvxzC+193oAle60/PNKBIGSzIk=; b=ypjW1vFB1aUJhkQqibW6jdyKwgV1dFdctqspwh8Gedea6ATb1yFYS3D2rTDHFYTN4KriF1 2Z6nhmfsB9SaKZlcsMoVkHIClkFK2PRhVS+z22roWN9ca3jOfEbZc/PTVnAUmgj593UlL9 WasmY7pCw0vuLAioR3sHXM5OY7Xn+jbf5KGnnQD3IqgJOdUSFM0ZDbZB8fmQZnoXKgMnnK 32emyn1XWleNVv5cBCbYAsWkcBSqGy3qBdrzb+6LHhsCHoUsezuewTCA7MTZX6pdToE2Nd ihHsvVPBLAaE/kqK9PbMHlUw5hlwG7A4l8F4dg2bT+aFbhCQzC9/oRr8vOVYyw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1778872450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gRAPuZ9dq/BIdlj8slvxzC+193oAle60/PNKBIGSzIk=; b=QjJcf13NTpze+WKQPruGJO845TrTkWsEX91qBtD4cqJCPzRiAhFDed+c5YQyCGgWY/RJk/ pS0ICCns5SBOikCA== From: "Ahmed S. Darwish" To: Sohil Mehta Cc: Dave Hansen , Borislav Petkov , x86@kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Josh Poimboeuf , Richard Weinberger , Andrew Cooper , Tony Luck , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] x86/cpu/intel: Simplify F00F bug notice using pr_notice_once() Message-ID: References: <20260515002500.2463393-1-sohil.mehta@intel.com> <20260515002500.2463393-3-sohil.mehta@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260515002500.2463393-3-sohil.mehta@intel.com> Hi Sohil, On Thu, 14 May 2026, Sohil Mehta wrote: > > --- a/arch/x86/kernel/cpu/intel.c > +++ b/arch/x86/kernel/cpu/intel.c > @@ -396,13 +396,8 @@ static void intel_workarounds(struct cpuinfo_x86 *c) > * The Quark is also family 5, but does not have the same bug. > */ > if (c->x86_vfm >= INTEL_FAM5_START && c->x86_vfm < INTEL_QUARK_X1000) { > - static int f00f_workaround_enabled; > - > set_cpu_bug(c, X86_BUG_F00F); > - if (!f00f_workaround_enabled) { > - pr_notice("Intel Pentium with F0 0F bug - workaround enabled.\n"); > - f00f_workaround_enabled = 1; > - } > + pr_notice_once("Intel Pentium with F0 0F bug - workaround enabled.\n"); > } > I think you can go further and just remove the whole dmesg line. All other set_cpu_bug() call sites in the kernel do not print anything [*], and /proc/cpuinfo already has a dedicated CPU bugs line. Thanks, Ahmed [*] Except a single, also legacy, call site: X86_BUG_FDIV