From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4671E1A6813 for ; Fri, 15 May 2026 23:56:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.45 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778889388; cv=none; b=S33pEoHzschiQrCvi0keREPq9plOr40EVunGj943aCEWWSLYePhPLfRNe+edjAXAFQNXWeEkdmtlmo0pevm5TdxTcja3So4zYhTQvTZCKc5lcAbguVz0d9q51rt+xwmp6XIWEA2Q9Z+sGtoL7vmWRYIa82KFGWxrsDeOgFkSF1E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778889388; c=relaxed/simple; bh=TczwYFvezC+cxAVsXFLJSZa6yKhWgXpLxIGr4mPEKJw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pG0b+XQUtDt7jN70Ye4Ab1JyDHO8UOYco5Hym/uU8N3pXutDF/4gZ4wyuVzfaOcdfPXhAdfgQCUGmeLjzSXgZ+UM14fa3SrKWCKsfjrwu8HgVZJQGUC+FCbauXMsz4xLgF149VjdrY5/6YdOkjg546hmQ31b8Bjcu+Wnl8MnZpY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=BXzqbhlg; arc=none smtp.client-ip=209.85.221.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="BXzqbhlg" Received: by mail-wr1-f45.google.com with SMTP id ffacd0b85a97d-43d7dab87e1so38509f8f.3 for ; Fri, 15 May 2026 16:56:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1778889386; x=1779494186; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=7l0XJ9rj+fjB2S5mDM2d3xOJnuO0et6lV2GrlUYJVSw=; b=BXzqbhlg5RuUMcTAr2dqxUE7l51xyJa+PpjXKxHN4UOxqTbctTIqKyxQTeRZPWFLvK srrIA1XCZ0+oT/dhnncvOORw33PcpFE/o8rrSSQPHHoNGW8nWD6hVfPgt0UCu9Jg319y O820DWo9UvB4l1MsUGZuExgJXozn0o9JaZiAigLczj4RlpKIwik8CrPXEO+Rj/CIlcci jU0OC93xBK0V0TZgNOtKd6KdH6+OEDc+9Ik/aTMXkxpCOuIM0L53V6Iwcn/wWUBnPlHV QstKwYJsBjBh8aC0S4HQ+c16HSkycO9Fu5DGGXr2YZEXGXgTPBsgaA5nL1c1En3wQFfm Tsdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778889386; x=1779494186; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7l0XJ9rj+fjB2S5mDM2d3xOJnuO0et6lV2GrlUYJVSw=; b=R14GpMSsg76mb9JSP15H6TU8bkA2V4chPmmMW7TqpvRmpLCnRclsbM7KViQ91GCWN9 //t3I5ukiry2ZKOr2wFl9+5UG+muR+1gw1V1weu6W59jgzeTpdRW7VvOkr4PYjyFaIhj FlcO4brb9bik4sMsyvsJanAcbrOJmqefvuVGA2A11u4mwtmAmZ1ur+G+Q32oE3Iwj6p7 W9lbt15c8t69oiOSX7s8ByaWmWvn+ZQdGZsZacgpUd4+5kQ9EtXQl5KiV+Fp6yMRj9aj 2CsAVOF3AjhRIR6oubwtAxF7iRielxgJOsJ3gzrD4qWq/hnRe8JF/fypRNtPAqLgT+IT Hnlw== X-Forwarded-Encrypted: i=1; AFNElJ+2JwC8vYY3gbDFz0j9zjiaUUs5nvbCAITInpKHMjMD86vzCYzk3gFjXIs6zTybC3Z5lQUz8lRoDJOJFs8=@vger.kernel.org X-Gm-Message-State: AOJu0Yz5WUFsG3ju3rSSbkWjhy1Rm9QTIeLBfrRtiQO7lvydSm9+Rr7I 7sRYVZSivA8F9tQiEN5o/2DNd+/VHYvqS5fSIXJOTDL72ZQchjo09sYgwtW2ImLqmSc= X-Gm-Gg: Acq92OGJ5Br1rX0sLzWsH6/gueEhnO68UTIbKGWpM+6aqgeEfDIHEBEsmNQePJVBFM2 rgTBXDe57c6A+wQTQB/DfnTeyg8hFZLoBw7Blc4pIaEIcyAP3hu6gmk8O6tUZ3kc/Kc97PdT2+E JDstlKmY0c7UUakPl+xKN+8nDEetw+r5+lOtQGG/UJWSN60augFIIFAmLnaSfmp2CbS8PQeymOb ekH9Wf7ZttLCuu35YhO1cBSc63w/w+siDAD2XVJrCPvJl09eQ4VoXyiOsLx22C0HiUTFroZ8Sa4 IGZqqQ0FLiMr463+StFayZdK+sSPvOIx4c+muvCLxjt3wSU7qVE38rz5keLHAQltBCbhyLCYJMx PSZgcmh+sa2Hgovf/oMWEUfUmeRq5W6QyJPYaPmPEby4N/vfFgXhIGKbHmVxF8F5ZpVRFDfVsPz 5BRV+uYiTY3SR7ivdI4W5+sQ== X-Received: by 2002:a05:600c:45d0:b0:488:a797:f099 with SMTP id 5b1f17b1804b1-48fe61f0787mr42703265e9.3.1778889385760; Fri, 15 May 2026 16:56:25 -0700 (PDT) Received: from localhost ([202.127.77.110]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c82bb121cd6sm6596384a12.30.2026.05.15.16.56.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 16:56:24 -0700 (PDT) Date: Sat, 16 May 2026 07:56:21 +0800 From: Heming Zhao To: Tetsuo Handa Cc: Mark Fasheh , Joel Becker , Joseph Qi , jiangyiwen , Andrew Morton , ocfs2-devel@lists.linux.dev, LKML Subject: Re: [PATCH] ocfs2: kill osb->system_file_mutex lock Message-ID: References: <934355dd-a0b1-4e53-93ac-0a7ae7458051@I-love.SAKURA.ne.jp> <831c4fc1-c89f-48bc-84c6-25b2cefc2b20@I-love.SAKURA.ne.jp> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Sat, May 16, 2026 at 12:51:32AM +0900, Tetsuo Handa wrote: > On 2026/05/16 0:35, Heming Zhao wrote: > > Hi, > > > > The logic here is incorrect. The purpose of the refcount is to track how many > > consumers are using the inode. > > The igrab(inode) for the first time is for getting a refcount for the slot, isn't it? > The igrab(inode) for the subsequent times is for getting a refcount which is supposed to be dropped by the caller, isn't it? > _ocfs2_get_system_file_inode() always gets a refcount which is supposed to be dropped by the caller when it succeeds, doesn't it? > > So why do you want one more refcount? > Hi, Could you please reply inline? your current reply style makes it very hard for others to follow. I made a mistake in the previous email, and wrote the analysis to continue my previous email. - Heming