From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A6E82253A1 for ; Sat, 16 May 2026 06:20:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778912429; cv=none; b=NlA0Oiol5V6ELAzfybwKmiR/wHQVCPu2sZuQtdvSCEGMkh7AwuwMxlnXjMYaGwPhdG5L/FxcXn89jqDyDDIg/u19/XVfOUohamhsIIR723TvGoRx4TgYUBCNhe5TjTBfS7hu7Ltl2Ag/pTb79jJcb8P0MleX/waGt5T2IUVRmj4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778912429; c=relaxed/simple; bh=7PTODfnF4jDteFIS1B1CiL9RVSWqvR65lQqW2IWikZ4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=oNuxnRkslbpcQpGM8hsPnphMx3rQ+nm92GGN9wBVDksw7VeIzL1e/oFdQJnKqJcGPJOxVcefcM8JtIld/ftglCWxGeHN5kTwFmUSWyIdqGW8zpi8p7dfGQLdOcfB7B62I6wbc79jt4QJx7rg9WjIilVVw4dV1IwAeKt6v4uLDCw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b=v9zveaLe; arc=none smtp.client-ip=209.85.221.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20251104.gappssmtp.com header.i=@baylibre-com.20251104.gappssmtp.com header.b="v9zveaLe" Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-441209fb77eso207247f8f.1 for ; Fri, 15 May 2026 23:20:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20251104.gappssmtp.com; s=20251104; t=1778912426; x=1779517226; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=iwTg4sm4cNnVhMg5s/1uHcLhMcdNPNXew85SDkoB75M=; b=v9zveaLe/1IYWCZO4NT/iDuVyhTLkWWbKFxKrJEL4u7FzlTl7yVky0OwjkOOhVbr6c okHTORfP+UA+xrwNnHDYXW/pddY4PUwjhGJphgH2ExnTo2ZmPBN/rXzZYJc1xROMdU0E q4F8ZCsihG7AOvHxtbzNi3OdTUJxUzsnvtLyvG/600D2vHjoRKmkNQIRouvoWpHL7WkZ L/qlmXeI9tSKMZ1T/RX8kqK6M9d0QLgJmtZSFAAGn1WprW+rAnA70OL2rkww9WmUd0t/ SYKpuRPI2lgO7H8IGffrSTAkjthuQU1zYiI0kTMYRZRD8PSSn3C4H2WqC8y7j/fxylCE 3Zfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778912426; x=1779517226; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iwTg4sm4cNnVhMg5s/1uHcLhMcdNPNXew85SDkoB75M=; b=HoxDvUPTgxckTRQtF47SBUbh8fMY+f+JBpTmZZf1YPbaujpWiX2apBqvcwtxrTNyr3 1qFCpunqiNxDImin3aytd20gQZlFAF0JD9KG7UE8b9v2OhcqZNNPInaZXcbcXVAthXFY 9BzGCXnNZP/Ase8F/yzF838SfDdEHS8nG3WA+nsaauVFGreeXBy+3vTQ9BwYxJLWwkis B0JLXK+4DixjWM0pBhqD8bdQjNgqdYqadan+pt3Xl86PlKdHgC+P60lSHMOhirWsO1fw p7c7miJ2Ox3TmSsG9clhwYtokg6UUGEAUuyvr0B7jxexLnOyXna+Vkn5k8IoRnG4gMm9 395Q== X-Forwarded-Encrypted: i=1; AFNElJ/6Ee8Rch0MQqQs0NoEGyZfbvaAiaFRuWQlWcVzMq7SO8wXUE6EZzfBDJAQ8sn94iZ2wiTEXw==@lists.linux.dev X-Gm-Message-State: AOJu0YyxLClieUM/6hPrf71bt9VJft+gP1opFrFLXUENVM5KBplRpVbD csLkVxpqDJ8mrp7GPQtNHc8v6C0P1nrd/OBzZ9rnniXqoH2Ur9GMfzw7rO5/iYqVrK4= X-Gm-Gg: Acq92OFAN/Y3O9Kl2LoOvl1wsWFPYhajttoT9sDKh5FkiqxeKU1c5rL/LcLFg+2+zuf argVyQZyVr4FLJjeK8TczL/N/uwWFXv6PIyHCdA695kRhLVFVmmtVPnBK3dUsMzKKmQf8GeC7ve r3XMt8rJMQfX6L8hYQ54f+HlKHIMbDHVaAJJaWUM+sSEqycNvLMf1/y1zfcW/SzezRcf+Ij1tsA yGQb43X5IHCBVxrpiDD4sc/3aFcsrE9fScNxvOJYO1bawJs+mxQAFiAHRxG0dOzbUQTcb/9e3dL Kk8Ytx2bQvIU4W3/5Db6aN9JNuYt9/4Nlir8AUtoFRqtcpXSXItjX93Y+BUByA72TmHuDgjuH34 rmqlezhIoMeq+zyNvh9GURA0Z7bf/sYM/1lhPu6cAdDRKQfyB6y7rC8vSOw4/wCJGRrr/WXUo1j SU1jec/p/o8IMvzc3X3nAuDyzhfT8iyPYihZNn7NM= X-Received: by 2002:a05:6000:248a:b0:451:259d:83fc with SMTP id ffacd0b85a97d-45e5b886085mr10629272f8f.17.1778912425850; Fri, 15 May 2026 23:20:25 -0700 (PDT) Received: from localhost ([2a02:8071:56d1:2de0:1d24:d58d:2b65:c291]) by smtp.gmail.com with UTF8SMTPSA id ffacd0b85a97d-45d9e767d16sm20858858f8f.6.2026.05.15.23.20.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 May 2026 23:20:25 -0700 (PDT) Date: Sat, 16 May 2026 08:20:24 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= To: Liam Girdwood , Mark Brown Cc: David Rhodes , Richard Fitzgerald , Jaroslav Kysela , Takashi Iwai , Shenghao Ding , Kevin Lu , Baojun Xu , Lars-Peter Clausen , Nuno =?utf-8?B?U8Oh?= , Martin =?utf-8?Q?Povi=C5=A1er?= , Support Opensource , Nick Li , M R Swami Reddy , Vishwas A Deshpande , Peter Rosin , Matthias Brugger , AngeloGioacchino Del Regno , Oder Chiou , Fabio Estevam , Kiseok Jo , Kevin Cernekee , Steven Eckhoff , Kuninori Morimoto , Charles Keepax , Thorsten Blum , Chris Morgan , Dan Carpenter , Marco Crivellari , Weidong Wang , Aaron Kling , Teguh Sobirin , Luca Weiss , Bharadwaj Raju , Hsieh Hung-En , Binbin Zhou , Shimrra Shai , Zhang Yi , Krzysztof Kozlowski , Srinivas Kandagatla , Qasim Ijaz , Sharique Mohammad , Chen Ni , Neo Chang , Cezary Rojewski , Cristian Ciocaltea , Kees Cook , Qianfeng Rong , Tim Bird , Bram Vlerick , Peter Korsgaard , Linus Walleij , Wenyuan Li <2063309626@qq.com>, Bartosz Golaszewski , Shengjiu Wang , Sebastian Krzyszkowiak , Xichao Zhao , linux-sound@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Markus Schneider-Pargmann Subject: Re: [PATCH v1 2/2] ASoC: Use named initializers for arrays of i2c_device_data Message-ID: References: Precedence: bulk X-Mailing-List: asahi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qdeitipt6peg3e5c" Content-Disposition: inline In-Reply-To: --qdeitipt6peg3e5c Content-Type: text/plain; protected-headers=v1; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v1 2/2] ASoC: Use named initializers for arrays of i2c_device_data MIME-Version: 1.0 Hello, On Wed, May 13, 2026 at 07:23:04PM +0200, Uwe Kleine-K=F6nig (The Capable H= ub) wrote: > diff --git a/sound/soc/codecs/max98088.c b/sound/soc/codecs/max98088.c > index 9f40ca4b60d5..df438baf05dc 100644 > --- a/sound/soc/codecs/max98088.c > +++ b/sound/soc/codecs/max98088.c > @@ -1722,8 +1722,8 @@ static const struct snd_soc_component_driver soc_co= mponent_dev_max98088 =3D { > }; > =20 > static const struct i2c_device_id max98088_i2c_id[] =3D { > - { "max98088", MAX98088 }, > - { "max98089", MAX98089 }, > + { .name =3D "max98088", .driver_data =3D MAX98088 }, > + { .name =3D "max98089", .driver_data =3D MAX98089 }, > { } > }; > MODULE_DEVICE_TABLE(i2c, max98088_i2c_id); The indention is wrong here and uses spaces instead of tabs (with and without my patch). I squashed a change to tabs into my local commit, so this will be addressed in a v2 if it comes to that. However we have: uwe@monoceros:~/gsrc/linux$ grep '^ ' sound/soc/codecs/max98088.c | w= c -l 911 uwe@monoceros:~/gsrc/linux$ wc -l sound/soc/codecs/max98088.c 1780 sound/soc/codecs/max98088.c so it is probably more sensible to address all these lines in a separate patch. Best regards Uwe --qdeitipt6peg3e5c Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmoIDKUACgkQj4D7WH0S /k7gSwf+LrTVzNblQTOa3gnZeorGIhj/sMcspAYhIUmYPDtnfBoWNBdCLZc6K4FS R01MPMG067BmfqLJWRVfIPvDrqvTXZEdQbCLfjh0uwXLX6ljzIR6zyhUCXgUcWQ3 u+eHDUCfsppDqVWerbYOIvYuWjiwHKUnrwRhAEzSVdM8thodBh2uJA16VChPQQP6 MjmDYEtytpJ0azMDrGVj0bVo026970Cd6YS4CKLe5vtZxIIqe+Pcl9kto1IPib6V 4A/u+r7xWwgcgwFWAsFDp+hXP7cWWZ4UWr+5K5Yryn1oUh0dRs3OEtG3GVOoDzD4 9is+wvNpU2YideeLn4AUYPLz3Mqh2Q== =EDAl -----END PGP SIGNATURE----- --qdeitipt6peg3e5c--