All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Moksh Panicker <mokshpanicker.7@gmail.com>
Cc: linux-staging@lists.linux.dev, gregkh@linuxfoundation.org
Subject: Re: [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte
Date: Mon, 18 May 2026 07:59:38 +0300	[thread overview]
Message-ID: <agqculuAIOGMBxZJ@stanley.mountain> (raw)
In-Reply-To: <20260516155025.230865-5-mokshpanicker.7@gmail.com>

On Sat, May 16, 2026 at 03:50:25PM +0000, Moksh Panicker wrote:
> ---
>  drivers/staging/rtl8723bs/core/rtw_efuse.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_efuse.c b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> index ef0cec40d388..a9bbfe2d6fb2 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_efuse.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_efuse.c
> @@ -75,8 +75,8 @@ u8 rtw_efuse_read_1_byte(struct adapter *Adapter, u16 Address)
>  		return rtw_read8(Adapter, EFUSE_CTRL);
>  	} else {
>  		return 0xFF;
> -
> -} /* rtw_efuse_read_1_byte */
> +	}
> +}/* rtw_efuse_read_1_byte */
>  

This is v3 of the patchset but it's not sent in the right way.

https://staticthinking.wordpress.com/2022/07/27/how-to-send-a-v2-patch/

You broke the build patch 2 and you're fixing it here by adding the
closing } character.  That doesn't work.  You can't break the build.

regards,
dan carpenter


  parent reply	other threads:[~2026-05-18  4:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-16 15:50 [PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling Moksh Panicker
2026-05-16 15:50 ` [PATCH 1/4] staging: rtl8723bs: reformat rtw_efuse_read_1_byte() signature Moksh Panicker
2026-05-16 15:50 ` [PATCH 2/4] staging: rtl8723bs: add braces to else clause in rtw_efuse.c Moksh Panicker
2026-05-16 15:50 ` [PATCH 3/4] staging: rtl8723bs: reformat rtw_efuse_one_byte_read() signature Moksh Panicker
2026-05-16 15:50 ` [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte Moksh Panicker
2026-05-16 16:02   ` Greg KH
2026-05-16 16:58     ` Moksh Panicker
2026-05-16 17:04       ` Moksh Panicker
2026-05-17 14:41         ` Moksh Panicker
2026-05-18  4:59   ` Dan Carpenter [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-17 14:37 [PATCH v4 0/4] staging: rtl8723bs: fix efuse formatting and brace handling Moksh Panicker
2026-05-17 14:37 ` [PATCH 4/4] staging: rtl8723bs: fix missing brace in rtw_efuse_read_1_byte Moksh Panicker
2026-05-17 14:56   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agqculuAIOGMBxZJ@stanley.mountain \
    --to=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=mokshpanicker.7@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.