From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B77DCD4F3C for ; Mon, 18 May 2026 16:11:01 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wP0YL-0002jg-5a; Mon, 18 May 2026 12:10:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wP0YJ-0002jM-OG for qemu-trivial@nongnu.org; Mon, 18 May 2026 12:10:47 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wP0YH-00025L-Tt for qemu-trivial@nongnu.org; Mon, 18 May 2026 12:10:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779120644; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SeH3OGLaBvy+UbXCY/IhktOKWSgYcArJSXUFmAgJhW4=; b=Exh1WkrgfMQdaxIpOaU6DMIQkvDgjrKDCpZ7HEm8Sj/xW1Nlo1bNorOMXQ4108xZce2dzs BfVxey4tsvGGimdkG4bWsbFIXe796iLZrYcGJvvscL5OUsng//P3vlam/vfWgn92NnAg2Y mRheuj93+jiD0+Kq2w0EDtCPfcHohpU= Received: from mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-mzQ3SwHkOgSG5RzYhrX7yg-1; Mon, 18 May 2026 12:10:43 -0400 X-MC-Unique: mzQ3SwHkOgSG5RzYhrX7yg-1 X-Mimecast-MFC-AGG-ID: mzQ3SwHkOgSG5RzYhrX7yg_1779120642 Received: from mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.111]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 37C2D18005B3; Mon, 18 May 2026 16:10:42 +0000 (UTC) Received: from redhat.com (unknown [10.44.32.79]) by mx-prod-int-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 7F8481800576; Mon, 18 May 2026 16:10:40 +0000 (UTC) Date: Mon, 18 May 2026 17:10:36 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Thomas Huth Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org Subject: Re: [PATCH] system/rtc: Fix a possible year-2038 integer overflow problem Message-ID: References: <20260518160255.1844308-1-thuth@redhat.com> MIME-Version: 1.0 In-Reply-To: <20260518160255.1844308-1-thuth@redhat.com> User-Agent: Mutt/2.3.1 (2026-03-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.111 X-Mimecast-MFC-PROC-ID: H_ehUlh9S0-FyhDJGN-nMkgKjJC7xq-jhFx18KC_Upc_1779120642 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org Sender: qemu-trivial-bounces+qemu-trivial=archiver.kernel.org@nongnu.org On Mon, May 18, 2026 at 06:02:55PM +0200, Thomas Huth wrote: > From: Thomas Huth > > rtc_realtime_clock_offset is initialized with: > > rtc_realtime_clock_offset = qemu_clock_get_ms(QEMU_CLOCK_REALTIME) / 1000; > > And QEMU_CLOCK_REALTIME might be based on gettimeofday() in certain > cases (see get_clock_realtime() in include/qemu/timer.h). So this > counter will exceed 32 bits in the year 2038, thus we should not > store this value in a normal integer variable. Change it to an int64_t > to fix the problem. > And while we're at it, also adjust the nearby rtc_host_datetime_offset > variable to be on the safe side in the related code. > > Signed-off-by: Thomas Huth > --- > system/rtc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|