From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta1.migadu.com (out-181.mta1.migadu.com [95.215.58.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4359D3FDC13 for ; Mon, 18 May 2026 12:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779106443; cv=none; b=ikP5D4gQjPzWFXxTqnNjN6txK3J37ooQ46qM6DMZLzx2wUw07fpXNyhcJTO8ea7rr6Ibz7QhGDd6M5gNFqw3eKg98naQwxI/pXRQoMQqbelL8i3PBZwYSQ1Q75lEY7X//0f/PYGyKSXW7W47UdzmpwNW7jBt1AtcVXz4F9VIQoI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779106443; c=relaxed/simple; bh=DW0XF8rf23d5X+gmo+i/AxtXdmA2DarggHd72B0D/SM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rUxRoDhrK1GnjCtilIbT6Q1TB+4v1a6im0hga3U9zIRKrc7BPEkDPAeWLGcJSlgb/hRLcRe687lro3RrwoFTG7sAtUSSiMsmmru0jJA87vnjyn3pitcaYBD4qdfQT+I7Ys1rj5xIvMsg3YimhRNzxDb5om2fIsLQ21Gn+uRSBmI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=PvsXoBHA; arc=none smtp.client-ip=95.215.58.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="PvsXoBHA" Date: Mon, 18 May 2026 14:13:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779106439; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0muuKtFO8ZActY4ABNCM93lYTjB+9N79PNXdZcDz7Lw=; b=PvsXoBHA9iQabofBXMkxnbZkjobMXORinHKfaShYdm64i7uU8VAYJCUXY30fVE3MoQC7RO gYYuZsrL+DBh9NNovKYbCiiIu+3GT5QrN+vVmnJEO9SfjL8w9pliEiSXQ/ZBD3eWLhYRre p+G7wqOuymztdStiGIQqkJXyIWDuMPc= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Lorenzo Stoakes Cc: Andrew Morton , David Hildenbrand , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Yury Norov , Rasmus Villemoes , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/3] mm: move offset_in_page() to page_helpers.h Message-ID: References: <20260517123428.1181981-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Hi Lorenzo, On Mon, May 18, 2026 at 11:02:10AM +0100, Lorenzo Stoakes wrote: > Seriously, please resend this. > > This is 3 patches with 2 in-reply-to 1/3, that's not how we do series in mm, > take a look around :) > > Write a cover letter, and have all the patches in-reply-to that. A cover letter seemed unnecessary for such a seemingly trivial 3-patch series, but this thread [1] might have been helpful for context. [1] https://lore.kernel.org/lkml/CAHp75VfQNkqEYsO4Uup0c-uiYuVyAWit=tmCz2BsYLp-sjXsZw@mail.gmail.com/ > Was there not previous versions of this? I _seem_ to remember that, but might be > misremembering :) I only know about the one Yury mentioned. This is v1 of my series. > Also I'm really questioning the value of this, you've not sold why we should > take this whatsoever. > > 'Add a random new header file we have to maintain because it's smaller' is not > really hugely compelling. > > Also a _lot_ of stuff in the kernel ultimately pulls in mm.h. So what exactly > has the specific requirement of both needing this define and (somehow) doesn't > use mm? Patch 3/3 is one of many examples that pulls in all of mm.h just for offset_in_page(). lib/string.c from the same thread [1] is another example that would need to include mm.h just for offset_in_page(). Many other files (hundreds) don't use offset_in_page(), but open-code it in many different ways instead: (unsigned long)p & ~PAGE_MASK (unsigned long)p & (PAGE_SIZE - 1) (long)p & (PAGE_SIZE - 1) ... I can't tell whether they didn't know about offset_in_page(), or deliberately chose not to include mm.h. Thanks, Thorsten