From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EDE7C481246 for ; Mon, 18 May 2026 13:15:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110157; cv=none; b=n4sJS6ISPpGbO1ArqlV8nNtStfrrRNjARWSmRyMW1hCg0nW3UZ+gn0AxJfrZjBNFMcAN6q6AivcxhQspwewk1elfnS6/Ob33ypRDiqJzX8t9DDSkJg8rVQgzyn95mamJdmkqFPuhIV06bHWKH11b6urS+sg2xX3W1LePEUBz3dM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779110157; c=relaxed/simple; bh=nWUfw8QXC2TjnPMANGnSBNKeB3mMxYIg1FpKOqB2U98=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bzpkp5enirNPKUSDPN85Qg7iBTLsS+b2y7gHTlFmg+tNqD32fKOTuQnVB8Dt15pyf88fvZUTAAaURJhn9M480cXStBk3bjAjLXczFZ1lGJVm+sSYi19aeeanKJM0TrR/uiHs3fI4QwuL0sC6gxp/VaK4gX0Kf60ooVGAwt8y8KE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=PWzkETyZ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="PWzkETyZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 253CBC2BCB7; Mon, 18 May 2026 13:15:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1779110156; bh=nWUfw8QXC2TjnPMANGnSBNKeB3mMxYIg1FpKOqB2U98=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=PWzkETyZcvkED2g56IsDola7+Qj5zm3CXaJF6TSegsvgyu98xentbpBc547ZdEQKn H8bRPAg/sWyS+ICzt07HhXj3uIqLt0VUewuS1hsdLNfLJQ8llO/uALAazbNvIMRE2p pFqaB2v5KLYd7fA43AZOR/EBKmvX8zvDBMjX2dW6XCGyxmaO4bEXNzqnULZJrqWis9 H+a6Lkbk/dGEYZn+z1gblaHDLeYUgQ474X5C/0K5DUeLZ1a0qjZbKbdhRQAFUx+RT+ QUYZoRnJ8df+MvzmuMv7kR6M3HwA+gqQXCbgZHQwS9CkP3SQTm/Ize1LIMVOnR46RI ubuG8/Oa5baoA== Date: Mon, 18 May 2026 14:15:50 +0100 From: Lorenzo Stoakes To: "David Hildenbrand (Arm)" Cc: David Laight , Yury Norov , Thorsten Blum , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Yury Norov , Rasmus Villemoes , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] mm: add bytes_to_page_end() helper Message-ID: References: <20260517123428.1181981-4-thorsten.blum@linux.dev> <20260517123428.1181981-5-thorsten.blum@linux.dev> <20260518100933.6bfe5b8f@pumpkin> <8d7dc7e2-d52b-4903-ad1b-3185b393ba24@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8d7dc7e2-d52b-4903-ad1b-3185b393ba24@kernel.org> On Mon, May 18, 2026 at 03:06:16PM +0200, David Hildenbrand (Arm) wrote: > On 5/18/26 12:24, Lorenzo Stoakes wrote: > > On Mon, May 18, 2026 at 10:09:33AM +0100, David Laight wrote: > >> On Sun, 17 May 2026 11:28:05 -0400 > >> Yury Norov wrote: > >> > >>> > >>> I've got a series for this > >>> > >>> https://lore.kernel.org/all/20260303182845.250bb2de@kernel.org/ > >>> > >>> The feedback is surprisingly negative. Please add people from that > >>> thread. Maybe you'll be more successful convincing them. > >> > >> I don't think you need a another new header. > >> There is already vdso/page.h which is where PAGE_MASK comes from. > > > > Yeah please don't, that's already a weird situation I don't really love the idea > > of extending that. > > > > mm_types.h seems the more appropriate place. > > I think I'd prefer vdso/page.h for something as basic as that. > > But definitely no new header unless really unavoidable :) I just find vdso/page.h an extremely weird beast. what does the VDSO have to do with it and why are we smuggling some basic definitions there... I'm still waiting for an explanation as to why this series is necessary, I'm guessing build times (though I wonder what the actual delta is). But yeah, I mean if you're fine with something else going there then fine, that or mm_types.h or some existing header, the new header is the nope thing here. > > -- > Cheers, > > David Thanks, Lorenzo