From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010070.outbound.protection.outlook.com [52.101.46.70]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B8653E16AD for ; Mon, 18 May 2026 15:29:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.70 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779118174; cv=fail; b=iNXHuIcfwu+P8hyh2L92skbAMjUkEl13a+2HYCCrlvcpVdk+ESe0qICl9oB5iNkXMJQNNXpdSb/Z5EuG712awF5k6Y7fxLFAlfzlz40CwMgWRXKA7R995QOKfU0QDOVrHrLcukh2+cBFr+viJYfbQFJIoycBA6snCAmIRG7JfOI= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779118174; c=relaxed/simple; bh=5JwoOreo8jRf83aq3uaFY9+KpTruZ3AJ4cvXguNIwN0=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=a+IbR3wunHAf7e0/m2j0ZDmlXvkwM35lmHajtfjb4krlhd0ANs543z1IElUqpGnMQSUzERA6jF3OwZ3POL2n87qByGnD30FklWZojOnE+jZ1McDJYtxHfhweJlzGueuBtc37yzbmmAUQ6QC+AEkHiI1z7PA+d0hYHi6pbwXVnTw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=SMgnRAlD; arc=fail smtp.client-ip=52.101.46.70 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="SMgnRAlD" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ZKcnyynMWTBPymSP7UpqhcEID0TibdAfSlBJBJe7otWG6WtWw7HTjUL1TfbPrF3kXJRD++crDkwff2BNHSdrrvMX7WyY3PxNsP6Dgevc+KXU0ef+S33uz4vsaxq2sN3PwBrodDcO82y874Xu9ROESm7AU4LyA6j4EbQjJytPof7w59M8dzq7whCu2aGgl2DTR0C4ttS000DGvA/6pcEZ1dUjLv/OsrPGNgp5lZC/XD46dxLnDCW/BDWNEvXe2D2boqT57mN/ehb6+rXKaJvaNkN6VmrHg9k/je2MxgBnxlOcn8XL6R8WKHs7BdGLOBL5e3tfxDZ7Op6tpYLQEFlfMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Hspo1GHeGBT3ARBE1acY01+1Ei7Vya253Dzoi8hKI/o=; b=ksarwmuBO/RjBgTxZgqb4ZBHDPIRs7lOpYaiggC3YXPxbVoqCDiYGIpnKVwUvxKqg3TWI0IJnczH6TbB15zOLKzXIeS4Vv5QqGuhAeszCzbaEA928Tat25Q9aLSK18ZNvtdtfDSHujpLxyLFPhfyHI4p2VwgyX5GM4X+fldIuiPvCJ5fJc2nWBrq1Za2dblmdlP6lpaE+wViQDmwdMOKDFvHQgII6H8qfCVBsAJQ2dROPo8Qc0xrWrHZXwQtfW9Zsg0uhAFwjEj2Gt67wgQpE5pTmS0pbrK86jkTDeu0BSOtghaFBmmdGlikBtitQ1RQgdfKq7voF2dNp1mCowaywQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Hspo1GHeGBT3ARBE1acY01+1Ei7Vya253Dzoi8hKI/o=; b=SMgnRAlDkiTn6C08u0TR2ehqeJBfmNoZdL3TlFrhYuZ65rYYNDNGLasvdOsIv5Ujgi+WnvTQjZwzVBZUpdPSlevd2vPuDAGLEjS+fkcrZfmqu2EBd6aGChxCGAMNtDsfmkIq6WuLv2X53sjAute65OHut/695+79Gh8MDHdbRDiZvdjFK/6TjRbf4GtOw5PEyDGaXtma5Oio8asFAWW5U9LqaG1qxyT08c1oz+Ebm9peSlgN33t09sk7TTVqjjgB0igITVEOZHTyb8ai6+nC1axdqMsCx4vSppHbKSMaJ9SLWoXhl70eV4XzzyM4e+xuij6lnwDzBVCQF/UZrHDMLQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) by SJ0PR12MB6967.namprd12.prod.outlook.com (2603:10b6:a03:44b::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.23; Mon, 18 May 2026 15:29:19 +0000 Received: from CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de]) by CY8PR12MB8300.namprd12.prod.outlook.com ([fe80::ce75:8187:3ac3:c5de%3]) with mapi id 15.21.0025.023; Mon, 18 May 2026 15:29:14 +0000 Date: Mon, 18 May 2026 11:29:12 -0400 From: Yury Norov To: Thorsten Blum Cc: Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Yury Norov , Rasmus Villemoes , Andy Shevchenko , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 3/3] lib/bitmap: use bytes_to_page_end() helper Message-ID: References: <20260517123428.1181981-4-thorsten.blum@linux.dev> <20260517123428.1181981-6-thorsten.blum@linux.dev> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260517123428.1181981-6-thorsten.blum@linux.dev> X-ClientProxiedBy: BN1PR14CA0013.namprd14.prod.outlook.com (2603:10b6:408:e3::18) To CY8PR12MB8300.namprd12.prod.outlook.com (2603:10b6:930:7d::16) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CY8PR12MB8300:EE_|SJ0PR12MB6967:EE_ X-MS-Office365-Filtering-Correlation-Id: d561145a-9bf6-4fc7-b36c-08deb4f23774 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|10070799003|366016|1800799024|376014|7416014|11063799003|4143699003|18002099003|22082099003|56012099003; X-Microsoft-Antispam-Message-Info: r2scDV2zYg0xEL+WPQyjs5/KxhDCsV8ZVm2JMhX1qJsnDuRamN2LxUjga2GRzrsPuSGKPouIdD+8VMtnqMOsTpn2PQ/+BqleMsrb9Yf4F8DeJ/MqcQDudhuEN/3R4EQv+Z2Bx29mWUMqVFldvqZ7VfSPQWdVzxCZj8QI4R79k0utUUSsSuWlFhXekflL79IlxD8DLFpeiCkWI7BfjayPef+77VwtQEIuOsaJ1hxXQ36VBQwcygybQ9amRhsi/Qn48ITZZlOjzwv9Huz0IrjnQer9kXE1cP5Mpof4u0K7NeNORvWzt6KgqaEi1NK7NcTVpPC4b4fVKk6efyQPxcSq9w6RLM+GqF6pDv8pIYMxwVQodhC21KbF0+2qsS4eSdzvC17aNxNA5/elW7u/i7w89K72q1xwZ5FSE8YRuq9YjtXJLaOjTdJBiZx6vYHYWbtcYl0y2up36QUlfMI9nMgY3C802f90U9JUQMlmxH1S2AyEGqtc8nvu9HPcX/gtnijy78MDRrPyMTBe5GY0jzXYlEbPSxY+k9mLD6LeLCBf5zIUNGwtxoubc5oHMPXg78OkVD70yLc0Pv5yosrutYLZTEWzIcLK2elBrspXWwUpqTZvW7H67jOe0wWC0cIthBzncOpfNlc5pkKUjQwOtfmZoxdkGyyKqpIMQWD/ZIgnejs9/L9/H9SSaHXDrU0Os2Opp4FCqcFgNqZbE4Y5S4b0JQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:CY8PR12MB8300.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(10070799003)(366016)(1800799024)(376014)(7416014)(11063799003)(4143699003)(18002099003)(22082099003)(56012099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?lF9bD6kYiAGqt7/mqdvhJslTQu01AbRH5lvjTOIj/j9qhaJv3wg1DvjM5aRT?= =?us-ascii?Q?2dr59O0cKnsORnhVFWniWkLvPzCT2WL6MFiEcOMZdhPeuIr9TUBxm3lxoTfV?= =?us-ascii?Q?t/VNs0remCcbuIFVnVfxnLOkhy01VV0/dOqbaqepjYgxCUSuoK/M/puo6EG4?= =?us-ascii?Q?3nvECyep8hia78prc4p+z62+Byf3CYwR6IMxAn7rEISl30T3QaM4RaNnZouh?= =?us-ascii?Q?5jX+b5uw4pKLwp8a5x7Xup86Yrt31HdXcVgbzCyi4D37JB6iMbmwd7HCgBcs?= =?us-ascii?Q?iW629zhxJg3ALxmpPsMczLdZZjDg/av+tB08ru5oS6dQODVtjfmw1zq5kLUX?= =?us-ascii?Q?jVwgjVwRN/y6TUqQsaS7Z8IEuEfT0lMOJBdqmh7RoBopScly1+QK0jEqDgld?= =?us-ascii?Q?OIXG62WAUC37Bh0y4yoUbesBmSeNxQXT0OXcJjzZT7vH8kX3xVNsXfkUxtDC?= =?us-ascii?Q?JJCZQRIvY9pWMfrJCgnEYZ6ttSzUEIBEI8bKkUSTUids1IglmiZE/HBmtow7?= =?us-ascii?Q?1sXVpeNmrcQttp3VQAR8vshT+oAznm+WDgi3k4whZVCvMRho5LscFTgFcTtW?= =?us-ascii?Q?2dRZ/jZYXmCzsVx0lTvOwuqeupDFxgzrUshatA1qyuKmi1iP07oGSWZmm6wZ?= =?us-ascii?Q?C0o+tX2Y0fasHEE81Dd9KTC8vHNLfKG5r8zlyI0bVpCSTfhivoN3TqJjwd3r?= =?us-ascii?Q?8xH0rUUe7VBKSAMuS3AzU5cZGgOyFPsoLYY6HEAaM1qzrBiHk1qBHC79y4XT?= =?us-ascii?Q?w8mvOJ8Ybh/mu5VXBE1ef+I8W/aRXKIxfZlqlQqxmx5YmMVjoIO5GPN5GQcE?= =?us-ascii?Q?+SUYaRPi7PsFVjLb7Hj95XQPUoZtqqOxuSjJA/tt5RE/t5T07RPuIUfjBB0U?= =?us-ascii?Q?qVnIYgPCI46+9RcxWcgjVXQyMrb8T1bfdeZInu4dexNhCsrZg1wAV0QeBrMF?= =?us-ascii?Q?IJHeXN6Ui04jkePVOGej2A8rXw4fUbywKBEPKWWBYcvlsJnzcSWmw9eK00aP?= =?us-ascii?Q?3M0EArUYKO1VSSegaGeyi+kU0fTZmQ/hcyqQC+bKfpXsGEMq5hGdNtiTVjbO?= =?us-ascii?Q?yQupkKRu7jXY7FpAktr6au9t2xh9XstS4S5rrLzI2ol/jGLbo/T/G7imEl8z?= =?us-ascii?Q?G/UjIoN13mcaqDSiJjfmeIuiGE9L+qLUBzeuyZjN2dscStt8t9NWrPuGwfGZ?= =?us-ascii?Q?rctq7aOv13ADmOTmTJ3ATpZgjzhP9Ki72RzXIijMWB2SVTCzshq0022LaYX/?= =?us-ascii?Q?qZgOWtE1C7Jw7zcRL5NrVH7ia2WTWbdlkyLm+0cjF5V+L1wh9/mi33a045za?= =?us-ascii?Q?G/9cAdRBiQQoJEPOuAqA6MZPMaKJKAbldf4pgDs4HoT66bPz/5kTq9E9YtL8?= =?us-ascii?Q?t/Q1O0Awya+6BI1Qnh57gEEzG+w8eFWCsB/PskhVck6RTIyFqcOop1c8gqLU?= =?us-ascii?Q?QGKGyZIV4YmFdVKaFz7wPmSCQyuv3sGEmZnc524sbT7JoiwY118ckP0ZZuDC?= =?us-ascii?Q?8ZRpv1APOS0pdsQXSPn3gYHMzYK9GSA4kgTjXvngzkj3YhhZTIdRy/YbY5rG?= =?us-ascii?Q?QaFujDHoBaQXWnfi9Dl/8S/BJANZ3R4AMvUtSowPLYBx8izhUVg1wkiYeXma?= =?us-ascii?Q?M4PLtr5oBu+TjXilpH8vNSKCpR5mlTOVghqa/fpvUtjguRHFAHIJlaFNC9MC?= =?us-ascii?Q?esaKU1uhiumuEZjTlJDKKKFWZSHPE20D4v956pk65wJh7WrtoZzQ8P+2PGUB?= =?us-ascii?Q?Tq4m361voTYq2JNxbtBcgIvIl06JL5O+yIm/zElxUv5XOyXBWPmn?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: d561145a-9bf6-4fc7-b36c-08deb4f23774 X-MS-Exchange-CrossTenant-AuthSource: CY8PR12MB8300.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 May 2026 15:29:14.3471 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 067TnU47EdvfJ6YPR6iTC91ftwSapY08v2ueoxpQIA7r/dZYv5A85uJAZTTM4MgGOc9+7KwM49yfXv0QJhsc2g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6967 On Sun, May 17, 2026 at 02:34:31PM +0200, Thorsten Blum wrote: > bitmap-str.c includes linux/mm.h for offset_in_page() and kfree(). And there's nothing wrong with that because it's a .c file, right? > Instead, include linux/page_helpers.h and linux/slab.h directly, and > use bytes_to_page_end() to simplify the code. I'm OK about narrowing down inclusions in broadly-used headers. But here in a regular .c file it doesn't look like it fixes anything. Maybe some circular dependency you've not mentioned? > Signed-off-by: Thorsten Blum > --- > lib/bitmap-str.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/bitmap-str.c b/lib/bitmap-str.c > index be745209507a..bf245a3eae4a 100644 > --- a/lib/bitmap-str.c > +++ b/lib/bitmap-str.c > @@ -7,7 +7,8 @@ > #include > #include > #include > -#include > +#include > +#include > #include > > #include "kstrtox.h" > @@ -58,7 +59,7 @@ EXPORT_SYMBOL(bitmap_parse_user); > int bitmap_print_to_pagebuf(bool list, char *buf, const unsigned long *maskp, > int nmaskbits) > { > - ptrdiff_t len = PAGE_SIZE - offset_in_page(buf); > + ptrdiff_t len = bytes_to_page_end(buf); Don't worry about this function - it's on a schedule for deletion in this cycle. Now that you're fixing the only user that is going to disappear anyways, this new macro is going to become a dead code. Can you please check the other ~90 users over the kernel. I already mentioned the series taking care of them. https://lore.kernel.org/all/20260304012717.201797-1-ynorov@nvidia.com/ Maybe just start from there? Thanks, Yury > return list ? scnprintf(buf, len, "%*pbl\n", nmaskbits, maskp) : > scnprintf(buf, len, "%*pb\n", nmaskbits, maskp);