From: Christoph Hellwig <hch@infradead.org>
To: Dai Ngo <dai.ngo@oracle.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Dave Chinner <dgc@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
cem@kernel.org, linux-xfs@vger.kernel.org,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 1/1] xfs: fix overlapping extents returned for pNFS LAYOUTGET
Date: Mon, 18 May 2026 23:30:30 -0700 [thread overview]
Message-ID: <agwDhixPAAA0-cTa@infradead.org> (raw)
In-Reply-To: <606c4cea-70d2-4601-9db2-611cd35c3687@oracle.com>
On Mon, May 18, 2026 at 12:55:17PM -0700, Dai Ngo wrote:
> As shown, the file map changes. Entry# 7 and 8 before the NFSD calls
> merged into entry#7 after the calls. So there must be some activities
> that cause the map to change. I don't know whether the activities were
> triggered by NFS or something in XFS or the block device layer.
Hmm. We only insert layouts (and search for conflicts) after calling
->proc_layoutget. So this might be racy against unwritten extent
conversion, or other writers, which is a bit of an issue. I guess
we need to fix nfsd4_layoutget to insert an in-progress layout before
calling into ->layouget.
> However, based on this data I think it's better to change the bmapi_flags
> from XFS_BMAPI_ENTIRE to '0' to address the overlap issue.
We absolutely should be doing that as I said from my first reply.
Still trying to understand what is going on here at a higher level,
though.
next prev parent reply other threads:[~2026-05-19 6:30 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 17:21 [PATCH 1/1] xfs: fix overlapping extents returned for pNFS LAYOUTGET Dai Ngo
2026-05-12 17:34 ` Darrick J. Wong
2026-05-12 19:21 ` Dai Ngo
2026-05-13 7:01 ` Christoph Hellwig
2026-05-13 15:50 ` Dai Ngo
2026-05-13 17:28 ` Dai Ngo
2026-05-14 0:25 ` Darrick J. Wong
2026-05-14 17:19 ` Dai Ngo
2026-05-14 17:49 ` Darrick J. Wong
2026-05-15 21:39 ` Dave Chinner
2026-05-16 2:14 ` Dai Ngo
2026-05-18 5:09 ` Christoph Hellwig
2026-05-18 19:55 ` Dai Ngo
2026-05-19 6:30 ` Christoph Hellwig [this message]
2026-05-19 13:44 ` Dai Ngo
2026-05-19 14:59 ` Darrick J. Wong
2026-05-19 17:34 ` Dai Ngo
2026-05-20 8:24 ` Christoph Hellwig
2026-05-20 15:09 ` Dai Ngo
2026-05-20 16:48 ` Darrick J. Wong
2026-05-20 17:32 ` Dai Ngo
2026-05-20 22:08 ` Sergey Bashirov
2026-05-15 11:50 ` Christoph Hellwig
2026-05-15 11:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agwDhixPAAA0-cTa@infradead.org \
--to=hch@infradead.org \
--cc=cem@kernel.org \
--cc=dai.ngo@oracle.com \
--cc=dgc@kernel.org \
--cc=djwong@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.