From: Thorsten Blum <thorsten.blum@linux.dev>
To: Michael Tretter <m.tretter@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] media: i2c: isl7998x: inline i2c_check_functionality check
Date: Tue, 19 May 2026 16:35:02 +0200 [thread overview]
Message-ID: <agx1FtT14NeJZGf7@linux.dev> (raw)
In-Reply-To: <agxyfLuFArQ464Ea@pengutronix.de>
On Tue, May 19, 2026 at 04:23:56PM +0200, Michael Tretter wrote:
> On Sun, 17 May 2026 19:20:35 +0200, Thorsten Blum wrote:
> > Inline the i2c_check_functionality() check, since the function returns a
> > boolean status rather than an error code.
>
> Actually, i2c_check_functionality() returns the boolean result of the
> comparison as an int. It's better to treat it like a boolean, though.
>
> >
> > Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
>
> Reviewed-by: Michael Tretter <m.tretter@pengutronix.de>
Thank you for your review.
I sent a patch [1] to change i2c_check_functionality() to bool, but
Wolfram asked to change the int call sites first.
[1] https://lore.kernel.org/lkml/20260421161607.61314-3-thorsten.blum@linux.dev/
next prev parent reply other threads:[~2026-05-19 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-17 17:20 [PATCH RESEND] media: i2c: isl7998x: inline i2c_check_functionality check Thorsten Blum
2026-05-19 14:23 ` Michael Tretter
2026-05-19 14:35 ` Thorsten Blum [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-06-02 22:34 Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agx1FtT14NeJZGf7@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.tretter@pengutronix.de \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.