From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f177.google.com (mail-oi1-f177.google.com [209.85.167.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C79D4C9567 for ; Tue, 19 May 2026 12:50:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779195031; cv=none; b=PyrBxm7AXvuXDKxG0VTMY9COeQvThFoM9LugrKv9ZhJk4lX1hSvW/4roh/J42kY/GICmpsQR/uFCEHiirsnkgeAsET7CXoOSQb5CVgzEBpvlNsug6xKcpA6v9sOfPqS4nIompiGLl401Rlj1NAQ9oNATr5RqVNPOsEvrz43uRAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779195031; c=relaxed/simple; bh=SSwS4sdaBiuBbbssRwVSDMXa0Uofp8FixCMZUqSha6Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Uw8nlCwENVbFKWBzhYK9GgZzgMWsDi/tCRNcricKprYC0ZFuAMXsfv3Et9Eyaw677ieOkv5a8mtVsW1AENDQZICxjPsAbC5Je38pEWCg8H0f+rzhIapxZEzVVi3vlsJ7GaKwtEWsitmfXI3Uahn6rBOwALNLkJ2WJUpWPeoTe0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=jnCF2tZo; arc=none smtp.client-ip=209.85.167.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="jnCF2tZo" Received: by mail-oi1-f177.google.com with SMTP id 5614622812f47-479ef2b78f3so3395004b6e.2 for ; Tue, 19 May 2026 05:50:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1779195028; x=1779799828; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=1HZEuM54gZNdUOGSCQijDhK0qQq1J/Ul9HT/qSyapsQ=; b=jnCF2tZooktVDFjaRnGigTjUbCSRfUFUvryCR4sV+efHx/c4qf0g68pPJwWeihuqzB +jrJMYk1OmRRkVKrX2bFenuq9XCnOloI7FEuTifj20ET5A/TJz9GliTD9WoBld+isbRr +JTIo/GfGFvqw3k8bJGeQSsQ+j1jSAdxLTvcvi4PYF6XO19qfJmiU68VHehTAYoMtMi9 ch0PFqAOm7/VGIv6FIGxMAPhSFudqOWFUnMbeyVLeHNKStNNT3DrC0wMdnw6rN4u480O /IoNLQlviUFQcn7akIoO3VdX7hXNmDtOY24r3QPnRUJQ5DniP+7TFcJMjl9LHDX6SNJG wasg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779195028; x=1779799828; h=in-reply-to:content-disposition:mime-version:references:reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1HZEuM54gZNdUOGSCQijDhK0qQq1J/Ul9HT/qSyapsQ=; b=hvDQDoE2sD66Zu1wrPHK4Kl8gzo9PGL+LImrZbppTwKuH47LEczVKPQVG5RIuHtSlt uIRfOTTkbJsz26L4hw60bHFJNXpvOz40GxJubLWIPa6bR32oUZurrDxinrLM4YRa6wzo bfZ9wS+u1A0uFtFs0gW5RzsxO9VsuD6j9/tWiItYrT0jh9JpZadawG2Rk4BLqRo6T4tA 2eXRahVjtOYyaLPRGG2tDgngFFRydGu8PNt/r00sEtAdHBWbzk4pQX8UpYAbrA94VqGi xR6e8+DkEaF+xOvAPC6VXoZtokRrf2KUyZ6sRgQYS0zaShnQXBL14RsZ56wq72AnmHA5 48XA== X-Forwarded-Encrypted: i=1; AFNElJ+EhR8OBw3JjZPtFH4YfbmbC5mVJ3eo6o6tl5Qv51iKWf3V/qL+jLrCTyD5SDA5r8x/KfNgNaLUn3Gka/Q=@vger.kernel.org X-Gm-Message-State: AOJu0YyTx2nqE5TdXLXjD2E2Vlvm6TvMBqEO4rj4AWHyus07bBjWMcBb 1Iq32E3lIhfR3CoyKpdUCLvVTo/RObZH47VxF5EHkFjqCV3FZbbgxS/6xkeRXDNF7SQ= X-Gm-Gg: Acq92OERCp2nft3N6TatEXhPvy1vJ4W84/Rq+93kljOhiUlQnO+Lg+4flnZhikR7h5/ By6YSN2aQQWM9MkonUICVytvH6R7XUAOo6frqoQ55cVUrdO9l1QFL0l0+8OKxLLc249j8f3XBuv q2MfGzmxmKgLuooNuu0k0wkAf21imgNOBOo9mvrlRWhj+SYCIjFHJwwxVsImtrF207xfUD+rXha QOR7znO1RPfQFgzBCexGkQEnGQ+TmQQIKpXKualQ0XsnMEHn0gL60MoOm+SP4tL5EsQ/bGS/iNo 079vXAGl9zbS1fszUNINLwYr9i9VAxhQ2/WBbW9bDt9iGtob0v4ISlN2iP/LCjlpZoltoYuU2Rz qFRZ07dOJI2t5mQvSZCPlWXJMtKok672mF5lde1dmbRs/kTFeftr+dvW/8ZqMCB/3nT7H5+A3XX 9DKSd8+8fiG/ctAE8DhMP+rUK1ZseCEExGE+4GI+8zSqcjpgZ+iZKIrln6MBwIvvSw0e/8znMDC R+c9i3Zt1SPL5K6ELfXlEv4 X-Received: by 2002:a05:6808:e407:b0:479:eb19:6e6b with SMTP id 5614622812f47-482e5609a80mr9111194b6e.15.1779195028228; Tue, 19 May 2026 05:50:28 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:aa2:381f:151a:2c86]) by smtp.gmail.com with ESMTPSA id 5614622812f47-482ee389209sm6663719b6e.5.2026.05.19.05.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 05:50:26 -0700 (PDT) Date: Tue, 19 May 2026 07:50:21 -0500 From: Corey Minyard To: Jisheng Zhang Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ipmi: Use LIST_HEAD() to initialize on stack list head Message-ID: Reply-To: corey@minyard.net References: <20260519055722.13161-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260519055722.13161-1-jszhang@kernel.org> On Tue, May 19, 2026 at 01:57:22PM +0800, Jisheng Zhang wrote: > Use LIST_HEAD to initialize on stack list head. No intentional > functional impact. Thanks, this is in my next tree. -corey > > Change generated with below coccinelle script: > > @@ > identifier name; > @@ > - struct list_head name; > + LIST_HEAD(name); > ... when != name > - INIT_LIST_HEAD(&name); > > Signed-off-by: Jisheng Zhang > --- > drivers/char/ipmi/ipmi_msghandler.c | 14 ++++---------- > 1 file changed, 4 insertions(+), 10 deletions(-) > > diff --git a/drivers/char/ipmi/ipmi_msghandler.c b/drivers/char/ipmi/ipmi_msghandler.c > index 869ac87a4b6a..7a4566046b68 100644 > --- a/drivers/char/ipmi/ipmi_msghandler.c > +++ b/drivers/char/ipmi/ipmi_msghandler.c > @@ -1610,14 +1610,12 @@ int ipmi_set_gets_events(struct ipmi_user *user, bool val) > { > struct ipmi_smi *intf = user->intf; > struct ipmi_recv_msg *msg, *msg2; > - struct list_head msgs; > + LIST_HEAD(msgs); > > user = acquire_ipmi_user(user); > if (!user) > return -ENODEV; > > - INIT_LIST_HEAD(&msgs); > - > mutex_lock(&intf->events_mutex); > if (user->gets_events == val) > goto out; > @@ -3785,10 +3783,9 @@ static void cleanup_smi_msgs(struct ipmi_smi *intf) > struct seq_table *ent; > struct ipmi_smi_msg *msg; > struct list_head *entry; > - struct list_head tmplist; > + LIST_HEAD(tmplist); > > /* Clear out our transmit queues and hold the messages. */ > - INIT_LIST_HEAD(&tmplist); > list_splice_tail(&intf->hp_xmit_msgs, &tmplist); > list_splice_tail(&intf->xmit_msgs, &tmplist); > > @@ -4442,7 +4439,7 @@ static int handle_read_event_rsp(struct ipmi_smi *intf, > struct ipmi_smi_msg *msg) > { > struct ipmi_recv_msg *recv_msg, *recv_msg2; > - struct list_head msgs; > + LIST_HEAD(msgs); > struct ipmi_user *user; > int rv = 0, deliver_count = 0; > > @@ -4457,8 +4454,6 @@ static int handle_read_event_rsp(struct ipmi_smi *intf, > return 0; > } > > - INIT_LIST_HEAD(&msgs); > - > mutex_lock(&intf->events_mutex); > > ipmi_inc_stat(intf, events); > @@ -5101,7 +5096,7 @@ static void check_msg_timeout(struct ipmi_smi *intf, struct seq_table *ent, > static bool ipmi_timeout_handler(struct ipmi_smi *intf, > unsigned long timeout_period) > { > - struct list_head timeouts; > + LIST_HEAD(timeouts); > struct ipmi_recv_msg *msg, *msg2; > unsigned long flags; > int i; > @@ -5120,7 +5115,6 @@ static bool ipmi_timeout_handler(struct ipmi_smi *intf, > * have timed out, putting them in the timeouts > * list. > */ > - INIT_LIST_HEAD(&timeouts); > mutex_lock(&intf->seq_lock); > if (intf->ipmb_maintenance_mode_timeout) { > if (intf->ipmb_maintenance_mode_timeout <= timeout_period) > -- > 2.53.0 >