Re: [PATCH 1/1] hw/scsi: add initial SCSI tape device emulation

[Helge Deller <deller@kernel.org>]

Hi Emmanuel,

* Emmanuel Ugwu <emmanuelugwu121@gmail.com>:
> From: kantnero <emmanuelugwu121@gmail.com>
> 
> Add a new scsi-tape device that attaches to a VirtIO SCSI bus.
> Implements realize and unrealize lifecycle only. SCSI command
> handling will follow in subsequent patches.

Ok.
 
> Signed-off-by: Emmanuel Ugwu <emmanuelugwu121@gmail.com>
> Signed-off-by: kantnero <emmanuelugwu121@gmail.com>

Please use the first only.

> ---
>  hw/scsi/meson.build |   1 +
>  hw/scsi/scsi-tape.c | 221 ++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 222 insertions(+)
>  create mode 100644 hw/scsi/scsi-tape.c
> 
> diff --git a/hw/scsi/meson.build b/hw/scsi/meson.build
> index 69fde0cf84..1699b6e591 100644
> --- a/hw/scsi/meson.build
> +++ b/hw/scsi/meson.build
> @@ -7,6 +7,7 @@ scsi_ss.add(files(
>    'scsi-bus.c',
>    'scsi-disk.c',
>    'scsi-generic.c',
> +  'scsi-tape.c',
>  ))
>  scsi_ss.add(when: 'CONFIG_ESP', if_true: files('esp.c'))
>  scsi_ss.add(when: 'CONFIG_ESP_PCI', if_true: files('esp-pci.c'))
> diff --git a/hw/scsi/scsi-tape.c b/hw/scsi/scsi-tape.c
> new file mode 100644
> index 0000000000..650f75471f
> --- /dev/null
> +++ b/hw/scsi/scsi-tape.c
> @@ -0,0 +1,221 @@
> +/*
> + *  SCSI Tape Device Emulation
> + *
> + *  Copyright (c) Emmanuel Ugwu <emmanuelugwu121@gmail.com>

Add copyright year.


I'm no qemu SCSI maintainer, but for me the rest looks OK.

I'm really looking forward to your first implementation!

Thanks!
Helge