From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23418191F94 for ; Tue, 19 May 2026 17:34:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779212064; cv=none; b=AEi97D/MzxQE+lU+DoTTKalvBFaXgjM9d05YGpxKdgkIKgYRvP45KKqjWLa6jbXeSvZZVMGnK28xHGNnKRwpdj4+bGiuUyjFqDUT1c2gePCmbY7IUUP7VjC+Tf0y+WEAcdi47FZe5jQmslNq3HJiD28ZvO0R9EvT1MrTdXW3+0w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779212064; c=relaxed/simple; bh=cPVPhYpiW0zwhzvBIQQCMhRuhXQmv0odGXwQS7al0oY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=X3jkUH4I9mCii0glpBZl0O6xui4UwOjKLSLu0ZvH5qA2iW8zXbpAjYHopZETOYh0kckrNjDq1o9jrl6aut8ztXRXbCM4S7oEHfSBqMOeHNqRDfiPbxIHADXgc8N9Ao5JKw57TMPPMz7LQ6oKaBrLRts8LALNAn+DNk2IfBz7B4I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net; spf=pass smtp.mailfrom=minyard.net; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b=G1PFu61R; arc=none smtp.client-ip=209.85.210.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=minyard.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=minyard.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=minyard.net header.i=@minyard.net header.b="G1PFu61R" Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-7e5c85b47c6so528056a34.0 for ; Tue, 19 May 2026 10:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=minyard.net; s=google; t=1779212062; x=1779816862; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=GrsphKIpYvzqaOYROTJU7Wmg2e+Vy1DQyFLWqkwAMt4=; b=G1PFu61RSSAY6JQ69SA3QYLiKujnjdSNxKvk7EPOnwGRtKSJyazAzRRnjTLC9c1Ibd 4MmVgK/g9HBf2S5jK4EL4MoDxQEL3H0R2k5FWzZ6Ixwd5AUIHs6b75jSBRFUHUnSlJqm lue2BjCi2BNMTSFIbWAC6BMqJllIZrqbbt2LfVJ86AhtWJmh4PLiiz9HJrO3heKfGn/H evlroNU+vLX1eJ0widWSUwBGmJYX1JkLI4QCZsJaMGMW73RyhpQuuvdCEroj0SFrzlj3 iY+Sx3c2H3jGXEN9Tgm/OVX4BqBqKcgub1yy2QmhAcqNH8BeWqw+OAfGvPGUlfePrsPW 45gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779212062; x=1779816862; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:reply-to:message-id:subject:cc:to:from:date :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GrsphKIpYvzqaOYROTJU7Wmg2e+Vy1DQyFLWqkwAMt4=; b=XsyAalHtGyVVf/5uRrreeA1CMGPXESakduif5pKCX0xK2L8TlqhC+sSoFjeoMXu++6 FIaboqIfiww66I95QQoFgoKiXnL35bzg0bLGH4cr/OpeTVyyt2XFqmnsYBOakBPZrzln iEJztQRsXeAesr3vPp80VdlQg3dsMTa52fir2AdQWcz4SM6eebmHOWuqF9RcnIRfK+IU s6P6FLQDDWrRnFfC6dSXBMjIJoYdZjA6G3nOAJxpVAq/Yj8gVqYcgkywD8YFuPO8mNNC 7BuZJDqf48SZGZlr8+xaItKTY0Ihx6BhI8C7DqIye3NInxtFIxJbz8qYVAWRKfOR4L83 S8wQ== X-Forwarded-Encrypted: i=1; AFNElJ/lOLswJ4iQ6IvAE4RJDHKmv0Gv1nRcwJj+O/QMpktPKtt8rk/fJCQ6opnNLArzV8qx2xd3yCYYXOXeaWw=@vger.kernel.org X-Gm-Message-State: AOJu0YyZ6MpdeEXQ4SPeUXhZI28nZlQKEO/RZSNuCzMLaL4Soc5P5jC3 3TrCcZ6EVs9jtfo34W69jffWQQFfLsnJCV7vYj54UWSbVNmJoI+lARZGzZfModHXKYA= X-Gm-Gg: Acq92OHE09KBeNiZpLkMrqBTs+NfizUoj4oAZKdgkbnmurLbTKFsyl10TsS4+2osweb 3sz7Z6WD/z//v+m/kMf1guS0ncJgfd0HkrdxQW7j3G7En1a2pvl5djWyfCv2M4aiZV5m9azOs/R cIlLVfoSQ/42V9P5hyPcnkGLBUCQNOoZgcrv69jK2w6sOV6k9aDbn+wndlq44V8Jh3wqcidrKIr jkkixy7AK3ajvy0mRkRe+szM84jtfTOCTo4bz+mfBIC7QaUzOVZPYF3/z1SFTd4XL8Y/QWHmJtb K+fFNBdJnE+Xu6+gIpypXXVUFcHDspNMtWJOVbl3P4OadXrFgpU7LHA9CszJ7meWVJ0FA6gejSs sh9xNAMZzV5SSPNQHg9aqNZ54J7jgfxWlzhBNoy8oOkAugXllVv18YW39iPRKTTRdJZCFn5LTKr LYYV3XhYoW+UQzKTzwjJM859MWFBdKN5Mg9gP2AWyCUY1dB0L/x4HY7YwDBW0s6zrOAGNiilFyS AB6B96NAQ0LJg== X-Received: by 2002:a05:6830:d17:b0:7dc:db04:d316 with SMTP id 46e09a7af769-7e4ea07bd39mr14102238a34.8.1779212061954; Tue, 19 May 2026 10:34:21 -0700 (PDT) Received: from mail.minyard.net ([2001:470:b8f6:1b:aa2:381f:151a:2c86]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-7e55bbd08ccsm10103841a34.17.2026.05.19.10.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2026 10:34:21 -0700 (PDT) Date: Tue, 19 May 2026 12:34:18 -0500 From: Corey Minyard To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig_=28The_Capable_Hub=29?= Cc: openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1] ipmi: Use named initializers for struct i2c_device_id Message-ID: Reply-To: corey@minyard.net References: <20260519150156.1590826-2-u.kleine-koenig@baylibre.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260519150156.1590826-2-u.kleine-koenig@baylibre.com> On Tue, May 19, 2026 at 05:01:56PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > While being less compact, using named initializers allows to more easily > see which members of the structs are assigned which value without having > to lookup the declaration of the struct. And it's also more robust > against changes to the struct definition. > > This patch doesn't modify the compiled arrays, only their representation > in source form benefits. The former was confirmed with x86 and arm64 > builds. > > While touching these arrays, unify usage of whitespace in the list > terminator. > > Signed-off-by: Uwe Kleine-König (The Capable Hub) > --- > Hello, > > this patch is part of a bigger quest to use named initializers for > mainly struct i2c_device_id::driver_data to be able to modify > i2c_device_id. See e.g. > https://lore.kernel.org/all/20260518111203.639603-2-u.kleine-koenig@baylibre.com/ > for the details. > > This patch here isn't critical for this quest, as no driver makes use of > .driver_data, so apart from the better readability this is only about > consistency with other subsystems. Yes, this doesn't seem so critical, but it's an improvement. This is in my queue for next release. Thanks, -corey > > Best regards > Uwe > > drivers/char/ipmi/ipmb_dev_int.c | 4 ++-- > drivers/char/ipmi/ipmi_ipmb.c | 4 ++-- > drivers/char/ipmi/ipmi_ssif.c | 2 +- > drivers/char/ipmi/ssif_bmc.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/char/ipmi/ipmb_dev_int.c b/drivers/char/ipmi/ipmb_dev_int.c > index 2fe1d205ce4e..680ff15c30ab 100644 > --- a/drivers/char/ipmi/ipmb_dev_int.c > +++ b/drivers/char/ipmi/ipmb_dev_int.c > @@ -353,8 +353,8 @@ static void ipmb_remove(struct i2c_client *client) > } > > static const struct i2c_device_id ipmb_id[] = { > - { "ipmb-dev" }, > - {} > + { .name = "ipmb-dev" }, > + { } > }; > MODULE_DEVICE_TABLE(i2c, ipmb_id); > > diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c > index 28818952a7a4..1f1e5718f082 100644 > --- a/drivers/char/ipmi/ipmi_ipmb.c > +++ b/drivers/char/ipmi/ipmi_ipmb.c > @@ -566,8 +566,8 @@ MODULE_DEVICE_TABLE(of, of_ipmi_ipmb_match); > #endif > > static const struct i2c_device_id ipmi_ipmb_id[] = { > - { DEVICE_NAME }, > - {} > + { .name = DEVICE_NAME }, > + { } > }; > MODULE_DEVICE_TABLE(i2c, ipmi_ipmb_id); > > diff --git a/drivers/char/ipmi/ipmi_ssif.c b/drivers/char/ipmi/ipmi_ssif.c > index b49500a1bd36..32460c3858f4 100644 > --- a/drivers/char/ipmi/ipmi_ssif.c > +++ b/drivers/char/ipmi/ipmi_ssif.c > @@ -2074,7 +2074,7 @@ static int dmi_ipmi_probe(struct platform_device *pdev) > #endif > > static const struct i2c_device_id ssif_id[] = { > - { DEVICE_NAME }, > + { .name = DEVICE_NAME }, > { } > }; > MODULE_DEVICE_TABLE(i2c, ssif_id); > diff --git a/drivers/char/ipmi/ssif_bmc.c b/drivers/char/ipmi/ssif_bmc.c > index 1df0e9284ad9..6036897725f3 100644 > --- a/drivers/char/ipmi/ssif_bmc.c > +++ b/drivers/char/ipmi/ssif_bmc.c > @@ -874,7 +874,7 @@ static const struct of_device_id ssif_bmc_match[] = { > MODULE_DEVICE_TABLE(of, ssif_bmc_match); > > static const struct i2c_device_id ssif_bmc_id[] = { > - { DEVICE_NAME }, > + { .name = DEVICE_NAME }, > { } > }; > MODULE_DEVICE_TABLE(i2c, ssif_bmc_id); > > base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731 > -- > 2.47.3 >