From: Thinh Nguyen <Thinh.Nguyen@synopsys.com>
To: "Pandey, Radhey Shyam" <radheys@amd.com>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Radhey Shyam Pandey <radhey.shyam.pandey@amd.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"michal.simek@amd.com" <michal.simek@amd.com>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"git@amd.com" <git@amd.com>
Subject: Re: [PATCH 2/3] usb: dwc3: xilinx: use reset_control_reset() in versal init
Date: Tue, 19 May 2026 22:39:25 +0000 [thread overview]
Message-ID: <agzmZOrMiqMxj3bz@vbox> (raw)
In-Reply-To: <95361d3a-34b6-4f0f-935e-9e1b45698e81@amd.com>
On Mon, May 18, 2026, Pandey, Radhey Shyam wrote:
> On 5/14/2026 7:04 AM, Thinh Nguyen wrote:
> > On Mon, May 11, 2026, Radhey Shyam Pandey wrote:
> > > Replace separate reset_control_assert() and reset_control_deassert() calls
> > > with reset_control_reset(), which pulses the reset in one step. Report
> > > failures with dev_err_probe() and a single message. No functional change.
> > >
> >
> > The behavior of reset_control_reset() is a little different. I wouldn't
> > call this "No functional change". However, I assumed this was tested.
> > Please provide a proper reason for this change in the change log.
>
> In the dwc3-xilinx case, reset_control_reset() routes through the
> zynqmp reset driver and invokes PM_RESET_ACTION_PULSE. This triggers
> the Xilinx firmware reset implementation, which performs both assert
> and deassert. Effectively, reset() issues a single SMC call for a
> reset pulse instead of separate assert and deassert calls and moves
> IP out of reset.
>
> Yes this new reset sequence is validated on HW. I will include
> above description and respin v2..
>
Thanks!
Thinh
next prev parent reply other threads:[~2026-05-19 22:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 16:08 [PATCH 0/3] usb: dwc3: xilinx: minor fixes for dwc3-xilinx glue driver Radhey Shyam Pandey
2026-05-11 16:08 ` [PATCH 1/3] usb: dwc3: xilinx: fix missing space before closing comment delimiter Radhey Shyam Pandey
2026-05-14 1:23 ` Thinh Nguyen
2026-05-11 16:08 ` [PATCH 2/3] usb: dwc3: xilinx: use reset_control_reset() in versal init Radhey Shyam Pandey
2026-05-14 1:34 ` Thinh Nguyen
2026-05-18 14:28 ` Pandey, Radhey Shyam
2026-05-19 22:39 ` Thinh Nguyen [this message]
2026-05-11 16:08 ` [PATCH 3/3] usb: dwc3: xilinx: fix error handling in zynqmp init error paths Radhey Shyam Pandey
2026-05-14 1:43 ` Thinh Nguyen
2026-05-14 12:52 ` Pandey, Radhey Shyam
2026-05-16 0:04 ` Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agzmZOrMiqMxj3bz@vbox \
--to=thinh.nguyen@synopsys.com \
--cc=git@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=p.zabel@pengutronix.de \
--cc=radhey.shyam.pandey@amd.com \
--cc=radheys@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.