From: Oleg Nesterov <oleg@redhat.com>
To: "David Hildenbrand (Arm)" <david@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christian Brauner <brauner@kernel.org>,
Jann Horn <jannh@google.com>, Kees Cook <kees@kernel.org>,
Lorenzo Stoakes <ljs@kernel.org>, Michal Hocko <mhocko@suse.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2] mm_access: simplify the security checks
Date: Mon, 1 Jun 2026 14:31:49 +0200 [thread overview]
Message-ID: <ah17tTbarD2dKVWE@redhat.com> (raw)
In-Reply-To: <a8846033-094d-4e1c-bfba-f7f543944709@kernel.org>
On 06/01, David Hildenbrand (Arm) wrote:
>
> On 5/30/26 16:12, Oleg Nesterov wrote:
>
> I am not sure I spot the "simplification" here?
Ah, then lets forget this patch ;)
Cleanups are always subjective, if maintainer doesn't agree - forget it.
> Looks more like an optimization that makes the code slightly more complicated.
I don't think that !task->mm or current->mm == task->mm is the common case.
Just the code looks more clear to me if it takes exec_update_lock only when
necessary.
But see above, please forget.
Oleg.
next prev parent reply other threads:[~2026-06-01 12:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 13:56 [PATCH] mm_access: simplify the security checks Oleg Nesterov
2026-05-30 14:10 ` Oleg Nesterov
2026-06-01 11:16 ` Lorenzo Stoakes
2026-05-30 14:12 ` [PATCH v2] " Oleg Nesterov
2026-06-01 12:04 ` David Hildenbrand (Arm)
2026-06-01 12:31 ` Oleg Nesterov [this message]
2026-06-01 12:12 ` Lorenzo Stoakes
2026-06-01 12:42 ` Oleg Nesterov
2026-05-30 15:00 ` [PATCH] " Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah17tTbarD2dKVWE@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=brauner@kernel.org \
--cc=david@kernel.org \
--cc=jannh@google.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ljs@kernel.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.