From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 47C88385D89 for ; Mon, 1 Jun 2026 08:55:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304105; cv=none; b=czhsA9T5TIqBjq40FT9aBPtuWSXOa+kiaVwYbogmCcQyGJKV65zNdmqwdMIV7NffGRe/pO2iybiwwVPeoNBBc3YaTqwBFj3QWziWVxJxaioh2juz4jzXoZWw0Xr7oKgxsxVuKO1dxbbxzDPAsTbOXzls6xFwoVTjmj22KpaOYHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780304105; c=relaxed/simple; bh=DQxj9nXA3C2tNJ58TG5/dDKkulKfoMUMWL7MqrDAOUM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=te8Ng2xdsVEmgjaj6iXNllvvT8bYBg563VPhGsb2IJjqM1TsLLID+CaD1Bq6/hT+pE8w0sZpMFos+cVpto+LXgSaC0FCe3DZt9l+cs1YpdvGFe85ot9chTzpKdgIT5+yrHIF8YJJhdkD4LVW+39xKmdUnY3dIdUHOzd5Yciu8RI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=J9ThDFUX; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="J9ThDFUX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 495751F00893; Mon, 1 Jun 2026 08:55:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780304103; bh=rJSMpk9HoXFtAyVKQEPd/j/LZtGmra81xUby14aTssE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=J9ThDFUXTZvMVfDGZD7cVi4fk6awr1W/B1+llsneH8o8QSWQeeEH2/rJzbwXvYEEz 2HwyF4NbfepBEdKNDuRTELNFg6/acVdg6R5yAVTMhmy03OS4jC9QaG+7EKlO5TYeYd 3NiG7LjFGXwRlEP1XGlng1Mz99TrglE8ma5xQE9C/LbYjZZcD3UNgp2Dk9/kEwYd2Y kfvR1bCI7JCpjjbeZqK/qiOWKylN8VX1HjM/HxaOcsLnf5ifgjppsLfzgQrcXY7B38 0w5x5voyYTOBiv+7TWzRW1jXbDHOSEGkshSlZfBDqqt6M6WO839xv1hs1y0iCYKW5t N9AwlJdCkY/oA== Date: Mon, 1 Jun 2026 09:55:01 +0100 From: Lorenzo Stoakes To: Andrew Morton Cc: David Hildenbrand , Zi Yan , Baolin Wang , "Liam R . Howlett" , Nico Pache , Ryan Roberts , Dev Jain , Barry Song , Lance Yang , SeongJae Park , Balbir Singh , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-hotfixes] mm/huge_memory: use correct flags for device private PMD entry Message-ID: References: <20260601083044.57132-1-ljs@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260601083044.57132-1-ljs@kernel.org> On Mon, Jun 01, 2026 at 09:30:44AM +0100, Lorenzo Stoakes wrote: > mm/huge_memory.c | 45 +++++++++++++++++++++++++++++++++------------ > 1 file changed, 33 insertions(+), 12 deletions(-) > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index bf9b480bb3b0..79463c709c98 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -4982,7 +4982,7 @@ int set_pmd_migration_entry(struct page_vma_mapped_walk *pvmw, > struct vm_area_struct *vma = pvmw->vma; > struct mm_struct *mm = vma->vm_mm; > unsigned long address = pvmw->address; > - bool anon_exclusive; > + bool anon_exclusive, present, writable, softdirty, uffd_wp; > pmd_t pmdval; > swp_entry_t entry; > pmd_t pmdswp; > @@ -4990,12 +4990,26 @@ int set_pmd_migration_entry(struct page_vma_mapped_walk *pvmw, > if (!(pvmw->pmd && !pvmw->pte)) > return 0; > > - flush_cache_range(vma, address, address + HPAGE_PMD_SIZE); > - if (unlikely(!pmd_present(*pvmw->pmd))) > - pmdval = pmdp_huge_get_and_clear(vma->vm_mm, address, pvmw->pmd); > - else > + present = pmd_present(*pvmw->pmd); > + if (likely(present)) { > + flush_cache_range(vma, address, address + HPAGE_PMD_SIZE); Oh I forgot to mention in the commit message that I moved flush_cache_range() into the present branch, as it's not meaningful for a softleaf (i.e. non-present) entry. Cheers, Lorenzo