From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 19D8833BBCC for ; Tue, 2 Jun 2026 04:19:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780373946; cv=none; b=r2aNcv/ePTlq4vbTeLYUXjhCzM1mfFBrX5jthcAB0MiuOGW4CVDWUuaVUCv1zCE7IDYJV4pKVaRPSibv26Fj55ZO/heL+eIw683NRnT+SBqTQgy8REht6U3QEuQb7qTfsobZ5z5tZLvfHYVaZ0vL34rOeH3P6CZfrwwoloSmF8Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780373946; c=relaxed/simple; bh=D2tkcdqQevHKnm7iyZrvFSN0FryfucMDfN1jJHoaB2Y=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=G8Zl/rSv5jf6aYWbZQb/8Bg39qchQbeWicOWowOvHIN1hSlmMSTw95z51rpMA71w7g3GDD5bq/TEM5ZxjOj19KMBz1esDAqnuZzpsMnExBTVrkb6mTYb2D1YO2kwpb71suskYYNEbcwx+kgveT0oyFylTPRInal7pK4wakDDg6o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com; spf=pass smtp.mailfrom=suse.com; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b=KRF+AENp; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=suse.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=suse.com header.i=@suse.com header.b="KRF+AENp" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-45ef14d4200so509441f8f.2 for ; Mon, 01 Jun 2026 21:19:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1780373943; x=1780978743; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=GQIJYgqXVDOV+QlU5wqTYbdRma5//XsEXiIIBLD54Ts=; b=KRF+AENp2zXUCKbE8YEai41TumPAskoRLeMXxKlv1CDLyjJWxnn3mJwHlnvSkbLUUD GUTWo4LShNgiS6N5NCVZoaiSJaFF7VI4xGliZLmo1m4bW98T47AcMDQJEHpsezEajLmq lXwfL3rjd19EZSoX2jbeB2WEayNUYMSmH+Cc9KFO6+oq1PAAqPyILSlwSOKVSyjo45P7 qidGAD3j0dZJXJHh6l0Jzy52pKip/Rs19nsEkwxu+aLAS00MYuFD9k0qGUMzVoeGjTt1 2VAUeT/OrQQHMpwBneiE4XRG6lurYJSVkGjtgaLtXZDWnW4/z6BKpOZQeKP8crd7VfRk DWbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780373943; x=1780978743; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GQIJYgqXVDOV+QlU5wqTYbdRma5//XsEXiIIBLD54Ts=; b=cxeTJ1oRIHpu09aKU+7D+9WmREXoHjrAtqwChCibq5x6TKAfKWS6PTmJaCUwDPuQKk YcOX0XIYNIO4T+iViIkuh6lBJUS3AB+o2zSJFGjIK14bU6PVjZAPibbBvSaaRX2+B9Lz lC3EgyHhDC2rChaVtk1FTe1olGFMNiBfr6OHpffBo+5jHSh4sx1IGbeu6ZS+x/ljhclC mnaghlTG3euq//2HsZRHNMioBZppf4EUMgxa3WSyCEl6sW3jXspxlm41xmCCoSubep2v bBOUVyHJv1mawA3SYfrJUVo5i1uIzAuhT5miJTlCLA3xpiSy1vexYVr09Zyb6oKc1J4D SRhA== X-Forwarded-Encrypted: i=1; AFNElJ+9rRkSEP9+nnMmph2oqD6ksoHJQAN5sQrzc4YNc9ah7zEkSRVU7hxOup0Q+x2mS6TZRWUbX/d1drz+q5o=@vger.kernel.org X-Gm-Message-State: AOJu0YzoO/0p+v8eXBf/maLKBS78OFaJ96YXHswAve39OlPiOjahn9y5 wUzNHAGY6us+ymehgPCwXdCQaZK4J2sCiO1yf79Y3ng/OlcnZEWHupQIFxebou6al3k= X-Gm-Gg: Acq92OHgPK4sv1p6/L5twcffgP5CRqNJi5L1KYvAjeFhKVgcnYraVhMUk0Ta8+MuvQK fPMse3eESz5zsWi68AW9w5ScLQ8go4QGJDmEeW0mf6GOtfBl2DOmP57RND3QXo2s0hGvUmXklxs pE/2Yn/TKIoE0eBy5ecq1qT+v2UH0xGoDteVo2v4DEHmEKUvozlUofhdt0bfk3iqSUoUsjxpR5n sSl49tpD/7oVWpTlqptbkBwAnrgNFhWgwwCLuwe7EGbMgvgfCLWWi5NSFHcqYtL8Hv0yFBWUlC+ GmDmWmZE+VEZxZ9OgXdbKwmt6Zo+3CadomOv+26JFmC6RRann1SI22hB/y0O5kSryxMVFQd/hC3 TKLjbUhXJkQJMp54ugGePJPjtRMgTHXFQYuEd8SOgxtqEDuGyUb1A4AfHLMYzX16tfkqUQIWLbz oSgXUDKEI8MMJ+QuXyeO8Plm1ff3g3bU0I X-Received: by 2002:a05:600c:3f1b:b0:490:4175:4bf4 with SMTP id 5b1f17b1804b1-490a2997abfmr129013035e9.8.1780373943479; Mon, 01 Jun 2026 21:19:03 -0700 (PDT) Received: from localhost ([202.127.77.110]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-36dd91aec9csm1166430a91.6.2026.06.01.21.19.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 Jun 2026 21:19:02 -0700 (PDT) Date: Tue, 2 Jun 2026 12:18:59 +0800 From: Heming Zhao To: Joseph Qi Cc: Andrew Morton , Ginger , ocfs2-devel@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ocfs2: fix race between ocfs2_control_install_private() and ocfs2_control_release() Message-ID: References: <20260601121618.1263346-1-joseph.qi@linux.alibaba.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260601121618.1263346-1-joseph.qi@linux.alibaba.com> On Mon, Jun 01, 2026 at 08:16:18PM +0800, Joseph Qi wrote: > Move atomic_inc(&ocfs2_control_opened) and the handshake state update > inside ocfs2_control_lock to close a race window where > ocfs2_control_release() can observe ocfs2_control_opened dropping to > zero (resetting ocfs2_control_this_node and running_proto) while > ocfs2_control_install_private() is about to bump the counter and mark > the connection valid. > > Fixes: 3cfd4ab6b6b4 ("ocfs2: Add the local node id to the handshake.") > Reported-by: Ginger The code looks good to me, but above email address is not valid. The correct should be: - Heming > Signed-off-by: Joseph Qi > --- > fs/ocfs2/stack_user.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/fs/ocfs2/stack_user.c b/fs/ocfs2/stack_user.c > index 5803f1dee679..91e19d33847c 100644 > --- a/fs/ocfs2/stack_user.c > +++ b/fs/ocfs2/stack_user.c > @@ -327,18 +327,14 @@ static int ocfs2_control_install_private(struct file *file) > ocfs2_control_this_node = p->op_this_node; > running_proto.pv_major = p->op_proto.pv_major; > running_proto.pv_minor = p->op_proto.pv_minor; > - } > - > -out_unlock: > - mutex_unlock(&ocfs2_control_lock); > - > - if (!rc && set_p) { > - /* We set the global values successfully */ > atomic_inc(&ocfs2_control_opened); > ocfs2_control_set_handshake_state(file, > OCFS2_CONTROL_HANDSHAKE_VALID); > } > > +out_unlock: > + mutex_unlock(&ocfs2_control_lock); > + > return rc; > } > > -- > 2.39.3 >