From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-renesas-soc@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] arm64: renesas: r8a779g0: add MFIS node
Date: Tue, 2 Jun 2026 13:02:59 +0200 [thread overview]
Message-ID: <ah64Y3fuO2ofgsDG@ninjato> (raw)
In-Reply-To: <CAMuHMdX8gGvjTPat-7=r3q-bXgQJU=A2DsDEPXZy6k20_JKx9w@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 764 bytes --]
Hi Geert,
thanks for the review!
> > + mfis: system-controller@e6260000 {
> > + compatible = "renesas,r8a779g0-mfis";
> > + reg = <0 0xe6260000 0 0xf000>;
>
> Why 0xf000 and not 0x10000?
The sheet listing the memory map has a "MFI - Region 14" entry for
0xe626e000, but no region 15 for 0xe626f000. I thought I play safe.
Can change if you want...
> > + interrupt-names = "ch0e", "ch1e", "ch2e", "ch3e", "ch4e", "ch5e", "ch6e", "ch7e", "ch8e", "ch9e",
>
> This is way too longer for a single line, and the double spacing
> doesn't really help (yeah, it does align ch1e and ch11e...).
You are right, will fix this.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-06-02 11:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 8:02 [PATCH v2] arm64: renesas: r8a779g0: add MFIS node Wolfram Sang
2026-06-02 10:45 ` Geert Uytterhoeven
2026-06-02 11:02 ` Wolfram Sang [this message]
2026-06-02 12:25 ` Geert Uytterhoeven
2026-06-02 15:29 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah64Y3fuO2ofgsDG@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.