From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-185.mta0.migadu.com (out-185.mta0.migadu.com [91.218.175.185]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5B22D30FC1B for ; Tue, 2 Jun 2026 20:51:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.185 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780433475; cv=none; b=qt++X5alseuDyU8ms74rDWwoVvUzF2+RgvxHEgFxdPct85QlXoq5huAKVDqXx48cAOswZZSi65md91z8ZUEYE2fB7EKCWMBwcRkAHI7lySccEQnc5L0xCoEwR/jI9Vsc1OhCLNQtH9eM8uQKaMwSoyLX9fqOnf1iZb4iJ2fzuP4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780433475; c=relaxed/simple; bh=791aivTs4EgvrFxer55SyQA3Adu38ewQOtHjDh7Oh0o=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=bDrEnnzFoy1hn0i4XBQOgYNAhdcWrr13gCj7LCACJHXvlZ+Jsdsv3duIvjdmgA61YwQWdrossGOuVe69x8eZ3F7zRmOJ5TZBEqMq1XvCtikZ16pfGjdNKRjh6hk46C76QiKXQue/aDVhHbh4LDZ/4SbQhw+IFGlXtBqkxC5+j7Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=LwHmyJRg; arc=none smtp.client-ip=91.218.175.185 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="LwHmyJRg" Date: Tue, 2 Jun 2026 22:50:57 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1780433461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SrVoGOGyRLrxoTmnEzU+D1XUI6722cewBkysfTUfUQU=; b=LwHmyJRg2D4DbfAXN5HL1LwNueKg+Qy1wB5hHi2fFHPS5p8Z58/mSZS+vqoJduffyV/M4I 2d8wPvWk6jVikqkKK/eh0c7Rjx4OKaAZgaeEl2ObZNX72wg/7NwqUV1Wcw9XAuRNnqExQO G44xe+b5+vBDjmEUnbtI7ZBYDlTqT9Y= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Tom Lendacky Cc: Herbert Xu , "David S. Miller" , John Allen , Weili Qian , Zhou Wang , Giovanni Cabiddu , Srujana Challa , Bharat Bhushan , linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, qat-linux@intel.com Subject: Re: [PATCH] crypto: use two-argument strscpy where destination size is known Message-ID: References: <20260525103038.825690-4-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Migadu-Flow: FLOW_OUT Hi Tom, On Tue, Jun 02, 2026 at 03:24:06PM -0500, Tom Lendacky wrote: > On 5/25/26 05:30, Thorsten Blum wrote: > > To simplify the code, drop explicit and hard-coded size arguments from > > strscpy() where the destination buffer has a fixed size and strscpy() > > can automatically determine it using sizeof(). > > > > Signed-off-by: Thorsten Blum > > For the CCP driver changes: > > Reviewed-by: Tom Lendacky Thanks. > But I noticed that there are a few other places in the driver that I think > can be changed to use the two argument strscpy - essentially the strscpy's > that involve "cra_name" and "cra_driver_name" in > drivers/crypto/ccp/{ccp-crypto-aes-galois.c,ccp-crypto-aes-xts.c,ccp-crypto-aes.c,ccp-crypto-des3.c,ccp-crypto-rsa.c,ccp-crypto-sha.c}. They already use the 2-arg strscpy(), except for the one in this patch: $ git grep -n strscpy drivers/crypto/ccp/ drivers/crypto/ccp/ccp-crypto-aes-galois.c:227: strscpy(alg->base.cra_name, def->name); drivers/crypto/ccp/ccp-crypto-aes-galois.c:228: strscpy(alg->base.cra_driver_name, def->driver_name); drivers/crypto/ccp/ccp-crypto-aes-xts.c:243: strscpy(alg->base.cra_name, def->name); drivers/crypto/ccp/ccp-crypto-aes-xts.c:244: strscpy(alg->base.cra_driver_name, def->drv_name); drivers/crypto/ccp/ccp-crypto-aes.c:311: strscpy(alg->base.cra_name, def->name); drivers/crypto/ccp/ccp-crypto-aes.c:312: strscpy(alg->base.cra_driver_name, def->driver_name); drivers/crypto/ccp/ccp-crypto-des3.c:196: strscpy(alg->base.cra_name, def->name); drivers/crypto/ccp/ccp-crypto-des3.c:197: strscpy(alg->base.cra_driver_name, def->driver_name); drivers/crypto/ccp/ccp-crypto-rsa.c:261: strscpy(alg->base.cra_name, def->name); drivers/crypto/ccp/ccp-crypto-rsa.c:262: strscpy(alg->base.cra_driver_name, def->driver_name); drivers/crypto/ccp/ccp-crypto-sha.c:429: strscpy(ccp_alg->child_alg, def->name, CRYPTO_MAX_ALG_NAME); drivers/crypto/ccp/ccp-crypto-sha.c:487: strscpy(base->cra_name, def->name); drivers/crypto/ccp/ccp-crypto-sha.c:488: strscpy(base->cra_driver_name, def->drv_name);