From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Jacob Moroni <jmoroni@google.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
Tatyana Nikolova <tatyana.e.nikolova@intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>, Leon Romanovsky <leon@kernel.org>
Subject: Re: [PATCH] RDMA/irdma: Fix typo in SQ completions generation
Date: Wed, 3 Jun 2026 00:57:27 +0300 [thread overview]
Message-ID: <ah9Rx25KxG38I-Tg@grain> (raw)
In-Reply-To: <CAHYDg1QH=tMy8xbYn4D-L9iyp9iCVCEU190H9_gFLTWMABqhpw@mail.gmail.com>
On Tue, Jun 02, 2026 at 10:11:46AM -0400, Jacob Moroni wrote:
> BTW, your fix matches the OOT driver code:
> https://github.com/intel/ethernet-linux-irdma-and-idpf/blob/main/rdma-driver/src/irdma/utils.c#L3561
>
Wow, didn't know about OOT driver :-) Thanks for pointing!
> Regarding the "unrelated issue" - is it an irdma issue? Anything we
> can help with?
Well, the issue I'm dealing with is messy yet (i mean i'm not sure if it
is irdma issue or not -- i'm loosing completions on posted operations when
hardware in reset mode and same time the card is physically removed). Look,
once I manage to collect all pieces of a problem I'll back with report ) At
moment I suspect that we need to *flush* queue here instead of cancelling it
---
static int irdma_destroy_qp(struct ib_qp *ibqp, struct ib_udata *udata)
{
struct irdma_qp *iwqp = to_iwqp(ibqp);
struct irdma_device *iwdev = iwqp->iwdev;
iwqp->sc_qp.qp_uk.destroy_pending = true;
if (iwqp->iwarp_state == IRDMA_QP_STATE_RTS)
irdma_modify_qp_to_err(&iwqp->sc_qp);
if (!iwqp->user_mode)
--> cancel_delayed_work_sync(&iwqp->dwork_flush);
next prev parent reply other threads:[~2026-06-02 21:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-28 22:30 [PATCH] RDMA/irdma: Fix typo in SQ completions generation Cyrill Gorcunov
2026-05-29 3:23 ` Jacob Moroni
2026-05-30 13:34 ` Cyrill Gorcunov
2026-06-02 14:11 ` Jacob Moroni
2026-06-02 18:25 ` Jason Gunthorpe
2026-06-02 22:03 ` Cyrill Gorcunov
2026-06-02 22:31 ` Jacob Moroni
2026-06-02 21:57 ` Cyrill Gorcunov [this message]
2026-06-03 18:16 ` Jason Gunthorpe
2026-06-04 10:28 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah9Rx25KxG38I-Tg@grain \
--to=gorcunov@gmail.com \
--cc=jgg@ziepe.ca \
--cc=jmoroni@google.com \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=tatyana.e.nikolova@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.