All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <briannorris@chromium.org>
To: Radu Rendec <rrendec@redhat.com>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
	"Manivannan Sadhasivam" <mani@kernel.org>,
	"Daniel Tsai" <danielsftsai@google.com>,
	"Marek Behún" <kabel@kernel.org>,
	"Krishna Chaitanya Chundru" <quic_krichai@quicinc.com>,
	"Bjorn Helgaas" <bhelgaas@google.com>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
	"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
	"Jingoo Han" <jingoohan1@gmail.com>,
	"Brian Masney" <bmasney@redhat.com>,
	"Eric Chanudet" <echanude@redhat.com>,
	"Alessandro Carminati" <acarmina@redhat.com>,
	"Jared Kangas" <jkangas@redhat.com>,
	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 3/3] PCI: dwc: Enable MSI affinity support
Date: Fri, 22 May 2026 13:27:43 -0700	[thread overview]
Message-ID: <ahC8Pyuatu_AvnZp@google.com> (raw)
In-Reply-To: <20251128212055.1409093-4-rrendec@redhat.com>

Hi Radu,

On Fri, Nov 28, 2025 at 04:20:55PM -0500, Radu Rendec wrote:
> Leverage the interrupt redirection infrastructure to enable CPU affinity
> support for MSI interrupts. Since the parent interrupt affinity cannot
> be changed, affinity control for the child interrupt (MSI) is achieved
> by redirecting the handler to run in IRQ work context on the target CPU.
> 
> This patch was originally prepared by Thomas Gleixner (see Link tag
> below) in a patch series that was never submitted as is, and only
> parts of that series have made it upstream so far.
> 
> Originally-by: Thomas Gleixner <tglx@linutronix.de>
> Link: https://lore.kernel.org/linux-pci/878qpg4o4t.ffs@tglx/
> Signed-off-by: Radu Rendec <rrendec@redhat.com>

I've been trying to bisect a suspend/resume regression on a Qualcomm
SC7280 laptop (using arch/arm64/boot/dts/qcom/sc7280-herobrine-crd.dts),
and unfortunately, it bisects to this:

eaf290c404f7c39f23292e9ce83b8b5b51ab598a is the first bad commit
commit eaf290c404f7c39f23292e9ce83b8b5b51ab598a
Author: Radu Rendec <rrendec@redhat.com>
Date:   Fri Nov 28 16:20:55 2025 -0500

    PCI: dwc: Enable MSI affinity support

See the failure below [1]. Unfortunately, the logs don't give me an
immediate lead.

It fails similarly on v7.1-r1 and v7.1-rc4, so even though I know there
were a few bugfixes to the IRQ-redirect stuff already, I don't think
they help my case.

I'll see if I can learn anything more here on my own, but I figured I'd
report it in case you have any thoughts or leads I should investigate.

Regards,
Brian

[1]

[   58.229764] Enabling non-boot CPUs ...
[   58.234065] Detected VIPT I-cache on CPU1
[   58.234121] GICv3: CPU1: found redistributor 100 region 0:0x0000000017a80000
[   58.234171] CPU1: Booted secondary processor 0x0000000100 [0x412fd050]
[   58.235038] CPU1 is up
[   58.255764] Detected VIPT I-cache on CPU2
[   58.255801] GICv3: CPU2: found redistributor 200 region 0:0x0000000017aa0000
[   58.255837] CPU2: Booted secondary processor 0x0000000200 [0x412fd050]
[   58.256394] CPU2 is up
[   58.277119] Detected VIPT I-cache on CPU3
[   58.277155] GICv3: CPU3: found redistributor 300 region 0:0x0000000017ac0000
[   58.277191] CPU3: Booted secondary processor 0x0000000300 [0x412fd050]
[   58.277824] CPU3 is up
[   58.299086] Detected PIPT I-cache on CPU4
[   58.299104] GICv3: CPU4: found redistributor 400 region 0:0x0000000017ae0000
[   58.299124] CPU4: Booted secondary processor 0x0000000400 [0x411fd411]
[   58.299437] CPU4 is up
[   58.320186] Detected PIPT I-cache on CPU5
[   58.320205] GICv3: CPU5: found redistributor 500 region 0:0x0000000017b00000
[   58.320224] CPU5: Booted secondary processor 0x0000000500 [0x411fd411]
[   58.320513] CPU5 is up
[   58.341154] Detected PIPT I-cache on CPU6
[   58.341173] GICv3: CPU6: found redistributor 600 region 0:0x0000000017b20000
[   58.341193] CPU6: Booted secondary processor 0x0000000600 [0x411fd411]
[   58.341481] CPU6 is up
[   58.362167] Detected PIPT I-cache on CPU7
[   58.362186] GICv3: CPU7: found redistributor 700 region 0:0x0000000017b40000
[   58.362206] CPU7: Booted secondary processor 0x0000000700 [0x411fd411]
[   58.362532] CPU7 is up
[   58.384442] nvme 0001:01:00.0: Unable to change power state from unknown to D0, device inaccessible
[   59.243847] onboard-usb-dev 4-1: reset high-speed USB device number 2 using xhci-hcd
[   59.492243] onboard-usb-dev 5-1: reset SuperSpeed USB device number 2 using xhci-hcd
[   68.875606] nvme 0001:01:00.0: PM: **** DPM device timeout ****
[   68.881728] Call trace:
[   68.884266]  __switch_to+0x16c/0x188 (T)
[   68.888331]  __schedule+0x7c4/0x98c
[   68.891939]  schedule+0x38/0x60
[   68.895196]  schedule_timeout+0xf8/0x120
[   68.899254]  io_schedule_timeout+0x2c/0x4c
[   68.903481]  __wait_for_common+0xd4/0x168
[   68.907621]  wait_for_completion_io_timeout+0x28/0x34
[   68.912832]  blk_execute_rq+0x138/0x164
[   68.916792]  nvme_execute_rq+0x20/0x54
[   68.920665]  __nvme_submit_sync_cmd+0xe0/0x128
[   68.925258]  nvme_features.isra.0+0x88/0xd4
[   68.929580]  nvme_set_features+0x34/0x40
[   68.933638]  nvme_resume+0x68/0x88
[   68.937158]  pci_pm_resume+0x88/0xfc
[   68.940849]  dpm_run_callback+0x6c/0xec
[   68.944811]  device_resume+0x194/0x270
[   68.948683]  async_resume+0x28/0x3c
[   68.952289]  async_run_entry_fn+0x40/0x104
[   68.956515]  process_scheduled_works+0x210/0x320
[   68.961277]  worker_thread+0x14c/0x1ec
[   68.965147]  kthread+0x154/0x1b8
[   68.968486]  ret_from_fork+0x10/0x20
[   68.972192] Kernel panic - not syncing: nvme 0001:01:00.0: unrecoverable failure

  parent reply	other threads:[~2026-05-22 20:27 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-28 21:20 [PATCH v3 0/3] Enable MSI affinity support for dwc PCI Radu Rendec
2025-11-28 21:20 ` [PATCH v3 1/3] genirq: Add interrupt redirection infrastructure Radu Rendec
2025-12-15 21:34   ` [tip: irq/msi] " tip-bot2 for Radu Rendec
2025-11-28 21:20 ` [PATCH v3 2/3] PCI: dwc: Code cleanup Radu Rendec
2025-12-15 21:34   ` [tip: irq/msi] " tip-bot2 for Radu Rendec
2025-11-28 21:20 ` [PATCH v3 3/3] PCI: dwc: Enable MSI affinity support Radu Rendec
2025-12-15 21:34   ` [tip: irq/msi] " tip-bot2 for Radu Rendec
2026-01-06  9:53     ` Jon Hunter
2026-01-06 15:07       ` Radu Rendec
2026-01-07  1:13         ` Radu Rendec
2026-01-20 18:01   ` [PATCH v3 3/3] " Jon Hunter
2026-01-20 22:30     ` Radu Rendec
2026-01-21 14:00       ` Jon Hunter
2026-01-22 23:31         ` Radu Rendec
2026-01-23 13:25           ` Jon Hunter
2026-01-26  7:59           ` Thomas Gleixner
2026-01-26 22:07             ` Jon Hunter
2026-01-26 22:26               ` Radu Rendec
2026-01-27 10:30                 ` Thomas Gleixner
2026-01-27 13:34                   ` Thomas Gleixner
2026-01-27 17:09                     ` Jon Hunter
2026-01-27 21:30                       ` [PATCH] genirq/redirect: Prevent writing MSI message on affinity change Thomas Gleixner
2026-01-29 22:51                         ` [tip: irq/msi] " tip-bot2 for Thomas Gleixner
2026-03-26  3:48                       ` [PATCH v3 3/3] PCI: dwc: Enable MSI affinity support Tsai Sung-Fu
2026-03-26 12:52                         ` Thomas Gleixner
2026-05-22 20:27   ` Brian Norris [this message]
2026-05-23  0:07     ` Brian Norris
2026-05-25 16:48       ` Radu Rendec
2026-05-30  0:35         ` Brian Norris
2026-06-01  8:20           ` Niklas Cassel
2026-06-01 19:02             ` Brian Norris
2026-06-01 19:09               ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahC8Pyuatu_AvnZp@google.com \
    --to=briannorris@chromium.org \
    --cc=acarmina@redhat.com \
    --cc=bhelgaas@google.com \
    --cc=bmasney@redhat.com \
    --cc=danielsftsai@google.com \
    --cc=echanude@redhat.com \
    --cc=jingoohan1@gmail.com \
    --cc=jkangas@redhat.com \
    --cc=kabel@kernel.org \
    --cc=kwilczynski@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lpieralisi@kernel.org \
    --cc=mani@kernel.org \
    --cc=quic_krichai@quicinc.com \
    --cc=robh@kernel.org \
    --cc=rrendec@redhat.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.