All of lore.kernel.org
 help / color / mirror / Atom feed
From: Carlos Llamas <cmllamas@google.com>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>
Cc: mykyta.yatsenko5@gmail.com, Andrii Nakryiko <andrii@kernel.org>,
	Eduard Zingerman <eddyz87@gmail.com>,
	Alexei Starovoitov <ast@kernel.org>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Martin KaFai Lau <martin.lau@linux.dev>,
	Kumar Kartikeya Dwivedi <memxor@gmail.com>,
	Song Liu <song@kernel.org>,
	Yonghong Song <yonghong.song@linux.dev>,
	Jiri Olsa <jolsa@kernel.org>,
	kernel-team@android.com, linux-kernel@vger.kernel.org,
	Mykyta Yatsenko <yatsenko@meta.com>,
	"open list:BPF [GENERAL] (Safe Dynamic Programs and Tools)"
	<bpf@vger.kernel.org>
Subject: Re: [PATCH v3] libbpf: fix UAF in strset__add_str()
Date: Fri, 22 May 2026 18:50:06 +0000	[thread overview]
Message-ID: <ahClXrWcPgb4tEIe@google.com> (raw)
In-Reply-To: <CAEf4BzbX6DSD5Erd2wb2wE+=MFTfqgvVrpkysqrCKT0W7-n29g@mail.gmail.com>

On Fri, May 22, 2026 at 11:35:58AM -0700, Andrii Nakryiko wrote:
> >
> > sashiko suggests to use uintptr_t for this detection to avoid
> > undefined behavior, let's do that then)?
> >
> > but other than that and a nit below, looks good, thanks!
> >
> > pw-bot: cr
> 
> Ping. Carlos, are you planning to send a follow up?

Hey Andrii sorry about the delay I got caught up with something else
here. I'll send a new version in a bit with the uintptr_t casting and
your suggestion. I would just say that it is a bit unfortunate that
we'll have to clutter the code with this kind of parsing to avoid the
compiler behavior that was mentioned. :(

Thanks,
Carlos Llamas

  reply	other threads:[~2026-05-22 18:50 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13 23:20 [PATCH] libbpf: fix UAF in strset__add_str() Carlos Llamas
2026-05-13 23:55 ` bot+bpf-ci
2026-05-14  1:10   ` Carlos Llamas
2026-05-14 11:57 ` sashiko-bot
2026-05-14 13:38   ` Mykyta Yatsenko
2026-05-14 18:39     ` Carlos Llamas
2026-05-15  4:47     ` [PATCH v2] " Carlos Llamas
2026-05-15 22:08       ` Andrii Nakryiko
2026-05-18  4:59         ` Carlos Llamas
2026-05-18  5:05         ` [PATCH v3] " Carlos Llamas
2026-05-18  5:31           ` sashiko-bot
2026-05-18 17:36           ` Andrii Nakryiko
2026-05-22 18:35             ` Andrii Nakryiko
2026-05-22 18:50               ` Carlos Llamas [this message]
2026-05-23 16:27             ` [PATCH v4] " Carlos Llamas
2026-05-23 16:51               ` sashiko-bot
2026-05-23 17:05               ` bot+bpf-ci
2026-05-28 21:31               ` Andrii Nakryiko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahClXrWcPgb4tEIe@google.com \
    --to=cmllamas@google.com \
    --cc=andrii.nakryiko@gmail.com \
    --cc=andrii@kernel.org \
    --cc=ast@kernel.org \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=eddyz87@gmail.com \
    --cc=jolsa@kernel.org \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.lau@linux.dev \
    --cc=memxor@gmail.com \
    --cc=mykyta.yatsenko5@gmail.com \
    --cc=song@kernel.org \
    --cc=yatsenko@meta.com \
    --cc=yonghong.song@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.