All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Ashwin Gundarapu <linuxuser509@zohomail.in>
Cc: gregkh <gregkh@linuxfoundation.org>,
	linux-staging <linux-staging@lists.linux.dev>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: rtl8723bs: remove unnecessary boolean comparisons in rtw_recv.c
Date: Sat, 23 May 2026 13:23:09 +0300	[thread overview]
Message-ID: <ahGADW1fpR8e12Dl@stanley.mountain> (raw)
In-Reply-To: <19e53a283b8.4f2498e045168.7106069608127124839@zohomail.in>

On Sat, May 23, 2026 at 12:30:20PM +0530, Ashwin Gundarapu wrote:
> @@ -1841,8 +1841,7 @@ static int enqueue_reorder_recvframe(struct recv_reorder_ctrl *preorder_ctrl, un
>  			/* Duplicate entry is found!! Do not insert current entry. */
>  			/* spin_unlock_irqrestore(&ppending_recvframe_queue->lock, irql); */
>  			return false;
> -		else
> -			break;
> +		break;
>  
>  	}

This is a bug.  You have to think about what checkpatch says instead of
following it blindly.  Also it's unrelated to the patch description.

regards,
dan carpenter


      parent reply	other threads:[~2026-05-23 10:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-23  7:00 [PATCH] staging: rtl8723bs: remove unnecessary boolean comparisons in rtw_recv.c Ashwin Gundarapu
2026-05-23  8:27 ` Ahmet Sezgin Duran
2026-05-23 10:23 ` Dan Carpenter [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahGADW1fpR8e12Dl@stanley.mountain \
    --to=error27@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=linuxuser509@zohomail.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.