From: Florian Westphal <fw@strlen.de>
To: Fernando Fernandez Mancera <fmancera@suse.de>
Cc: netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
pablo@netfilter.org, phil@nwl.cc
Subject: Re: [PATCH 0/3 nf-next] netfilter: synproxy: timestamp adjustment fixes
Date: Sun, 24 May 2026 21:24:30 +0200 [thread overview]
Message-ID: <ahNQbjbK5DBNWnNt@strlen.de> (raw)
In-Reply-To: <3178bbf8-552a-45cf-819f-bf3ec2de41e0@suse.de>
Fernando Fernandez Mancera <fmancera@suse.de> wrote:
> Hm. That might be an appealing argument for the dup timestamp option, if we
> want to be more relaxed we can just adjust all timestamp options equally (we
> need to assume that this is a corner case of course).
>
> But when failing skb_ensure_writable() or when encountering completely
> malformed options I believe we should drop the packet.
Not so sure. skb_ensure_writable() -> yes.
But for malformed options? I think it should be done by policy.
Not even conntrack drops such packets at the moment.
Could you use NF_DROP_REASON() in next version?
NF_DROP conceals the drop location which makes debugging harder.
Thanks!
next prev parent reply other threads:[~2026-05-24 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 19:47 [PATCH 0/3 nf-next] netfilter: synproxy: timestamp adjustment fixes Fernando Fernandez Mancera
2026-05-23 19:47 ` [PATCH 1/3 nf-next] netfilter: synproxy: drop packets if timestamp adjustment fails Fernando Fernandez Mancera
2026-05-23 19:47 ` [PATCH 2/3 nf-next] netfilter: synproxy: drop packets with duplicated timestamp options Fernando Fernandez Mancera
2026-05-23 19:47 ` [PATCH 3/3 nf-next] netfilter: synproxy: fix unaligned memory access in timestamp adjustment Fernando Fernandez Mancera
2026-05-24 16:58 ` [PATCH 0/3 nf-next] netfilter: synproxy: timestamp adjustment fixes Fernando Fernandez Mancera
2026-05-24 17:16 ` Florian Westphal
2026-05-24 18:48 ` Fernando Fernandez Mancera
2026-05-24 19:24 ` Florian Westphal [this message]
2026-05-24 21:24 ` Fernando Fernandez Mancera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahNQbjbK5DBNWnNt@strlen.de \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=fmancera@suse.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.