Re: [PATCH] tpm: tpm_tis: Add optional delay after relinquish

[Jarkko Sakkinen <jarkko@kernel.org>]

On Sat, May 23, 2026 at 06:39:52PM -0700, Jim Broadus wrote:
> Hi Jarkko. The current manufacturer_id is in tpm_tis_data, not tpm_chip. I
> think it makes sense to move the new did_vid to tpm_chip so it can be used
> in tpm-sysfs, but it would only be set (at least initially) for the tpm_tis
> driver. What do you think?

Oops. Sorry, I just described myself incorrectly.

What I actually meant was adding priv->did_vid.

Thanks for paying attention!

> 
> Thank you,
> Jim
> 
> On 5/22/26 5:37 AM, Jarkko Sakkinen wrote:
> > On Thu, May 21, 2026 at 11:03:29PM -0700, Jim Broadus wrote:
> > > Thank you Jarkko. I'll do that.
> > > 
> > > Jim
> > Yeah, in this form it is quite unsable e.g., for any Linux distribution,
> > and somewhat involved for the user :-)
> > 
> > Conditionally on is much better with appropriate detection. Also, this
> > way the change improves the code base a bit given that chip->did_vid is
> > much more applicable than chip->manufaturer_id.
> > 
> > BR, Jarkko

BR, Jarkko