From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D40133BFE50; Mon, 25 May 2026 07:11:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693113; cv=none; b=dp55kBJfnKAeO7cRqFaYA7WE+qc3w+mc3BZlJWVh1h4k6H4xg1fRp/Tgn4sDSmVSaI+bBG/lNPfA7NV/uRlooirlPSF/AYLL5Fpwb8QtOeF+uTTU5mejwrUM+HnvH4Hzw+TXstcqeeOD6EgpaF1enrwYkNM8siGFg07fuf2GaIU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779693113; c=relaxed/simple; bh=FouUt+dGBKmvdfU7CrVUd7euP+mnCDRi7EIxc8h4a3g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pQNvMgCLSxN5DjTE2jQ75pq1gK3kCiJRCWNAuQCdu27WGZfFGElOdhTmmHUhZxw2OEj0drCDnMjHiMGYDLAIZnzKCXDT+9ycQy9rD8aLAbT6D0gTraHug0ewOxjRPww3a4A+UFyUfIabKAz0gwjARYJpEwrn1bqY30tcu1JjKOA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=1A9EkQLr; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="1A9EkQLr" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xqcxhYP71Y45aA5yA9zJWnZB6u8t86CEsBFptEY8fj0=; b=1A9EkQLrKBcFUFwj6aS6K6lXCJ ASmNZPmU+odZG3FRd6nhizJsMn238rFOAmrMbyf6mh/Zd7gVSeIrbyChFhXyTGI+ljzOG1XhfnnE+ bqgfAztY/aWKqN/VYg8zggDZtoLbjAyK1fpTU5k8toSkjDaasnhmyKrDvBdtP0jbgLJsdHNQ3NWUG KYZ0Yenu2dOFGi2LI8GOdhijZCjLuDa9N8c9aCPlf/jvwKlX8O4AUunr3xL6tbDeDsLnUa9qthr9G cyxpnxPXKUlFM8ZQ6VorUqmo/I1fOy8MskuKMcVTq26JZTM6zL86ZXYFl/jx/b9tP99f7BEAPm33M dbEmNyGA==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRPTc-0000000GVCw-0Mn5; Mon, 25 May 2026 07:11:52 +0000 Date: Mon, 25 May 2026 00:11:52 -0700 From: Christoph Hellwig To: Anand Jain Cc: fstests@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, amir73il@gmail.com, zlang@redhat.com, hch@infradead.org Subject: Re: [PATCH v5 04/10] fstests: verify fanotify isolation on cloned filesystems Message-ID: References: Precedence: bulk X-Mailing-List: linux-xfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html > +export FSNOTIFYWAIT_PROG="$(type -P fsnotifywait)" Same comment about adding new common bits outside of test cases applies, but why use both inotify and fsnotify? > +[[ "$fsid1" == "$fsid2" ]] && \ > + _notrun "Require clone filesystem with unique f_fsid" Please add a comment why this happens. I also have to say I find the if syntax easier to follow then && with a line continuation. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C63D9CD5BBF for ; Mon, 25 May 2026 07:12:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=qYRI3wJhn9Z9aUWkfWoJDHXcZAr5Q8Aix61yFAgbbqY=; b=Phvan6NR5yWbtSuDQ5SzMHXUO4 M3B3WtM898XlINub3lqzMXsdT0t7G0bTyxrwo3F+F+KdjgScA4kkV3UPioOykJdj2/3G04C5geRRf 7T4/f06VP2tNFzJ6a6YA7YHdz0rZcGXM6Rb+K3P6gDB1eUB2UIUndeRsecHL+7QVGYAc=; Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wRPTr-0000lP-D9; Mon, 25 May 2026 07:12:04 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wRPTp-0000lI-I6 for linux-f2fs-devel@lists.sourceforge.net; Mon, 25 May 2026 07:12:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=xqcxhYP71Y45aA5yA9zJWnZB6u8t86CEsBFptEY8fj0=; b=HRgnZPgkhRowMRYtiYvhY+22aX Q63kWRwCL1u9ifi7u/my0PXZy7mr3uRs1e/oPelK+Hf8Wa5GBu1NEkM7Tg4KJsdLmzLTufYp1CtLx 6o/D/uhJ/jmX8P7D7SlCbB5lNVEvhkt/cVQmcOgqc657PGZrNRpBsLjzNwcrmHeA2TZQ=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=xqcxhYP71Y45aA5yA9zJWnZB6u8t86CEsBFptEY8fj0=; b=JQ0cD+EFXasO4GN/MwD1lJN5AG XCPD1M6F0MD5b+i4xaGxzP0fItvMvk2EqmFjI91RtsLNYHdmgbU+7HNzrmRZcu4D1R/dcvK/yMkeO tM3MEOoxBSxLy6sY9fxiUIYbuCeCK5dP8AbdENLQ5FUIMRAGjqE3KSse4B2KCDDay66M=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wRPTm-0008Vw-5E for linux-f2fs-devel@lists.sourceforge.net; Mon, 25 May 2026 07:12:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xqcxhYP71Y45aA5yA9zJWnZB6u8t86CEsBFptEY8fj0=; b=1A9EkQLrKBcFUFwj6aS6K6lXCJ ASmNZPmU+odZG3FRd6nhizJsMn238rFOAmrMbyf6mh/Zd7gVSeIrbyChFhXyTGI+ljzOG1XhfnnE+ bqgfAztY/aWKqN/VYg8zggDZtoLbjAyK1fpTU5k8toSkjDaasnhmyKrDvBdtP0jbgLJsdHNQ3NWUG KYZ0Yenu2dOFGi2LI8GOdhijZCjLuDa9N8c9aCPlf/jvwKlX8O4AUunr3xL6tbDeDsLnUa9qthr9G cyxpnxPXKUlFM8ZQ6VorUqmo/I1fOy8MskuKMcVTq26JZTM6zL86ZXYFl/jx/b9tP99f7BEAPm33M dbEmNyGA==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRPTc-0000000GVCw-0Mn5; Mon, 25 May 2026 07:11:52 +0000 Date: Mon, 25 May 2026 00:11:52 -0700 From: Christoph Hellwig To: Anand Jain Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1wRPTm-0008Vw-5E Subject: Re: [f2fs-dev] [PATCH v5 04/10] fstests: verify fanotify isolation on cloned filesystems X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: hch@infradead.org, zlang@redhat.com, amir73il@gmail.com, fstests@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net > +export FSNOTIFYWAIT_PROG="$(type -P fsnotifywait)" Same comment about adding new common bits outside of test cases applies, but why use both inotify and fsnotify? > +[[ "$fsid1" == "$fsid2" ]] && \ > + _notrun "Require clone filesystem with unique f_fsid" Please add a comment why this happens. I also have to say I find the if syntax easier to follow then && with a line continuation. _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel