From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C7271AC44D; Mon, 25 May 2026 05:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779687428; cv=none; b=c99XjiBtF9kXo7DlyEOxewEH2A0csj6o3LIy9xZkcvbfA3LmU6WuwU1/zkw2DB30OCtFr0hiB1psPlCNmnlLeciYM7Fvd2rw1/Q/2trMIRVJ3TFj11ZIKXw71tUpXTTkU/Ds/qVISIlqB6oG7CN2Ujvx43P2I9o+8PGOOb/mSaA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779687428; c=relaxed/simple; bh=aSUk+GkfuNtV5doxYAl/uvzB5aZCrVlMtp/gV8VEcc0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=I90zeiJYWgAOFwp4TXYvu0ym4Warra1cJ5RW6TBumt2cewEGTkcNhkF8CVo1cAIvZ9WxE09Q/MbZfddhNAQttxeV/8UsJhoznUWOqyhDt+F6LC30sJCKXxawWiyW0sk6zC7g7711iR81/FkKA/VCTST78khY4rHXgNbyVz6pjRY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=mI7+58UN; arc=none smtp.client-ip=198.137.202.133 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="mI7+58UN" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=bPlnrUAngQhntq0icVQxK0A5R6EP/y6CGfxUmuJ8Roc=; b=mI7+58UNZvQ1rHO+UR+G3zOxD7 /8Q4dyZKxJcdSNb/R47cH8reyDTtiHoTo+ZY1PEHKP1sCy7wV2KEhwd8MNm/M9D7VXNwHZoztfouo ellPDj7sZaVnwIcwtuRKY+kRVN9tGtX3CfEZ+71st7D3jw6OwcdGneEEFEF9XNvEvTxVz0XU8F5v6 aKLKYaDQcv0dpz+Vxwj0TvKoeLyqOXxQt3Fs7io8F6fnGJKSnqnfrBDTuM9Bjn1mwkQsNTWDDnfhD qxzwqs5H2TVfEJQkzZA/O6FF3yMLeD+t3A5pcA1FIZEHbDav7HM47fbADf9+YeeWA6EZTFKtS8mej OhB0Hp4w==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRNzu-0000000GKn6-0I3f; Mon, 25 May 2026 05:37:06 +0000 Date: Sun, 24 May 2026 22:37:06 -0700 From: Christoph Hellwig To: Jaegeuk Kim Cc: Theodore Tso , Christoph Hellwig , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Akilesh Kailash , Christian Brauner Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number Message-ID: References: <20260409134538.3692605-1-jaegeuk@kernel.org> <20260521155748.GA79343@macsyma-wired.lan> Precedence: bulk X-Mailing-List: linux-fsdevel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html On Fri, May 22, 2026 at 03:32:39AM +0000, Jaegeuk Kim wrote: > I went this route because Android heavily restricts ioctl() permissions > and we needed broader access for this to work within the framework. It’s > definitely a pragmatic choice just to get it running in production. That is not a good reason. > If ioctl() is a right way for upstream, I'm happy to change this patch. By > the way, I really don't understand why all the messages are so offensive, > even without trying to understand the problem or guiding right directions. The right way is to: 1) Talk to the relevant subsystems (MM and fsdevel), and if it affects userspace that linux-api list and actually explain your use case. 2) And then actually listen to feedback. f2fs just keeps piling these ABI hacks on without any review, and it is causing real problems. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 11B7ECD5BC0 for ; Mon, 25 May 2026 05:37:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.sourceforge.net; s=beta; h=Content-Transfer-Encoding:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: Subject:In-Reply-To:MIME-Version:References:Message-ID:To:From:Date:Sender: Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender :Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7GUB4pNxlZPr60KeUQTnbjVV4zrqhmBo2yKBG6VolNE=; b=JcxGWPelcJUINl1RLwuTzfWx2v NuYjfr4qrasXhlKnwP4JhQrH/teqy2nWktWAMbf5+BZ5ZOm8I83KrmkX8fKeViQD7pVWQeNzyyLYg Me3mDG0Apc/C+V1O9MVfVxtLgVyfyYx0ET9mbtsJM2dr4gqlyQ6qp8kCfv6r6RlcAcpk=; Received: from [127.0.0.1] (helo=sfs-ml-4.v29.lw.sourceforge.com) by sfs-ml-4.v29.lw.sourceforge.com with esmtp (Exim 4.95) (envelope-from ) id 1wRO08-0001KL-Ea; Mon, 25 May 2026 05:37:20 +0000 Received: from [172.30.29.66] (helo=mx.sourceforge.net) by sfs-ml-4.v29.lw.sourceforge.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1wRO07-0001KE-Ch for linux-f2fs-devel@lists.sourceforge.net; Mon, 25 May 2026 05:37:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Transfer-Encoding:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bPlnrUAngQhntq0icVQxK0A5R6EP/y6CGfxUmuJ8Roc=; b=LADsmVuyZ26O7+1eE4XZjHWdlH AN07ZFu1+nkc/aexH2mh64+Ir3horQS2PxqgIuxt5xDjKM3TS0hV2txSOL7YlVIQrSMoYbpYXZ7HP YdT8D/fN3mIMQlEYB2aUbUtcf+Q8ko980FC7uhJCNY7IfmpQCJ3h6K6g/qIZF5p6Wu4g=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=bPlnrUAngQhntq0icVQxK0A5R6EP/y6CGfxUmuJ8Roc=; b=SRnihHdPbcvPpT2pvsYQtR0vMp zfLd+7L4W9nhc0aBl6mgfiKeoRCWs6KXCL6EjH9xPJ2ozyZkdd5tcZDJHrrXaUvTnZEEV/uQqu29K x6jIUcqIwqQe6axyouaZICF4mDkHKcerHSnE/8N/SnSs9dVgrfYzKRPZdC5y2ce7i1b8=; Received: from bombadil.infradead.org ([198.137.202.133]) by sfi-mx-2.v28.lw.sourceforge.com with esmtps (TLS1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.95) id 1wRO05-0000zH-Cl for linux-f2fs-devel@lists.sourceforge.net; Mon, 25 May 2026 05:37:19 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Transfer-Encoding :Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=bPlnrUAngQhntq0icVQxK0A5R6EP/y6CGfxUmuJ8Roc=; b=mI7+58UNZvQ1rHO+UR+G3zOxD7 /8Q4dyZKxJcdSNb/R47cH8reyDTtiHoTo+ZY1PEHKP1sCy7wV2KEhwd8MNm/M9D7VXNwHZoztfouo ellPDj7sZaVnwIcwtuRKY+kRVN9tGtX3CfEZ+71st7D3jw6OwcdGneEEFEF9XNvEvTxVz0XU8F5v6 aKLKYaDQcv0dpz+Vxwj0TvKoeLyqOXxQt3Fs7io8F6fnGJKSnqnfrBDTuM9Bjn1mwkQsNTWDDnfhD qxzwqs5H2TVfEJQkzZA/O6FF3yMLeD+t3A5pcA1FIZEHbDav7HM47fbADf9+YeeWA6EZTFKtS8mej OhB0Hp4w==; Received: from hch by bombadil.infradead.org with local (Exim 4.99.1 #2 (Red Hat Linux)) id 1wRNzu-0000000GKn6-0I3f; Mon, 25 May 2026 05:37:06 +0000 Date: Sun, 24 May 2026 22:37:06 -0700 From: Christoph Hellwig To: Jaegeuk Kim Message-ID: References: <20260409134538.3692605-1-jaegeuk@kernel.org> <20260521155748.GA79343@macsyma-wired.lan> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Headers-End: 1wRO05-0000zH-Cl Subject: Re: [f2fs-dev] [PATCH v2] f2fs: another way to set large folio by remembering inode number X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Tso , linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, Matthew Wilcox , linux-f2fs-devel@lists.sourceforge.net, Christoph Hellwig , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Akilesh Kailash , Christian Brauner Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net T24gRnJpLCBNYXkgMjIsIDIwMjYgYXQgMDM6MzI6MzlBTSArMDAwMCwgSmFlZ2V1ayBLaW0gd3Jv dGU6Cj4gSSB3ZW50IHRoaXMgcm91dGUgYmVjYXVzZSBBbmRyb2lkIGhlYXZpbHkgcmVzdHJpY3Rz IGlvY3RsKCkgcGVybWlzc2lvbnMKPiBhbmQgd2UgbmVlZGVkIGJyb2FkZXIgYWNjZXNzIGZvciB0 aGlzIHRvIHdvcmsgd2l0aGluIHRoZSBmcmFtZXdvcmsuIEl04oCZcwo+IGRlZmluaXRlbHkgYSBw cmFnbWF0aWMgY2hvaWNlIGp1c3QgdG8gZ2V0IGl0IHJ1bm5pbmcgaW4gcHJvZHVjdGlvbi4KClRo YXQgaXMgbm90IGEgZ29vZCByZWFzb24uCgo+IElmIGlvY3RsKCkgaXMgYSByaWdodCB3YXkgZm9y IHVwc3RyZWFtLCBJJ20gaGFwcHkgdG8gY2hhbmdlIHRoaXMgcGF0Y2guIEJ5Cj4gdGhlIHdheSwg SSByZWFsbHkgZG9uJ3QgdW5kZXJzdGFuZCB3aHkgYWxsIHRoZSBtZXNzYWdlcyBhcmUgc28gb2Zm ZW5zaXZlLAo+IGV2ZW4gd2l0aG91dCB0cnlpbmcgdG8gdW5kZXJzdGFuZCB0aGUgcHJvYmxlbSBv ciBndWlkaW5nIHJpZ2h0IGRpcmVjdGlvbnMuCgpUaGUgcmlnaHQgd2F5IGlzIHRvOgoKIDEpIFRh bGsgdG8gdGhlIHJlbGV2YW50IHN1YnN5c3RlbXMgKE1NIGFuZCBmc2RldmVsKSwgYW5kIGlmIGl0 IGFmZmVjdHMKICAgIHVzZXJzcGFjZSB0aGF0IGxpbnV4LWFwaSBsaXN0IGFuZCBhY3R1YWxseSBl eHBsYWluIHlvdXIgdXNlIGNhc2UuCiAyKSBBbmQgdGhlbiBhY3R1YWxseSBsaXN0ZW4gdG8gZmVl ZGJhY2suICBmMmZzIGp1c3Qga2VlcHMgcGlsaW5nIHRoZXNlCiAgICBBQkkgaGFja3Mgb24gd2l0 aG91dCBhbnkgcmV2aWV3LCBhbmQgaXQgaXMgY2F1c2luZyByZWFsIHByb2JsZW1zLgoKCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1mMmZzLWRl dmVsIG1haWxpbmcgbGlzdApMaW51eC1mMmZzLWRldmVsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldApo dHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5mby9saW51eC1mMmZzLWRl dmVsCg==