From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-170.mta1.migadu.com (out-170.mta1.migadu.com [95.215.58.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8D2B3DD876 for ; Mon, 25 May 2026 09:56:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779702987; cv=none; b=FyTfllp8Io01R2p1NQO2LPm+hrH/FBnbLF6vrj0VJr9pb0VPNKUx76kIh2kLz5GGlgtIhTrcTYytQHu+UAgrVZnWbGFqDpp89488QRVLOQPz3G04OsuEi/aePVFjvAXjcqSBxbVvioqZTWbId8aZ728ogmOy94Lg0z6AnYOsqBM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779702987; c=relaxed/simple; bh=tb/DLQ/7qCXIEi0kX4QbdnpJ3zau6gddngpHxqAV6bc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P5/LhWc1AfqP/N1MEtC3Pnev+XG4hSuwUrvycaSeIhbu6H8Jek3mALRK5K3V0i/EdpXAm+hmDNM08qsXpVpEGL3XbCU+UL+jTpB3Vj0NOJrAjwPBxFrvvYV11+nLZ6+pG/r9KnqWosdLzowDOaoOcJpkVc1ZTbwEdFVSByN0og0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=cMU4S4Z2; arc=none smtp.client-ip=95.215.58.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="cMU4S4Z2" Date: Mon, 25 May 2026 11:56:18 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1779702984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=6WDPH1X2mmGmZ7PxquaY/9ISkjAsR6FcdXVOe7SBHVU=; b=cMU4S4Z2VRtGQiYgSAAIOyvhmNfmpYcnmWQtHmXiYcQECCEo2cKTNGH+afzbs8Kjkdi7NC V7j11/Ye3YIBblVDECTiyMXOpLjFMlgioIh1GEi+taKwXeZbFpp2Bj3dRS8Io1mPzMwKMA ES9d9LCFYrNd9wBrtdQGcgO4etKd8tM= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Thorsten Blum To: Parthiban Veerasooran , Christian Gromm Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH RESEND] most: core: Use sysfs_emit in sysfs show functions Message-ID: References: <20260309223733.83958-3-thorsten.blum@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260309223733.83958-3-thorsten.blum@linux.dev> X-Migadu-Flow: FLOW_OUT Gentle ping? On Mon, Mar 09, 2026 at 11:37:35PM +0100, Thorsten Blum wrote: > Replace snprintf() with sysfs_emit() in sysfs show functions. > sysfs_emit() is preferred for formatting sysfs output because it > provides safer bounds checking. In components_show() and print_links(), > use sysfs_emit_at() to avoid manual buffer size accounting. > > Signed-off-by: Thorsten Blum > --- > drivers/most/core.c | 87 +++++++++++++++++++++------------------------ > 1 file changed, 40 insertions(+), 47 deletions(-) > > diff --git a/drivers/most/core.c b/drivers/most/core.c > index c2616da8bceb..64766c021677 100644 > --- a/drivers/most/core.c > +++ b/drivers/most/core.c > @@ -208,8 +208,8 @@ static ssize_t number_of_packet_buffers_show(struct device *dev, > struct most_channel *c = to_channel(dev); > unsigned int i = c->channel_id; > > - return snprintf(buf, PAGE_SIZE, "%d\n", > - c->iface->channel_vector[i].num_buffers_packet); > + return sysfs_emit(buf, "%d\n", > + c->iface->channel_vector[i].num_buffers_packet); > } > > static ssize_t number_of_stream_buffers_show(struct device *dev, > @@ -219,8 +219,8 @@ static ssize_t number_of_stream_buffers_show(struct device *dev, > struct most_channel *c = to_channel(dev); > unsigned int i = c->channel_id; > > - return snprintf(buf, PAGE_SIZE, "%d\n", > - c->iface->channel_vector[i].num_buffers_streaming); > + return sysfs_emit(buf, "%d\n", > + c->iface->channel_vector[i].num_buffers_streaming); > } > > static ssize_t size_of_packet_buffer_show(struct device *dev, > @@ -230,8 +230,8 @@ static ssize_t size_of_packet_buffer_show(struct device *dev, > struct most_channel *c = to_channel(dev); > unsigned int i = c->channel_id; > > - return snprintf(buf, PAGE_SIZE, "%d\n", > - c->iface->channel_vector[i].buffer_size_packet); > + return sysfs_emit(buf, "%d\n", > + c->iface->channel_vector[i].buffer_size_packet); > } > > static ssize_t size_of_stream_buffer_show(struct device *dev, > @@ -241,8 +241,8 @@ static ssize_t size_of_stream_buffer_show(struct device *dev, > struct most_channel *c = to_channel(dev); > unsigned int i = c->channel_id; > > - return snprintf(buf, PAGE_SIZE, "%d\n", > - c->iface->channel_vector[i].buffer_size_streaming); > + return sysfs_emit(buf, "%d\n", > + c->iface->channel_vector[i].buffer_size_streaming); > } > > static ssize_t channel_starving_show(struct device *dev, > @@ -251,7 +251,7 @@ static ssize_t channel_starving_show(struct device *dev, > { > struct most_channel *c = to_channel(dev); > > - return snprintf(buf, PAGE_SIZE, "%d\n", c->is_starving); > + return sysfs_emit(buf, "%d\n", c->is_starving); > } > > static ssize_t set_number_of_buffers_show(struct device *dev, > @@ -260,7 +260,7 @@ static ssize_t set_number_of_buffers_show(struct device *dev, > { > struct most_channel *c = to_channel(dev); > > - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.num_buffers); > + return sysfs_emit(buf, "%d\n", c->cfg.num_buffers); > } > > static ssize_t set_buffer_size_show(struct device *dev, > @@ -269,7 +269,7 @@ static ssize_t set_buffer_size_show(struct device *dev, > { > struct most_channel *c = to_channel(dev); > > - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.buffer_size); > + return sysfs_emit(buf, "%d\n", c->cfg.buffer_size); > } > > static ssize_t set_direction_show(struct device *dev, > @@ -279,10 +279,10 @@ static ssize_t set_direction_show(struct device *dev, > struct most_channel *c = to_channel(dev); > > if (c->cfg.direction & MOST_CH_TX) > - return snprintf(buf, PAGE_SIZE, "tx\n"); > + return sysfs_emit(buf, "tx\n"); > else if (c->cfg.direction & MOST_CH_RX) > - return snprintf(buf, PAGE_SIZE, "rx\n"); > - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); > + return sysfs_emit(buf, "rx\n"); > + return sysfs_emit(buf, "unconfigured\n"); > } > > static ssize_t set_datatype_show(struct device *dev, > @@ -294,10 +294,9 @@ static ssize_t set_datatype_show(struct device *dev, > > for (i = 0; i < ARRAY_SIZE(ch_data_type); i++) { > if (c->cfg.data_type & ch_data_type[i].most_ch_data_type) > - return snprintf(buf, PAGE_SIZE, "%s", > - ch_data_type[i].name); > + return sysfs_emit(buf, "%s", ch_data_type[i].name); > } > - return snprintf(buf, PAGE_SIZE, "unconfigured\n"); > + return sysfs_emit(buf, "unconfigured\n"); > } > > static ssize_t set_subbuffer_size_show(struct device *dev, > @@ -306,7 +305,7 @@ static ssize_t set_subbuffer_size_show(struct device *dev, > { > struct most_channel *c = to_channel(dev); > > - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.subbuffer_size); > + return sysfs_emit(buf, "%d\n", c->cfg.subbuffer_size); > } > > static ssize_t set_packets_per_xact_show(struct device *dev, > @@ -315,7 +314,7 @@ static ssize_t set_packets_per_xact_show(struct device *dev, > { > struct most_channel *c = to_channel(dev); > > - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.packets_per_xact); > + return sysfs_emit(buf, "%d\n", c->cfg.packets_per_xact); > } > > static ssize_t set_dbr_size_show(struct device *dev, > @@ -323,7 +322,7 @@ static ssize_t set_dbr_size_show(struct device *dev, > { > struct most_channel *c = to_channel(dev); > > - return snprintf(buf, PAGE_SIZE, "%d\n", c->cfg.dbr_size); > + return sysfs_emit(buf, "%d\n", c->cfg.dbr_size); > } > > #define to_dev_attr(a) container_of(a, struct device_attribute, attr) > @@ -395,7 +394,7 @@ static ssize_t description_show(struct device *dev, > { > struct most_interface *iface = dev_get_drvdata(dev); > > - return snprintf(buf, PAGE_SIZE, "%s\n", iface->description); > + return sysfs_emit(buf, "%s\n", iface->description); > } > > static ssize_t interface_show(struct device *dev, > @@ -406,25 +405,25 @@ static ssize_t interface_show(struct device *dev, > > switch (iface->interface) { > case ITYPE_LOOPBACK: > - return snprintf(buf, PAGE_SIZE, "loopback\n"); > + return sysfs_emit(buf, "loopback\n"); > case ITYPE_I2C: > - return snprintf(buf, PAGE_SIZE, "i2c\n"); > + return sysfs_emit(buf, "i2c\n"); > case ITYPE_I2S: > - return snprintf(buf, PAGE_SIZE, "i2s\n"); > + return sysfs_emit(buf, "i2s\n"); > case ITYPE_TSI: > - return snprintf(buf, PAGE_SIZE, "tsi\n"); > + return sysfs_emit(buf, "tsi\n"); > case ITYPE_HBI: > - return snprintf(buf, PAGE_SIZE, "hbi\n"); > + return sysfs_emit(buf, "hbi\n"); > case ITYPE_MEDIALB_DIM: > - return snprintf(buf, PAGE_SIZE, "mlb_dim\n"); > + return sysfs_emit(buf, "mlb_dim\n"); > case ITYPE_MEDIALB_DIM2: > - return snprintf(buf, PAGE_SIZE, "mlb_dim2\n"); > + return sysfs_emit(buf, "mlb_dim2\n"); > case ITYPE_USB: > - return snprintf(buf, PAGE_SIZE, "usb\n"); > + return sysfs_emit(buf, "usb\n"); > case ITYPE_PCIE: > - return snprintf(buf, PAGE_SIZE, "pcie\n"); > + return sysfs_emit(buf, "pcie\n"); > } > - return snprintf(buf, PAGE_SIZE, "unknown\n"); > + return sysfs_emit(buf, "unknown\n"); > } > > static DEVICE_ATTR_RO(description); > @@ -471,20 +470,16 @@ static int print_links(struct device *dev, void *data) > > list_for_each_entry(c, &iface->p->channel_list, list) { > if (c->pipe0.comp) { > - offs += scnprintf(buf + offs, > - PAGE_SIZE - offs, > - "%s:%s:%s\n", > - c->pipe0.comp->name, > - dev_name(iface->dev), > - dev_name(&c->dev)); > + offs += sysfs_emit_at(buf, offs, "%s:%s:%s\n", > + c->pipe0.comp->name, > + dev_name(iface->dev), > + dev_name(&c->dev)); > } > if (c->pipe1.comp) { > - offs += scnprintf(buf + offs, > - PAGE_SIZE - offs, > - "%s:%s:%s\n", > - c->pipe1.comp->name, > - dev_name(iface->dev), > - dev_name(&c->dev)); > + offs += sysfs_emit_at(buf, offs, "%s:%s:%s\n", > + c->pipe1.comp->name, > + dev_name(iface->dev), > + dev_name(&c->dev)); > } > } > d->offs = offs; > @@ -517,10 +512,8 @@ static ssize_t components_show(struct device_driver *drv, char *buf) > struct most_component *comp; > int offs = 0; > > - list_for_each_entry(comp, &comp_list, list) { > - offs += scnprintf(buf + offs, PAGE_SIZE - offs, "%s\n", > - comp->name); > - } > + list_for_each_entry(comp, &comp_list, list) > + offs += sysfs_emit_at(buf, offs, "%s\n", comp->name); > return offs; > } >