From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 06A3837F72A for ; Mon, 25 May 2026 16:13:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779725634; cv=none; b=A2OoamsM0JDEr8YgGJSu6Fl4edSRdchqPUHtpieAtaJn+nM85BAXGRa550P5+2VHwQEI8Giymau64nI34xBNHhxthl3FHWwfahMSGiZPcizQix6Yb3uLZ3AGo/VDNMTltHJnuabXwTElKuxGvzU5iCSzl9mVhauAaCiTJSA12GI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779725634; c=relaxed/simple; bh=JzjiaMqvE6FAwKJVfStKuwbHiv1l5iHnK2iRBi/Jtic=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=brQeIaBP3z4OA5sMxtqgrDL4JBYhW/oW4/jca6NqcAajLQ2VUxWWasxMaQOdua5s8PhLQvbrIyZd+8px2JEJlfcEWfl6hVVNDHal0a1dfaU9C1Dx2mmcHVUNNs8dAgxx4ils/UVqWa92Dte7luEMRgBKkoJp3Q7nhOL4Ga1zZrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P9igVaic; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P9igVaic" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-49048e043e5so22143105e9.1 for ; Mon, 25 May 2026 09:13:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779725631; x=1780330431; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gmb4w9ug6rV3MhwyPHJsQp6I0uLZIGzYTMG8YoeZqok=; b=P9igVaicxryAXDr5qsu+pQ8i3X+blGg4WzaIAOHE8xDl04/ef+WJBBZiP2GJG8J/dq l5XD7qqbncGTQTSkyafzLGh1lkN7nzyXSBuKvjKhIRXWmsk+LVQv9T0gU4yG0iPC0/w/ MC/SgXNS52CGocufGOEQt/UApnRICNqSqMxzX85towwirk181zIgpnKaEvc+AXHqMQiv v4Nw+xUKbF9orNAMqDJvbtZCv7QEOGQwk7x23hPM86KY4GJqxVVCziQ4Ie8dxO0JCa6l 5HGJjl1RQ6jnXFFE/t99uSIVf24Ei5WIsgmPWhMrwc7bcX0SiKCOXsHrGQ1TpXa1tV1E 3Wiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779725631; x=1780330431; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gmb4w9ug6rV3MhwyPHJsQp6I0uLZIGzYTMG8YoeZqok=; b=XU/GPYTAmDytMn+MaogA75peg2IcGooAsTNmtrUohDOr5HN5i9Z++Gpv/pQVDD7yd7 diZuXo0ShVaVpvvqzEC8DLO/gQyGwIkOufXauo3qEd6HRdo1Wy1GQzlPnnnlYRO5cJSi O7DI1gBkmD+BZQzwhqUkagA3dztbl14IKcwzDLklWdUJAJLyZB7fiwFc0pbrwsgZyVb9 tzEe20gn1NgKQiCLuIQW796+7H+VBMJ7nT5ZxSlTRmes0MMV9ojgL7+1B3LFzAmbF/6M DUSeffEFEtW8xiIJd/MTGL+DoDYbl2BxVqisvkIUvYRJjXJi6iJ05s47fYuHrd+jOm1L s5Tg== X-Forwarded-Encrypted: i=1; AFNElJ9UnrjkHJrgF0CPTWjksw82ylqmrXBSroZiVwzJ1NBD5T41JYOA8DCBpgUuwFRzUUsGP3Aevsoct7sqDNc=@vger.kernel.org X-Gm-Message-State: AOJu0YzgZcWGJ2NEV4x3OFEaf8rxFDYQGGDg8/9YQu6W10N3eZlZYOPL RIzvhFuwm37J5Xi6TcSxYJ+2ZerE//A5JlLqbJS75Ib1e4PjHZUJM/lw X-Gm-Gg: Acq92OF3dMgVzN6f2Ykzd5bCK8yhCFO7DHueap6+qGZbJUQy0XWUNxwkXkmwgwrQmn6 pjwLuCkwROos5QPMVaKfomDKIzVFzhQ0hSj+1/YWg/864KtR5AUory3uhBqb5EqMvRg9rMyVZdL eCPMgRXDt2xpP5URmWlesG0k/GW1GrwX8YEKnVY+kcpsmvyo95pdP+Q1ndo1xbA0sCNdX7M+nif mwwfUvDwXK0v6fqPyMo1DJ5WpboQLx/zOhNOeMIKgAzs0urz74rpYos6iMRU93vE6KVmTl0hIrJ VIiFri45z33GuTtDOs9576hVq7Fh6XSLVP4jGpY41oQ83NjPJuGc58P3eyRHfROwO7wPJURA1Ig Vf4xAGDveDilaWeBoae/GylAOQPzyLQ2WZ3bb5zUaeSl6n04BBKNLg8flkBoSVwwfwcGY6doGo6 C0WWhKHd6zcUVdLzigb7IM/fQ= X-Received: by 2002:a05:600c:8b84:b0:490:5466:8576 with SMTP id 5b1f17b1804b1-490546689a7mr190155205e9.1.1779725631134; Mon, 25 May 2026 09:13:51 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4904179c615sm90065985e9.4.2026.05.25.09.13.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 09:13:50 -0700 (PDT) Date: Mon, 25 May 2026 19:13:47 +0300 From: Dan Carpenter To: Ahmet Sezgin Duran Cc: gregkh@linuxfoundation.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH 5/5] staging: sm750fb: deduplicate fbinfo loop in suspend/resume Message-ID: References: <20260523051509.166152-1-ahmet@sezginduran.net> <20260523051509.166152-6-ahmet@sezginduran.net> <86216e7d-7867-4041-892b-aafeb39781b8@sezginduran.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86216e7d-7867-4041-892b-aafeb39781b8@sezginduran.net> On Mon, May 25, 2026 at 11:23:43AM +0300, Ahmet Sezgin Duran wrote: > On 5/25/26 11:01 AM, Dan Carpenter wrote: > > I was waiting to see if anyone had other comments bout this patchset > > to decide if I should mention these minor nits. But then I was > > confused about v2 so I think there might end up being comments... :P > > v2 was only about dropping another patch from series, no change for this > patch. (would be better to talk this in v2 mails, but I guess it's no big > deal.) I thought you were going to to abandon the ARRAY_SIZE(cdb) in v2. regards, dan carpenter