From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists1p.gnu.org (lists1p.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BE342CD5BC9 for ; Mon, 25 May 2026 14:45:49 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists1p.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1wRWYM-0004Au-ST; Mon, 25 May 2026 10:45:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists1p.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wRWYL-00044u-6C for qemu-devel@nongnu.org; Mon, 25 May 2026 10:45:13 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1wRWYH-00088U-Nn for qemu-devel@nongnu.org; Mon, 25 May 2026 10:45:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779720307; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=bzBYk0cXJftc7nISK2ZBpd8qfVg3eR7Md2nG1A2a0Cw=; b=Chf3ylMMIIMQkIcv75YAz6GK6rwDR0CqhECyT/TOOkscPaYxzhVOvZvySPcS6wm0io71pD X2x/o8a/B97rs1+JYIzagw9nelZ+KSFR9RMhNl/W1gILI0r5UylpHaNF94aQGwFtQl9b/F /NRSs+N/ofnfy2CbBJFFwERKgYPtl30= Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-678-pKDJB9PgOtCrDvti1Syekw-1; Mon, 25 May 2026 10:45:06 -0400 X-MC-Unique: pKDJB9PgOtCrDvti1Syekw-1 X-Mimecast-MFC-AGG-ID: pKDJB9PgOtCrDvti1Syekw_1779720306 Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8b7105dfb5eso30075956d6.2 for ; Mon, 25 May 2026 07:45:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779720306; x=1780325106; darn=nongnu.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=bzBYk0cXJftc7nISK2ZBpd8qfVg3eR7Md2nG1A2a0Cw=; b=M0hRM4rdZ5Xt34BouLJpGKGl2PlOeWk7iVT86jhhWJHRxZrl5HtaMrfARD8Pj12v+V NyMddUiqukz9kZO7PLGzuIDbuO8aVRDQF5aO3SUrqNJbPTv21zfOGAb4QYGBO1eX/SvS 0HHbMUPhbCPDPqsVBYLG3GttSwUsL1mvEFmfNU7qzNI4SkvBJj0KUmfUJXofWvjsNU7M S8ObU4md5FubpzSJsvJtLZSiWs+4nSZEVCiIzm9dFXa0HEuEOC1mlKozO1y1qJTX539W Wg3GoxtHUZ+250jqi8cAumbzSrFiQ4HykA+DJzTuDrYgyt0hcIdsOuFN7DSePRfEciEE RTyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779720306; x=1780325106; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bzBYk0cXJftc7nISK2ZBpd8qfVg3eR7Md2nG1A2a0Cw=; b=VeMPMTkDgR0eyLHtHWTx393dkBs3x0x+jLIukqIBPy8KR81GEM+U5aY59Vb1isahYt GFJd5aIlfGsp6d97pV5g2nZb/AeefHzBcbEAL0uLsaXl5/TyYxqLMrcs3UU4gQYf44p2 M7Ck+EyifxvWHRvTctYkKQVX0TykDbx6rZv04O/hAZlTfk/obR5jBL/BrZ4xTxhYuyPp TXh/sY5sVt+e9woMk0IbIS5w+nUNatYNNSOQj4vFt+1OzetUMFbkS8o8c8AqcWwV22BW neAIsvwpn1fY+jn8yRL0kdzx1zh9oC0zdHPxEN2n+UTV4NRqJ8Llwr28k9qAhKyA1syE vcGA== X-Forwarded-Encrypted: i=1; AFNElJ9Fmn/fh/kGQ99htf2OdRmNeWRR/B6+XW3P77Ijk92ojmGjuQL2+Rsunk50LK8SvSERvOeWzvAbFoZ5@nongnu.org X-Gm-Message-State: AOJu0YyrTyjG6oQlOfMJnzckBGsigSUQnxev677TnTM/73PeC6NxPTny g0Bztpx+GoMjZyiGbhbz7LD33mwro6twOmmkMMTKz83H4DibLgJQrWkhRV21zX9IsrPTkHR4OTs uaJsQUUz7kL8WpEykpkN9XB/qXq1C2bAs0QCLQk77L0O9wGaWo3oMmEhE X-Gm-Gg: Acq92OEEmq90rIqdVHT8KueKTENX47SynniJeNSDX4Wjza+kIQ1xOUOViE43AjP6UUU RAtWTdoV6Ih6D1+dFB6MnhLNQLqG/brWpAvf8itJuVqbVOD3FvCOgfn8kxBhupKOxyPXpT1pJjl 8pUPdetcQT3Is3I8zoUmsHlUDZG9jQzgXRKERH5mTTSVER6FqepBW2P/J20nyitffQ96JRwcxus vvNdMeKeTOHzE3RUugggR+Ipy2sPqY1s2JMk2MmpBduePDAX4gzcQYVlVnUVZim9TeTLS5mvvgF 5GzsO0TSJMMD2kEikZiz8Ebv8RrwhuPh4/t4Dc577Sc4aqlZ6gM9b4QzjENro67ONanNwKH+Vwg sr5TF1lcbbMEkIMxnqTjoaYUUIiUy1GkNGLjqM9243+62Fnw= X-Received: by 2002:a05:6214:4886:b0:8ca:1753:90a1 with SMTP id 6a1803df08f44-8cc7b695952mr244876246d6.45.1779720305445; Mon, 25 May 2026 07:45:05 -0700 (PDT) X-Received: by 2002:a05:6214:4886:b0:8ca:1753:90a1 with SMTP id 6a1803df08f44-8cc7b695952mr244874916d6.45.1779720304707; Mon, 25 May 2026 07:45:04 -0700 (PDT) Received: from x1.local ([142.189.10.167]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-8cc812df29esm111758336d6.29.2026.05.25.07.45.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 07:45:04 -0700 (PDT) Date: Mon, 25 May 2026 10:45:02 -0400 From: Peter Xu To: Vladimir Sementsov-Ogievskiy Cc: "Michael S. Tsirkin" , jasowang@redhat.com, armbru@redhat.com, farosas@suse.de, raphael.s.norwitz@gmail.com, bchaney@akamai.com, qemu-devel@nongnu.org, berrange@redhat.com, pbonzini@redhat.com, yc-core@yandex-team.ru, Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Zhao Liu , Richard Henderson Subject: Re: [PATCH v16 5/8] virtio-net: support local migration of backend Message-ID: References: <20260522120534.77653-1-vsementsov@yandex-team.ru> <20260522120534.77653-6-vsementsov@yandex-team.ru> <20260524050632-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Received-SPF: pass client-ip=170.10.133.124; envelope-from=peterx@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -24 X-Spam_score: -2.5 X-Spam_bar: -- X-Spam_report: (-2.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.445, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H5=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Mon, May 25, 2026 at 04:51:55PM +0300, Vladimir Sementsov-Ogievskiy wrote: > On 24.05.26 12:09, Michael S. Tsirkin wrote: > > On Fri, May 22, 2026 at 03:05:30PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > > Add virtio-net option local-migration, which is true by default, > > > but false for older machine types, which doesn't support the feature. > > > > > > When both global migration parameter "local" and new virtio-net > > > parameter "local-migration" are true, virtio-net transfer the whole > > > net backend to the destination, including open file descriptors. > > > Of-course, its only for local migration and the channel must be > > > UNIX domain socket. > > > > > > This way management tool should not care about creating new TAP, and > > > should not handle switching to it. Migration downtime become shorter. > > > > > > Support for TAP will come in the next commit. > > > > > > Signed-off-by: Vladimir Sementsov-Ogievskiy > > > Reviewed-by: Ben Chaney > > > > I don't get why is this a device property? > > It's clearly a backend thing? > > > > Hmm. > > We want to be able to disable fd-migration per device, when common "local" > migration parameter is on. > > That's why we have parameter for virtio-net. It's also good, that we may > enable it by default for newer machine types, to make fd-migration a default > path. > > To be honest, it seems that the only thing in this patch (except for interface), > which is not about backand, is that we want to do virtio_net_update_host_features() > after backends incoming migration finished. For this, it's comfortable to have > backend migration as part of device migration stream. > > -- > > Imagine, we move "local-migration" parameter to TAP device. This raise a lot of questions: Hmm, I thought we discussed this quite some time ago.. I can't remember details, but I'll try to comment with what I can still remember. > > 1. We loss a possibility to set good default in machine type. Ok, we probably may add > a property to "migration" object, but this property will look like "TAP-local-migration", > and raise discussion again, that it should be property of TAP.. If you recall I worked on the other series because of this desire of having tap be able to be QOMified and also support machine compat properties: https://lore.kernel.org/all/20251209162857.857593-2-peterx@redhat.com/ I didn't get a lot of feedback supporting having TYPE_OBJECT_COMPAT, maybe it's an overkill only to apply object_apply_compat_props(). However, just to say we can still QOMify TAP and then add its own instance_post_init() to also do object_apply_compat_props(), like quite a few other existing users, then this (1) isn't a problem, and it doesn't need to depend on my series either. > > 2. We loss possiblity to use qom-set, to change the property value, as net backends are > not Qobjects.. So it will need additional tap-change qmp command or something like this. This also shouldn't be a problem if we QOMify TAP, IIUC. > > 3. Migration it self: should we register specific migration state for TAP backend (which is > not very comfortable, because net backends are not devices), or just keep it as part of > virtio-net migration state (like in this patch, but instead of checking for own local-migration > property, check for all backends local-migration properties). > > If create personal migration state for TAP backend, detached from virtio-net migration state, > we'll need somehow call virtio_net_update_host_features() _after_ all backends migrated. May > be we can do it in device start, but it's not good, as at this point any error is more critical > than during migration process.. Another option is migration state priorities, but I didn't dig > into it, and it doesn't seem as reliable as simply migrate backends as part of parent device > migration state. If this is about the "which VMSD to migrate earlier" problem, I recall we discussed about using MigrationPriority to serialize them. But I'm not sure if this is exactly the same issue. Thanks, > > -- > > What do you think? Theoretically, I can move "local-migration" property to TAP backend, but > seems, it will lead to more problems. > > > > > > > > --- > > > hw/core/machine.c | 1 + > > > hw/i386/pc_q35.c | 1 + > > > hw/net/virtio-net.c | 137 ++++++++++++++++++++++++++++++++- > > > include/hw/virtio/virtio-net.h | 2 + > > > include/net/net.h | 2 + > > > 5 files changed, 142 insertions(+), 1 deletion(-) > > > > > > diff --git a/hw/core/machine.c b/hw/core/machine.c > > > index 63baff859f3..619e80c1cb3 100644 > > > --- a/hw/core/machine.c > > > +++ b/hw/core/machine.c > > > @@ -41,6 +41,7 @@ > > > GlobalProperty hw_compat_11_0[] = { > > > { "chardev-vc", "encoding", "cp437" }, > > > + { TYPE_VIRTIO_NET, "local-migration", "false" }, > > > }; > > > const size_t hw_compat_11_0_len = G_N_ELEMENTS(hw_compat_11_0); > > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > > > index d8fed698c72..b5c0e302d59 100644 > > > --- a/hw/i386/pc_q35.c > > > +++ b/hw/i386/pc_q35.c > > > @@ -368,6 +368,7 @@ static void pc_q35_machine_options(MachineClass *m) > > > static void pc_q35_machine_11_1_options(MachineClass *m) > > > { > > > pc_q35_machine_options(m); > > > + compat_props_add(m->compat_props, hw_compat_11_0, hw_compat_11_0_len); > > > } > > > DEFINE_Q35_MACHINE_AS_LATEST(11, 1); > > > diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c > > > index 2a5d642a647..158b9247a58 100644 > > > --- a/hw/net/virtio-net.c > > > +++ b/hw/net/virtio-net.c > > > @@ -38,8 +38,10 @@ > > > #include "qapi/qapi-events-migration.h" > > > #include "hw/virtio/virtio-access.h" > > > #include "migration/misc.h" > > > +#include "migration/options.h" > > > #include "standard-headers/linux/ethtool.h" > > > #include "system/system.h" > > > +#include "system/runstate.h" > > > #include "system/replay.h" > > > #include "trace.h" > > > #include "monitor/qdev.h" > > > @@ -3060,7 +3062,17 @@ static void virtio_net_set_multiqueue(VirtIONet *n, int multiqueue) > > > n->multiqueue = multiqueue; > > > virtio_net_change_num_queues(n, max * 2 + 1); > > > - virtio_net_set_queue_pairs(n); > > > + /* > > > + * virtio_net_set_multiqueue() called from set_features(0) on early > > > + * reset, when peer may wait for incoming (and is not initialized > > > + * yet). > > > + * Don't worry about it: virtio_net_set_queue_pairs() will be called > > > + * later form virtio_net_post_load_device(), and anyway will be > > > + * noop for local incoming migration with live backend passing. > > > + */ > > > + if (!n->peers_wait_incoming) { > > > + virtio_net_set_queue_pairs(n); > > > + } > > > } > > > static int virtio_net_pre_load_queues(VirtIODevice *vdev, uint32_t n) > > > @@ -3089,6 +3101,17 @@ static void virtio_net_get_features(VirtIODevice *vdev, uint64_t *features, > > > virtio_add_feature_ex(features, VIRTIO_NET_F_MAC); > > > + if (n->peers_wait_incoming) { > > > + /* > > > + * Excessive feature set is OK for early initialization when > > > + * we wait for local incoming migration: actual guest-negotiated > > > + * features will come with migration stream anyway. And we are sure > > > + * that we support same host-features as source, because the backend > > > + * is the same (the same TAP device, for example). > > > + */ > > > + return; > > > + } > > > + > > > if (!peer_has_vnet_hdr(n)) { > > > virtio_clear_feature_ex(features, VIRTIO_NET_F_CSUM); > > > virtio_clear_feature_ex(features, VIRTIO_NET_F_HOST_TSO4); > > > @@ -3179,6 +3202,18 @@ static void virtio_net_get_features(VirtIODevice *vdev, uint64_t *features, > > > } > > > } > > > +static bool virtio_net_update_host_features(VirtIONet *n, Error **errp) > > > +{ > > > + ERRP_GUARD(); > > > + VirtIODevice *vdev = VIRTIO_DEVICE(n); > > > + > > > + peer_test_vnet_hdr(n); > > > + > > > + virtio_net_get_features(vdev, &vdev->host_features, errp); > > > + > > > + return !*errp; > > > +} > > > + > > > static int virtio_net_post_load_device(void *opaque, int version_id) > > > { > > > VirtIONet *n = opaque; > > > @@ -3300,6 +3335,9 @@ struct VirtIONetMigTmp { > > > uint16_t curr_queue_pairs_1; > > > uint8_t has_ufo; > > > uint32_t has_vnet_hdr; > > > + > > > + NetClientState *ncs; > > > + uint32_t max_queue_pairs; > > > }; > > > /* The 2nd and subsequent tx_waiting flags are loaded later than > > > @@ -3569,6 +3607,57 @@ static const VMStateDescription vhost_user_net_backend_state = { > > > } > > > }; > > > +static bool virtio_net_migrate_local(void *opaque, int version_id) > > > +{ > > > + VirtIONet *n = opaque; > > > + > > > + return migrate_local() && n->local_migration; > > > +} > > > + > > > +static int virtio_net_nic_pre_save(void *opaque) > > > +{ > > > + struct VirtIONetMigTmp *tmp = opaque; > > > + > > > + tmp->ncs = tmp->parent->nic->ncs; > > > + tmp->max_queue_pairs = tmp->parent->max_queue_pairs; > > > + > > > + return 0; > > > +} > > > + > > > +static int virtio_net_nic_pre_load(void *opaque) > > > +{ > > > + /* Reuse the pointer setup from save */ > > > + virtio_net_nic_pre_save(opaque); > > > + > > > + return 0; > > > +} > > > + > > > +static int virtio_net_nic_post_load(void *opaque, int version_id) > > > +{ > > > + struct VirtIONetMigTmp *tmp = opaque; > > > + Error *local_err = NULL; > > > + > > > + if (!virtio_net_update_host_features(tmp->parent, &local_err)) { > > > + error_report_err(local_err); > > > + return -EINVAL; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static const VMStateDescription vmstate_virtio_net_nic = { > > > + .name = "virtio-net-nic", > > > + .pre_load = virtio_net_nic_pre_load, > > > + .pre_save = virtio_net_nic_pre_save, > > > + .post_load = virtio_net_nic_post_load, > > > + .fields = (const VMStateField[]) { > > > + VMSTATE_VARRAY_UINT32(ncs, struct VirtIONetMigTmp, > > > + max_queue_pairs, 0, vmstate_net_peer_backend, > > > + NetClientState), > > > + VMSTATE_END_OF_LIST() > > > + }, > > > +}; > > > + > > > static const VMStateDescription vmstate_virtio_net_device = { > > > .name = "virtio-net-device", > > > .version_id = VIRTIO_NET_VM_VERSION, > > > @@ -3600,6 +3689,9 @@ static const VMStateDescription vmstate_virtio_net_device = { > > > * but based on the uint. > > > */ > > > VMSTATE_BUFFER_POINTER_UNSAFE(vlans, VirtIONet, 0, MAX_VLAN >> 3), > > > + VMSTATE_WITH_TMP_TEST(VirtIONet, virtio_net_migrate_local, > > > + struct VirtIONetMigTmp, > > > + vmstate_virtio_net_nic), > > > VMSTATE_WITH_TMP(VirtIONet, struct VirtIONetMigTmp, > > > vmstate_virtio_net_has_vnet), > > > VMSTATE_UINT8(mac_table.multi_overflow, VirtIONet), > > > @@ -3864,6 +3956,42 @@ static bool failover_hide_primary_device(DeviceListener *listener, > > > return qatomic_read(&n->failover_primary_hidden); > > > } > > > +static bool virtio_net_check_peers_wait_incoming(VirtIONet *n, bool *waiting, > > > + Error **errp) > > > +{ > > > + bool has_waiting = false; > > > + bool has_not_waiting = false; > > > + > > > + for (int i = 0; i < n->max_queue_pairs; i++) { > > > + NetClientState *peer = n->nic->ncs[i].peer; > > > + if (!peer) { > > > + continue; > > > + } > > > + > > > + if (peer->info->is_wait_incoming && > > > + peer->info->is_wait_incoming(peer)) { > > > + has_waiting = true; > > > + } else { > > > + has_not_waiting = true; > > > + } > > > + > > > + if (has_waiting && has_not_waiting) { > > > + error_setg(errp, "Mixed peer states: some peers wait for incoming " > > > + "migration while others don't"); > > > + return false; > > > + } > > > + } > > > + > > > + if (has_waiting && !runstate_check(RUN_STATE_INMIGRATE)) { > > > + error_setg(errp, "Peers wait for incoming, but it's not an incoming " > > > + "migration."); > > > + return false; > > > + } > > > + > > > + *waiting = has_waiting; > > > + return true; > > > +} > > > + > > > static void virtio_net_device_realize(DeviceState *dev, Error **errp) > > > { > > > VirtIODevice *vdev = VIRTIO_DEVICE(dev); > > > @@ -4001,6 +4129,12 @@ static void virtio_net_device_realize(DeviceState *dev, Error **errp) > > > n->nic->ncs[i].do_not_pad = true; > > > } > > > + if (!virtio_net_check_peers_wait_incoming(n, &n->peers_wait_incoming, > > > + errp)) { > > > + virtio_cleanup(vdev); > > > + return; > > > + } > > > + > > > peer_test_vnet_hdr(n); > > > if (peer_has_vnet_hdr(n)) { > > > n->host_hdr_len = sizeof(struct virtio_net_hdr); > > > @@ -4310,6 +4444,7 @@ static const Property virtio_net_properties[] = { > > > host_features_ex, > > > VIRTIO_NET_F_GUEST_UDP_TUNNEL_GSO_CSUM, > > > true), > > > + DEFINE_PROP_BOOL("local-migration", VirtIONet, local_migration, true), > > > }; > > > static void virtio_net_class_init(ObjectClass *klass, const void *data) > > > diff --git a/include/hw/virtio/virtio-net.h b/include/hw/virtio/virtio-net.h > > > index 371e3764282..0c14e314409 100644 > > > --- a/include/hw/virtio/virtio-net.h > > > +++ b/include/hw/virtio/virtio-net.h > > > @@ -230,6 +230,8 @@ struct VirtIONet { > > > struct EBPFRSSContext ebpf_rss; > > > uint32_t nr_ebpf_rss_fds; > > > char **ebpf_rss_fds; > > > + bool peers_wait_incoming; > > > + bool local_migration; > > > }; > > > size_t virtio_net_handle_ctrl_iov(VirtIODevice *vdev, > > > diff --git a/include/net/net.h b/include/net/net.h > > > index aa34043b1ac..d4cf399d4a8 100644 > > > --- a/include/net/net.h > > > +++ b/include/net/net.h > > > @@ -82,6 +82,7 @@ typedef void (SocketReadStateFinalize)(SocketReadState *rs); > > > typedef void (NetAnnounce)(NetClientState *); > > > typedef bool (SetSteeringEBPF)(NetClientState *, int); > > > typedef bool (NetCheckPeerType)(NetClientState *, ObjectClass *, Error **); > > > +typedef bool (IsWaitIncoming)(NetClientState *); > > > typedef struct vhost_net *(GetVHostNet)(NetClientState *nc); > > > typedef struct NetClientInfo { > > > @@ -110,6 +111,7 @@ typedef struct NetClientInfo { > > > NetAnnounce *announce; > > > SetSteeringEBPF *set_steering_ebpf; > > > NetCheckPeerType *check_peer_type; > > > + IsWaitIncoming *is_wait_incoming; > > > GetVHostNet *get_vhost_net; > > > const VMStateDescription *backend_vmsd; > > > } NetClientInfo; > > > -- > > > 2.52.0 > > > > > -- > Best regards, > Vladimir > -- Peter Xu