From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Zhiqiang Hou <Zhiqiang.Hou@nxp.com>
Cc: imx@lists.linux.dev, linux-remoteproc@vger.kernel.org,
andersson@kernel.org, Frank.Li@nxp.com, s.hauer@pengutronix.de,
festevam@gmail.com
Subject: Re: [PATCHv3] remoteproc: imx_rproc: add missing DRAM ranges for i.MX93
Date: Mon, 25 May 2026 08:52:26 -0600 [thread overview]
Message-ID: <ahRiKmwn8YdHGCyZ@p14s> (raw)
In-Reply-To: <20260525062031.24725-1-Zhiqiang.Hou@nxp.com>
On Mon, May 25, 2026 at 02:20:31PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> The M33 DRAM address ranges 0xA0000000-0xAFFFFFFF(None Secure)
s/none/non
> and 0xB0000000-0xBFFFFFFF(Secure) are both mapped to
> 0xA0000000-0xAFFFFFFF in the A55 address space.
>
So the M33 has secure and non-secure ranges mapped at the same address in the
A55? Are you sure it is not the other way around, i.e A55 has secure and
non-secure address ranges that both map to the same address on M33?
More details are needed in this changelog.
I'm also wondering how this problem hasn't been fixed before. The original
patch (9222fabf0e39) was merged over 4 years ago...
> These ranges are currently missing from the i.MX93 remoteproc
> address translation table, which may lead to invalid address
> translation for firmware accessing these regions.
>
> Add the missing mappings to complete the DRAM coverage.
>
> Fixes: 9222fabf0e39d ("remoteproc: imx_rproc: Support i.MX93")
The SHA should be 12 characters.
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> V3:
> - Added more info in the changelog.
>
> drivers/remoteproc/imx_rproc.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 7f54322244aca..175c2d3099794 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -198,6 +198,9 @@ static const struct imx_rproc_att imx_rproc_att_imx93[] = {
> { 0x80000000, 0x80000000, 0x10000000, 0 },
> { 0x90000000, 0x80000000, 0x10000000, 0 },
>
> + { 0xA0000000, 0xA0000000, 0x10000000, 0 },
> + { 0xB0000000, 0xA0000000, 0x10000000, 0 },
> +
> { 0xC0000000, 0xC0000000, 0x10000000, 0 },
> { 0xD0000000, 0xC0000000, 0x10000000, 0 },
> };
> --
> 2.43.0
>
next prev parent reply other threads:[~2026-05-25 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 6:20 [PATCHv3] remoteproc: imx_rproc: add missing DRAM ranges for i.MX93 Zhiqiang Hou
2026-05-25 6:36 ` sashiko-bot
2026-05-25 12:23 ` Peng Fan
2026-05-25 14:52 ` Mathieu Poirier [this message]
2026-05-26 3:32 ` Peng Fan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahRiKmwn8YdHGCyZ@p14s \
--to=mathieu.poirier@linaro.org \
--cc=Frank.Li@nxp.com \
--cc=Zhiqiang.Hou@nxp.com \
--cc=andersson@kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=linux-remoteproc@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.