From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC1C83988FA for ; Tue, 26 May 2026 08:08:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779782933; cv=none; b=bZ3skfxaza0Sm+NNg0niOjZkuD2LBUcrCysh8iIKAwefFL7dkR31A+hzdRdEeaJAsNRmtByrF73RfgaLw3H2Jk3pwUHB/4tm2/9v9amQmYSEABx1RY/BQi7/P5hHxNaGoJFq8M8Mb9PDDo499tQ7o/t/KKys4mYCwABCZR2LVdI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779782933; c=relaxed/simple; bh=5c8WxsUg0Onba7W3NeDZlnYxIzw3mF1J8fe9K8f4Gkw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=iCwJQQ60R29SW0VvbNRqtrCJ1D+P2M8LSX+GFyyu0YzYYzG2lYljzE06sK9oQKI4YkZR0YL+BJD7WZ+sdLRCP28TglC9DtxZAhJlrZK/1A+ly4M+s9JeiN0uNr3e2NsJj76ch6MxUNZc0tbmc9tUfjF+LJZmc5s5ofVITbAipWk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LMIbEH2r; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LMIbEH2r" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAC971F000E9; Tue, 26 May 2026 08:08:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779782932; bh=Xcp6BXaAlC+lITus8VJDTPhh6UHiAQLA547v62BZG8s=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=LMIbEH2reLxxd51Cbp1hlA09RdKNJGqfOa5DF3cBCYjYQbeBtNqL/CbR7NmqhrLfv vFbJy/+0eD0H93T5n0ne0/an/s56oPmArziDwrepwlEfy6G5ErmP4TS5k343jbTc60 xiV2cDlrIuNL+hbQZOHOEkA3NHe4Di5lZY2zx6E1WkxkqXLczfA2Te7Mw6nBKb54Bz Qtt4OHgOw9V5BNhiqSUEhj5AqdTXUSMW7+Aqxs0z7YAxcNAlSmFH+tEG2yp60KT7Ln nnph6sWZSKCL3j4upwAPCqp0yPmTjPFqiWsU5YQJsnVL2iSql41KRsIhJpHg+JDogC 8dygIlYN5f76Q== Date: Tue, 26 May 2026 09:08:47 +0100 From: Lorenzo Stoakes To: Alexander Lechthaler Cc: arnd@arndb.de, david@kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Shuah Khan Subject: Re: [PATCH] ipc/sem: fix malformed kernel-doc comment Message-ID: References: <20260522190507.97175-1-alexander@lechthaler.online> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260522190507.97175-1-alexander@lechthaler.online> +cc Jon, Shuah from documentation side On Fri, May 22, 2026 at 09:05:07PM +0200, Alexander Lechthaler wrote: > perform_atomic_semop[_slow]() uses unsupported kernel-doc syntax, > triggering a warning: > > This comment starts with '/**', but isn't a kernel-doc comment > > Split the shared comment into separate kernel-doc blocks for > perform_atomic_semop() and perform_atomic_semop_slow(). > > No functional change. > > Signed-off-by: Alexander Lechthaler This LGTM, though I wonder if that 'Returns' syntax is right. But either way seems fine so: Acked-by: Lorenzo Stoakes > --- > ipc/sem.c | 21 +++++++++++++++++++-- > 1 file changed, 19 insertions(+), 2 deletions(-) > > diff --git a/ipc/sem.c b/ipc/sem.c > index 6cdf862b1f5c..fde2bcc225dc 100644 > --- a/ipc/sem.c > +++ b/ipc/sem.c > @@ -627,8 +627,8 @@ SYSCALL_DEFINE3(semget, key_t, key, int, nsems, int, semflg) > } > > /** > - * perform_atomic_semop[_slow] - Attempt to perform semaphore > - * operations on a given array. > + * perform_atomic_semop_slow - Attempt to perform semaphore > + * operations on a given array. > * @sma: semaphore array > * @q: struct sem_queue that describes the operation > * > @@ -716,6 +716,23 @@ static int perform_atomic_semop_slow(struct sem_array *sma, struct sem_queue *q) > return result; > } > > +/** > + * perform_atomic_semop - Attempt to perform semaphore > + * operations on a given array. > + * @sma: semaphore array > + * @q: struct sem_queue that describes the operation > + * > + * Caller blocking are as follows, based the value > + * indicated by the semaphore operation (sem_op): > + * > + * (1) >0 never blocks. > + * (2) 0 (wait-for-zero operation): semval is non-zero. > + * (3) <0 attempting to decrement semval to a value smaller than zero. > + * > + * Returns 0 if the operation was possible. > + * Returns 1 if the operation is impossible, the caller must sleep. > + * Returns <0 for error codes. > + */ > static int perform_atomic_semop(struct sem_array *sma, struct sem_queue *q) > { > int result, sem_op, nsops; > -- > 2.43.0 >