From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f47.google.com (mail-wm1-f47.google.com [209.85.128.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 486A63DD86E for ; Tue, 26 May 2026 13:27:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779802077; cv=none; b=JTSt0kPCffUE9kw49M//OqZhVR/oj+6GxmiHDspt9/9VXsE3/31rwj0f9wj4DS2Vvie07jBTlssv6IwRgejadMIc8PLec0JEg63y5dRf5iA/EXqNmK+BatDhqU/63BawRo5CM12Wr1p/ItSsAi/SViMcE2WHhZ6v/zvkHdTggHU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779802077; c=relaxed/simple; bh=AF9tJ1amhlOtaGqlNAAzlZV5h8kKDyKt4veK2cMLXSI=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=STfTFQqD922Rl21M4nFi8zF+B8q9PWYUHQyf6OEM0wlxW6tl5Ff1/MtTqcdiqaLHIJZN2C0hYq25X781kZP+Pa8ytMri6fGl96FYHWVCXTtGPgbn+ne4aiOlcZNPmWr3g7GAEPLTRDCQGjwg6ssyfy6/RSUz8DtP3/fOYEINQ1w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us; spf=none smtp.mailfrom=resnulli.us; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b=HBaRLyxj; arc=none smtp.client-ip=209.85.128.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=resnulli.us Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=resnulli.us Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.b="HBaRLyxj" Received: by mail-wm1-f47.google.com with SMTP id 5b1f17b1804b1-48a3e9862f0so56144595e9.1 for ; Tue, 26 May 2026 06:27:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1779802074; x=1780406874; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AF9tJ1amhlOtaGqlNAAzlZV5h8kKDyKt4veK2cMLXSI=; b=HBaRLyxjsk7oX4LbiLb9W999vqrijrauxMeckZV0VurpePTiRVimPMI07awDRiEsRC 0XctatJoPWKkufRNLwIfApuji12tyL5KUL4xzCooR5JHAxzxMlSvAdGYipjN1n360Clm fQ6FiucmsJvMepzIivy6ZXYsE4DSMa3kR+6FEE8hlSMs3/J52Uaq6f2tZxpZCtceczka vbo0aooDPZ2+adfF1CpmfKy+38ns5Aj9DRHZFkNh288y+b4sewpCIHI1A/FRKmAc/VVP Bu+Xm5PKnRXaqoSRsWCB2QSmneLMKwBWPfX0J0GfGu03KeL/sQNF0ACs5C/TQ7g4t8kG H8SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779802074; x=1780406874; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AF9tJ1amhlOtaGqlNAAzlZV5h8kKDyKt4veK2cMLXSI=; b=DJhehzMAo5sROvBk9WjC1k2ydj7M+oq4jW1ZH1ua4VZywJ41u8bZ6r5tg5p6FGZmRr PNf9wnD2vThCQCpKtMcaolv0kBZr7VsNWAPGaoopscwAzOQR01V/Ma6UiB/ohPm7EDp3 yUc1jxTMGZcJIzno3emDJoMUZvSkkhf4aSdA56xlUwombpk/ivqEB2Yg9U0gSrLP5XXI 914Nxyq+wZNv28IsPW5Ueg9K+kAFVvk6xunQ4PharzyyjPb7NkCR/afAoCKW7fr/mMuA hjKPnTvMMWjZrd1XE544PzqVt4E/ggJ9YLui5e/cW9pdN1M8dqNA5SPv03JwpyK/iKnN VS6g== X-Gm-Message-State: AOJu0Yz9AZcD/OdiDEAf7NML1rprjxdKnca0gmykxzsOFBE07ua0fTiy zvAc7J8L9YW1QkrU8lzUiah1DCGvWFamPAy+aEz+DFbbihPavFALo9WFErtPYQuruIY= X-Gm-Gg: Acq92OE9DHeCX1gutSxYjtg4OdgSlgZ/CMwLgAcnr44J34d64kVk48p9tiYeFfd+lLT yNNEZGoLYsvc6BNVitor5g1638z3VG6q+2cRtrFAAz4RC13jBAKpEbixvBpYGbDQP5W+PUJCbgF r9NPDH5MF8xk4iuLfhDCIMjeQI03herlKBr0Eq1tzYv2rj+epMohbLvDb/ea2B+2nbvZs9Hs6aP sBgYeX0ssjxuyImG/ztzbii+7toHZyeW0e3kMMXc4REnrDEyT8k38V91fCLiNOrdJU2Ka/enhxM f6atwO3HBqx75Wr9td/FSBlD6/0wnfQgvuakib0CbGmAlrpY4C+D8o4ghvdbrBgs0vR49macuf2 IskPOsJWH01S240PmMODKBqOA/ulC9YvK2tl93wL1OXcSyUUkf2RzIcP2F+E/fsAaw8Ub2fY2Qb jsHYySH+CF5BMzHm8/3Omu+NR9FGjbYqz19A4Rr2J2Bv0= X-Received: by 2002:a05:600d:4448:20b0:48f:d620:c27f with SMTP id 5b1f17b1804b1-490422687c3mr189986545e9.4.1779802073553; Tue, 26 May 2026 06:27:53 -0700 (PDT) Received: from localhost ([140.209.217.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49045284855sm330056955e9.0.2026.05.26.06.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 06:27:53 -0700 (PDT) Date: Tue, 26 May 2026 15:27:49 +0200 From: Jiri Pirko To: Grzegorz Nitka Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, intel-wired-lan@lists.osuosl.org, poros@redhat.com, richardcochran@gmail.com, andrew+netdev@lunn.ch, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, Prathosh.Satish@microchip.com, ivecera@redhat.com, arkadiusz.kubalewski@intel.com, vadim.fedorenko@linux.dev, donald.hunter@gmail.com, horms@kernel.org, pabeni@redhat.com, kuba@kernel.org, davem@davemloft.net, edumazet@google.com, Aleksandr Loktionov Subject: Re: [PATCH v11 net-next 4/8] dpll: allow fwnode pins to attempt state change without capability bit Message-ID: References: <20260526093419.639220-1-grzegorz.nitka@intel.com> <20260526093419.639220-5-grzegorz.nitka@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526093419.639220-5-grzegorz.nitka@intel.com> Tue, May 26, 2026 at 11:34:15AM +0200, grzegorz.nitka@intel.com wrote: >Pins registered with an fwnode may have .state_on_dpll_set implemented >without advertising DPLL_PIN_CAPABILITIES_STATE_CAN_CHANGE upfront. >Requiring the bit for fwnode pins ties firmware description to driver >implementation details unnecessarily. > >Relax the capability check in dpll_pin_state_set() and >dpll_pin_on_pin_state_set(): when a pin has an associated fwnode, bypass >the capability gate and let the ops layer decide, returning -EOPNOTSUPP >if .state_on_dpll_set is absent. Non-fwnode pins retain the original >strict behavior. > >This is used later in the series by the SyncE_Ref output pin, which >relies on the fwnode path for state control. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Grzegorz Nitka Reviewed-by: Jiri Pirko From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E87C8CD5BC8 for ; Tue, 26 May 2026 13:28:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id ACD2940FED; Tue, 26 May 2026 13:28:01 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id qoj7rUffhMGO; Tue, 26 May 2026 13:28:00 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.142; helo=lists1.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 0F4C440FE3 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1779802080; bh=AF9tJ1amhlOtaGqlNAAzlZV5h8kKDyKt4veK2cMLXSI=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=yk4crW2HwduDCt8PeDpp19o1aZt4/3RMkGlqyuKJApIncT92oCE8dfhCEEsIyAFwy NVF+5ZCaxB1Hy7BJZedjB+6+tr4ROW8d/l87UemFzBZPCMMg9CoK1KhSuW0SULcz2N 5gOzQklAIE5/rARXhN9pp4l/QlI/7JUgsbbh3qF6MXtNpED/uX7jarRsVlARQyRBP+ 4FybVHRd4VrTa1C5MQD5Domzi8Z429EJj2H7PBqTCP2+/NAV8KM0pbltMlqOMlxeP6 I8mOFYODytG9cnIaL46GbpmSxDyYOT+OB44q2k/DvCxQOOvTWWBx1/4ZiPhyfiVl26 Q9PkmSckGwFZA== Received: from lists1.osuosl.org (lists1.osuosl.org [140.211.166.142]) by smtp4.osuosl.org (Postfix) with ESMTP id 0F4C440FE3; Tue, 26 May 2026 13:28:00 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists1.osuosl.org (Postfix) with ESMTP id D3271297 for ; Tue, 26 May 2026 13:27:57 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id B857C40885 for ; Tue, 26 May 2026 13:27:57 +0000 (UTC) X-Virus-Scanned: amavis at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavis, port 10024) with ESMTP id BtUyfJM3ieDK for ; Tue, 26 May 2026 13:27:57 +0000 (UTC) Received-SPF: None (mailfrom) identity=mailfrom; client-ip=2a00:1450:4864:20::32b; helo=mail-wm1-x32b.google.com; envelope-from=jiri@resnulli.us; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 187B64087B DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 187B64087B Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by smtp2.osuosl.org (Postfix) with ESMTPS id 187B64087B for ; Tue, 26 May 2026 13:27:55 +0000 (UTC) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-49041e84237so34237485e9.1 for ; Tue, 26 May 2026 06:27:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779802074; x=1780406874; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AF9tJ1amhlOtaGqlNAAzlZV5h8kKDyKt4veK2cMLXSI=; b=QRjTUoo1PVPXr5bpBqEYd3U3g+ZlJHuDY4lKje498/5ar7eLX0wfOfFz9Gp57P3cK0 JBVyDQkSpuD2GTt9IXLbH18XteU+MaUSUkECeot+C8msFALMmxFdr0hYADvWsdNubQ5r CuMoXaF5FLZ2NEhELqozB0trlet3vW/52+BjYas0btBoUaFxzFlIbF/0zsDQULgknFse 6hmhpZAqlhc/kKpfTCtwAZDwXDc0NXhGreLGxbvUt8nVa7bY/aRM9x0tiqoJvq+j/ZU/ wj6XbayPdRFQjIuuf6949YGCLSQDZ3aPWqF4f345DoO1O9vGqCaQqBmNLHI4pDBjp7R/ EIkQ== X-Forwarded-Encrypted: i=1; AFNElJ/Md/jBigDsqCyjzx7drcbY60Kf9NfN5Y7pI1tCA6SNlpZ+m3RheRL6qGWkzuSrHoKa2sW/+/yYr7OAT/0MBDk=@lists.osuosl.org X-Gm-Message-State: AOJu0YxrUgwSoIkAeX6hvj/NCOIjFjfXBLkS3/aQVd7z4AW6C8LoMKz/ bWhP+50lhPzFhOKs41b0/4GeBwhnnPUbrNXkj/8SOqG2pmmp4KMV6l68h9YIxci8CPk= X-Gm-Gg: Acq92OF1LTKiplGebTX4N+vJSucCMUC10SLAd2Caigbuzkad35x90s6+rID3ktT7YSa +oldDigrdaZiUuD2A9UYPTdmHqMvVk7eUP5Yi26E/6xiO1XIde8fkEE6+kfntmT+pHhkRJeWXZd Oqr0qvvoxG6ok8j5/bDKR9UcHZAoRAKzg+9bY7YUhaBERNLMOCZCknePSTZT95aiorlvdkdzlli UWr5hut6jHsAwGeJOxkpenOb33L/vKlOiLq8gkUMTmsIp23PRhN3JbqZBRp/nr4+KClie3QvVna pR8hKaR1SvQrZg5Fj3Qs/MCJjeVdn/jYosTFDX6OpAntdNIKN12gc/DZIHnspY+KKqXD5KhYiAa Ad8hQRfVElsGfTptYiDH4LFARIg38UtkfPMyi45dtWr5C2QZsUGLG8sbTN3efgrlOIcrvZQG/w1 MFJvLrrYj+ud1nNv6h9EC9x4dhI3IxvHJbQyA9ITysRLU= X-Received: by 2002:a05:600d:4448:20b0:48f:d620:c27f with SMTP id 5b1f17b1804b1-490422687c3mr189986545e9.4.1779802073553; Tue, 26 May 2026 06:27:53 -0700 (PDT) Received: from localhost ([140.209.217.212]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49045284855sm330056955e9.0.2026.05.26.06.27.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 May 2026 06:27:53 -0700 (PDT) Date: Tue, 26 May 2026 15:27:49 +0200 From: Jiri Pirko To: Grzegorz Nitka Message-ID: References: <20260526093419.639220-1-grzegorz.nitka@intel.com> <20260526093419.639220-5-grzegorz.nitka@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260526093419.639220-5-grzegorz.nitka@intel.com> X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=resnulli-us.20251104.gappssmtp.com; s=20251104; t=1779802074; x=1780406874; darn=lists.osuosl.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=AF9tJ1amhlOtaGqlNAAzlZV5h8kKDyKt4veK2cMLXSI=; b=bk8eIfmpzpxHcvRaBiZBagZlgKFHX20sIxNrAu6bAoLwDYBbmNGFmm9FXKKzyteX0w OVZoWlxGx3aimxTLdCVeT6SIoQgkdxalliWaspE8SjDTnNgGnAniPYzpejOaZrYNp88m zV+pFHJkJv94WPiudUE/yh21WWHmMzOR3/AKelR68r8CG8oN5Yf4suoLTyselR+N7F2C hNbshC6PLUQnQUNbidbpbIsQ9Vz3rAl/940kkxy7kTprfJTJCzNDuJshMUFfg6wDFZFv 6e2UTkCYqtbwrJxXqYaD5I3EO2AAlzvPcj4aUKyVUGq6Gh8kGMOoaOIOwb1YecLXvka+ lMDw== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=resnulli.us X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key, unprotected) header.d=resnulli-us.20251104.gappssmtp.com header.i=@resnulli-us.20251104.gappssmtp.com header.a=rsa-sha256 header.s=20251104 header.b=bk8eIfmp Subject: Re: [Intel-wired-lan] [PATCH v11 net-next 4/8] dpll: allow fwnode pins to attempt state change without capability bit X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ivecera@redhat.com, Aleksandr Loktionov , kuba@kernel.org, vadim.fedorenko@linux.dev, edumazet@google.com, netdev@vger.kernel.org, richardcochran@gmail.com, donald.hunter@gmail.com, linux-kernel@vger.kernel.org, arkadiusz.kubalewski@intel.com, Prathosh.Satish@microchip.com, andrew+netdev@lunn.ch, intel-wired-lan@lists.osuosl.org, horms@kernel.org, przemyslaw.kitszel@intel.com, anthony.l.nguyen@intel.com, pabeni@redhat.com, davem@davemloft.net Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" Tue, May 26, 2026 at 11:34:15AM +0200, grzegorz.nitka@intel.com wrote: >Pins registered with an fwnode may have .state_on_dpll_set implemented >without advertising DPLL_PIN_CAPABILITIES_STATE_CAN_CHANGE upfront. >Requiring the bit for fwnode pins ties firmware description to driver >implementation details unnecessarily. > >Relax the capability check in dpll_pin_state_set() and >dpll_pin_on_pin_state_set(): when a pin has an associated fwnode, bypass >the capability gate and let the ops layer decide, returning -EOPNOTSUPP >if .state_on_dpll_set is absent. Non-fwnode pins retain the original >strict behavior. > >This is used later in the series by the SyncE_Ref output pin, which >relies on the fwnode path for state control. > >Reviewed-by: Aleksandr Loktionov >Signed-off-by: Grzegorz Nitka Reviewed-by: Jiri Pirko