From: Keith Busch <kbusch@kernel.org>
To: Mike Bommarito <michael.bommarito@gmail.com>
Cc: Jens Axboe <axboe@kernel.dk>, Christoph Hellwig <hch@lst.de>,
Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] nvme: log when APST skips a state due to latency cap
Date: Tue, 26 May 2026 07:47:04 -0600 [thread overview]
Message-ID: <ahWkWI5yvuFj232G@kbusch-mbp> (raw)
In-Reply-To: <20260523114552.101452-1-michael.bommarito@gmail.com>
On Sat, May 23, 2026 at 07:45:52AM -0400, Mike Bommarito wrote:
> Add a dev_info_once() at the skip site that names the state, prints
> the actual exit_lat versus the current cap, and points the user at
> the module parameter to raise it. Using _once keeps the line to a
> single instance per controller; users that want to see every probe
> event can still enable dev_dbg.
The "_once" is not actually once for each controller; it's just once.
Some people have found other similar debug prints to be confusing when
they have multiple controllers since it looks like the seemingly
problematic controller is not consistent across reboots.
next prev parent reply other threads:[~2026-05-26 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-23 11:45 [PATCH] nvme: log when APST skips a state due to latency cap Mike Bommarito
2026-05-25 5:59 ` Christoph Hellwig
2026-05-25 9:24 ` Michael Bommarito
2026-05-26 13:47 ` Keith Busch [this message]
2026-05-26 13:53 ` Michael Bommarito
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahWkWI5yvuFj232G@kbusch-mbp \
--to=kbusch@kernel.org \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=michael.bommarito@gmail.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.