All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@kernel.org>
To: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>
Cc: linux-nvme@lists.infradead.org, Jens Axboe <axboe@kernel.dk>,
	Christoph Hellwig <hch@infradead.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [PATCH 0/2] nvme-tcp: lockdep: use dynamic lockdep keys per socket instance
Date: Wed, 3 Jun 2026 10:44:39 +0100	[thread overview]
Message-ID: <ah_3h7cIS8e6QTdT@kbusch-mbp> (raw)
In-Reply-To: <20260530052045.296749-1-shinichiro.kawasaki@wdc.com>

On Sat, May 30, 2026 at 02:20:43PM +0900, Shin'ichiro Kawasaki wrote:
> When NVMe-TCP controller setup and teardown are repeated with lockdep
> enabled, lockdep reports false-positive WARNs. This was observed when
> running blktests nvme/005 on v7.1-rc1 with a patch [1]. Analysis by
> Nilay [2] confirmed that the WARNs are false positives caused by lockdep
> confusing different socket instances due to shared static lockdep keys.
> 
> This series resolves the issue by using dynamically allocated lockdep
> keys per socket instance instead of static keys. This ensures lockdep
> correctly tracks locks across different socket instances. For that
> purpose, the first patch moves a function as preparation. The second
> patch introduces the dynamic lockdep keys.
> 
> [1] https://lore.kernel.org/linux-nvme/afB5syZbUrppgsDQ@shinmob/
> [2] https://lore.kernel.org/linux-nvme/c4ddc101-184a-4e4f-82ca-c3123bce5e34@linux.ibm.com/
> 
> Shin'ichiro Kawasaki (2):
>   nvme-tcp: move nvme_tcp_reclassify_socket()
>   nvme-tcp: lockdep: use dynamic lockdep keys per socket instance

Thanks, patch 1 is applied. Please have a look at my comment on patch 2
and let me know if we need to respin that version for it.


  parent reply	other threads:[~2026-06-03  9:44 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30  5:20 [PATCH 0/2] nvme-tcp: lockdep: use dynamic lockdep keys per socket instance Shin'ichiro Kawasaki
2026-05-30  5:20 ` [PATCH 1/2] nvme-tcp: move nvme_tcp_reclassify_socket() Shin'ichiro Kawasaki
2026-05-31 15:21   ` Nilay Shroff
2026-06-01  7:06   ` Christoph Hellwig
2026-05-30  5:20 ` [PATCH 2/2] nvme-tcp: lockdep: use dynamic lockdep keys per socket instance Shin'ichiro Kawasaki
2026-05-31 15:22   ` Nilay Shroff
2026-06-01  7:06   ` Christoph Hellwig
2026-06-02 10:13   ` Keith Busch
2026-06-03 11:00     ` Shin'ichiro Kawasaki
2026-06-03  9:44 ` Keith Busch [this message]
2026-06-03 11:01   ` [PATCH 0/2] " Shin'ichiro Kawasaki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah_3h7cIS8e6QTdT@kbusch-mbp \
    --to=kbusch@kernel.org \
    --cc=axboe@kernel.dk \
    --cc=hch@infradead.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=nilay@linux.ibm.com \
    --cc=sagi@grimberg.me \
    --cc=shinichiro.kawasaki@wdc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.