From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: Chuck Lever <chuck.lever@oracle.com>,
Jeff Layton <jlayton@kernel.org>,
linux-nfs@vger.kernel.org, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH v2 1/2] nfsd: Replace open-coded conversion of bytes to hex
Date: Wed, 3 Jun 2026 10:19:23 +0200 [thread overview]
Message-ID: <ah_jizDKdRuVrniB@black.igk.intel.com> (raw)
In-Reply-To: <20250804224701.2278773-2-ebiggers@kernel.org>
On Mon, Aug 04, 2025 at 10:46:59PM +0000, Eric Biggers wrote:
> Since the Linux kernel's sprintf() has conversion to hex built-in via
> "%*phN", delete md5_to_hex() and just use that. Also add an explicit
> array bound to the dname parameter of nfs4_make_rec_clidname() to make
> its size clear. No functional change.
...
> + sprintf(dname, "%*phN", 16, cksum.data);
FWIW, since the length is static no need to use stack for that:
sprintf(dname, "%16phN", cksum.data);
will be better.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-06-03 8:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 22:46 [PATCH v2 0/2] nfsd: Clean up nfs4_make_rec_clidname() Eric Biggers
2025-08-04 22:46 ` [PATCH v2 1/2] nfsd: Replace open-coded conversion of bytes to hex Eric Biggers
2026-06-03 8:19 ` Andy Shevchenko [this message]
2025-08-04 22:47 ` [PATCH v2 2/2] nfsd: Eliminate an allocation in nfs4_make_rec_clidname() Eric Biggers
2025-08-05 14:29 ` Jeff Layton
2025-08-05 14:24 ` [PATCH v2 0/2] nfsd: Clean up nfs4_make_rec_clidname() Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ah_jizDKdRuVrniB@black.igk.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=ebiggers@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.