All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <cassel@kernel.org>
To: Han Gao <rabenda.cn@gmail.com>
Cc: Chen Wang <unicorn_wang@outlook.com>,
	Michael Orlitzky <michael@orlitzky.com>,
	sophgo@lists.linux.dev, Inochi Amaoto <inochiama@outlook.com>,
	Han Gao <gaohan@iscas.ac.cn>,
	zhengjingkun@iscas.ac.cn, linux-ide@vger.kernel.org,
	dlemoal@kernel.org
Subject: Re: SG2042 SATA (DMA?) issues
Date: Wed, 3 Jun 2026 11:14:00 +0200	[thread overview]
Message-ID: <ah_wWLBK5OqBCFH1@ryzen> (raw)
In-Reply-To: <CAAT7Ki_=jGo1jbSBWmr-dQHT2pFovL2LAjcW0SN9F0Xm-uLkRg@mail.gmail.com>

Hello Han,

On Tue, Jun 02, 2026 at 08:19:32PM +0800, Han Gao wrote:
> Hi, Michael
> 
> Based on the new firmware with DMA coherence, we tested the following cases.
> 
> Test method:
> mkfs.btrfs /dev/sda1
> mount /dev/sda1 /mnt
> f3write -e 128 /mnt
> sync
> f3read /mnt
> 
> case1:
> 2042pcie - asm2824 - jmb585: failed, csum failed.
> case2:
> 2042pcie - amd b650 bridge(prom 21) - asm1062: pass.
> case3:
> 2042pcie - asm2824 - amd b650 bridge(prom 21) - asm1062: pass
> case4:
> 2042pcie - asm2824 - jmb585 + kernel parameter libata.force=noncq: pass
> 
> Based on the test results of the above four cases,
> the problem is suspected to lie in the JMB585 chip itself.

+linux-ide

Original thread:
https://lore.kernel.org/sophgo/ahu57vcS0oOFmCI9@mertle/


I interpret this as, before you added 'dma-coherent' to your PCIe controller
device tree node:

Sophgo SG2042 PCIe + ASM2824 + JMB585
worked fine, without any libata.force=noncq kernel parameter which disables NCQ.


After adding 'dma-coherent' to your PCIe controller device tree node:
Sophgo SG2042 PCIe + ASM2824 + JMB585
no longer works fine, and you need to disable NCQ to not get filesystem
corruption.


If this was a problem with the JMB585 chip, why did it work fine to run with NCQ
enabled before you did firmware changes + added 'dma-coherent' to your PCIe
controller device tree node?

Disabling NCQ will significantly reduce the drive performance.


Kind regards,
Niklas

      parent reply	other threads:[~2026-06-03  9:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31  4:32 SG2042 SATA (DMA?) issues Michael Orlitzky
2026-05-31 15:05 ` Michael Orlitzky
2026-06-01  0:31   ` Chen Wang
2026-06-01  2:22     ` Michael Orlitzky
2026-06-01  6:06       ` Chen Wang
2026-06-01  6:47         ` Michael Orlitzky
2026-06-01  8:00           ` Chen Wang
2026-06-01  8:12             ` Michael Orlitzky
2026-06-02 12:19             ` Han Gao
2026-06-02 19:20               ` Michael Orlitzky
2026-06-03  9:14               ` Niklas Cassel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ah_wWLBK5OqBCFH1@ryzen \
    --to=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=gaohan@iscas.ac.cn \
    --cc=inochiama@outlook.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=michael@orlitzky.com \
    --cc=rabenda.cn@gmail.com \
    --cc=sophgo@lists.linux.dev \
    --cc=unicorn_wang@outlook.com \
    --cc=zhengjingkun@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.