All of lore.kernel.org
 help / color / mirror / Atom feed
From: Antony Antony <antony@phenome.org>
To: kuba@kernel.org
Cc: steffen.klassert@secunet.com, netdev@vger.kernel.org
Subject: nipa: tree selection fails for ipsec-next series?
Date: Wed, 27 May 2026 11:05:43 +0200	[thread overview]
Message-ID: <ahaz550I55ZvMRDI@Antony2201.local> (raw)

Hi Jakub,

nipa run, 1101209,  failed tree selection for my v9 series and I wanted to 
share what I found while diagnosing it. I feel this happens on patches, ipsec-next,  
too.  In the past, I ignored it. Since this patch set is  long series I 
looked deeper.

https://patchwork.kernel.org/project/netdevbpf/patch/migrate-state-v9-16-ad9947e4ae74@secunet.com/
"Guessing tree name failed - patch did not apply"

Looking at the nipa source, series_tree_name_direct() matches the cover
letter subject against _trees.keys(). Since ipsec and ipsec-next are not
in the deployed conf_trees, the match fails and nipa falls back to
guessing against net-next. I am guessing ipsec-next is missing in the config too.
Where is the config nipa runs use? I didn't find the exact config nipa bot 
used.

I also noticed that my v8 (series 1089594) was identified as
net-next — it applied to net-next at the time, which masked the issue.
v9 no longer applies to net-next, so the guessing failed visibly this
time. 

https://patchwork.kernel.org/project/netdevbpf/patch/migrate-state-v8-14-4578fb016965@secunet.com/

Any idea what could be improved? Is it because the e-mails arrive out or 
order?

Would it make sense to add ipsec and ipsec-next to nipa's [trees] config?
That way series_tree_name_direct() could match them directly from the
cover letter subject rather than falling through to guessing.

Thanks,
Antony

             reply	other threads:[~2026-05-27  9:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  9:05 Antony Antony [this message]
2026-05-27 22:36 ` nipa: tree selection fails for ipsec-next series? Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahaz550I55ZvMRDI@Antony2201.local \
    --to=antony@phenome.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.