All of lore.kernel.org
 help / color / mirror / Atom feed
From: dmukhin@ford.com
To: Simon Glass <sjg@chromium.org>
Cc: dmukhin@ford.com, u-boot@lists.denx.de
Subject: Re: [v1,0/4] reset: add board reset type
Date: Wed, 27 May 2026 12:59:08 -0700	[thread overview]
Message-ID: <ahdNDJE1rFD9acyo@kraken> (raw)
In-Reply-To: <CAFLszTiwegtmhcSzy8xg5KKc1JcjeoYwsav_Tb7+9o9Hy+aY9A@mail.gmail.com>

On Mon, May 25, 2026 at 09:25:13AM -0600, Simon Glass wrote:
> Hi Denis,
> 
> On 2026-05-22T01:23:09, None <dmukhin@ford.com> wrote:
> 
> > Patch 1 allows per-board default reset override.
> > Patch 2 adds reset -c support to explicitly trigger cold reset.
> > Patch 3 adds reset type printout on the console.
> > Patch 4 introduces a small fixup for the x86 reset driver.
> 
> Since you are adding new behaviour, I would expect a sandbox test to
> go with it. The sysreset sandbox driver should make this
> straightforward - what do you think?

Will add tests, thanks!

> 
> Also, prefer board_sysreset_default() only as a last resort - could
> this be a DT property on the sysreset device, or a uclass-platdata
> field, or a syscon driver, so it doesn't need a board hook, or even in
> extremis an event? Weak functions are awkward to discover and don't
> compose well.

I think to cover our peculiar board, Kconfig option should be the cleanest
way to parameterize the build.

> 
> Regards,
> Simon

      reply	other threads:[~2026-05-27 19:59 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22  1:23 [PATCH v1 0/4] reset: add board reset type dmukhin
2026-05-22  1:23 ` [PATCH v1 1/4] reset: Allow per-board " dmukhin
2026-05-25 15:28   ` Simon Glass
2026-05-27 19:56     ` dmukhin
2026-05-22  1:23 ` [PATCH v1 2/4] reset: Add explicit cold reset support dmukhin
2026-05-25 15:19   ` Simon Glass
2026-05-22  1:23 ` [PATCH v1 3/4] reset: Print reset type on diagnostic console dmukhin
2026-05-25 15:20   ` Simon Glass
2026-05-22  1:23 ` [PATCH v1 4/4] reset: x86: Use cpu_hlt() in pch_sysreset_power_off() dmukhin
2026-05-25 15:23   ` Simon Glass
2026-05-25 15:25 ` [v1,0/4] reset: add board reset type Simon Glass
2026-05-27 19:59   ` dmukhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahdNDJE1rFD9acyo@kraken \
    --to=dmukhin@ford.com \
    --cc=sjg@chromium.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.