All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <tom.leiming@gmail.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Jens Axboe <axboe@kernel.dk>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>,
	Bart Van Assche <bvanassche@acm.org>,
	Caleb Sander Mateos <csander@purestorage.com>,
	linux-block@vger.kernel.org, linux-nvme@lists.infradead.org
Subject: Re: [PATCH 3/3] bvec: make the bvec_iter helpers inline functions
Date: Wed, 27 May 2026 22:41:11 -0500	[thread overview]
Message-ID: <ahe5V8u0lKx8IOwF@fedora> (raw)
In-Reply-To: <20260527151043.2349900-4-hch@lst.de>

On Wed, May 27, 2026 at 05:10:22PM +0200, Christoph Hellwig wrote:
> The macros are impossible to follow due to the lack of visual type
> information and all the braces.  Replace them with inline helpers to
> improve on that.  Because the calling conventions are a bit problematic
> with a lot of passing structures by value, all the helpers are marked
> as __always_inline so that they are force inlined.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>

Reviewed-by: Ming Lei <tom.leiming@gmail.com>

Thanks,
Ming


  parent reply	other threads:[~2026-05-28  3:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27 15:10 clean up bvec iter helpers Christoph Hellwig
2026-05-27 15:10 ` [PATCH 1/3] loop: cleanup lo_rw_aio Christoph Hellwig
2026-05-27 15:20   ` Keith Busch
2026-05-27 16:50   ` Chaitanya Kulkarni
2026-05-28  3:32   ` Ming Lei
2026-05-27 15:10 ` [PATCH 2/3] nvme-tcp: cleanup nvme_tcp_init_iter Christoph Hellwig
2026-05-27 15:20   ` Keith Busch
2026-05-27 16:51   ` Chaitanya Kulkarni
2026-05-28  3:39   ` Ming Lei
2026-05-27 15:10 ` [PATCH 3/3] bvec: make the bvec_iter helpers inline functions Christoph Hellwig
2026-05-27 15:21   ` Keith Busch
2026-05-27 16:51   ` Chaitanya Kulkarni
2026-05-28  3:41   ` Ming Lei [this message]
2026-05-28 14:01 ` clean up bvec iter helpers Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahe5V8u0lKx8IOwF@fedora \
    --to=tom.leiming@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=csander@purestorage.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.