From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>, netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2] scanner: Accept all statements' first words in all scopes
Date: Thu, 28 May 2026 09:46:50 +0200 [thread overview]
Message-ID: <ahfy6vvK8dhvBig-@strlen.de> (raw)
In-Reply-To: <20260508111538.3783172-1-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> To fix for token lookahead with exclusive start conditions, we must
> accept all keywords which may immediately follow the exclusive scope in
> that scope as well. This affects basically the first word of every
> statement which may follow a limit statement.
>
> Add a test case to make sure things stay that way. A few quirks exist
> though:
> - xt statement would need special testing since having it in a rule is
> supposed to fail the command
> - The parser formally accepts nonsensical things like strings, numbers
> and variable references on LHS, but these seem to be needed for the
> data part in map elements only
>
> Suggested-by: Florian Westphal <fw@strlen.de>
> Fixes: 9d105581b5f1b ("scanner: Introduce SCANSTATE_RATE")
> Signed-off-by: Phil Sutter <phil@nwl.cc>
Is there anything missing here or were you waiting for a formal ack?
Acked-by: Florian Westphal <fw@strlen.de>
next prev parent reply other threads:[~2026-05-28 7:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 11:15 [nft PATCH v2] scanner: Accept all statements' first words in all scopes Phil Sutter
2026-05-28 7:46 ` Florian Westphal [this message]
2026-05-28 11:35 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ahfy6vvK8dhvBig-@strlen.de \
--to=fw@strlen.de \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.