All of lore.kernel.org
 help / color / mirror / Atom feed
From: Raag Jadav <raag.jadav@intel.com>
To: Riana Tauro <riana.tauro@intel.com>
Cc: intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com,
	rodrigo.vivi@intel.com, aravind.iddamsetty@linux.intel.com,
	badal.nilawar@intel.com, ravi.kishore.koppuravuri@intel.com,
	mallesh.koujalagi@intel.com, soham.purkait@intel.com
Subject: Re: [PATCH v7 3/6] drm/xe/xe_ras: Add support to clear error counter
Date: Thu, 28 May 2026 11:29:05 +0200	[thread overview]
Message-ID: <ahgK4dvEKdSWnN7e@black.igk.intel.com> (raw)
In-Reply-To: <20260527060241.3351323-11-riana.tauro@intel.com>

On Wed, May 27, 2026 at 11:32:45AM +0530, Riana Tauro wrote:
> Add structures and helper function to clear error counter value.

...

> +	ret = ras_status_to_errno(response.status);
> +	if (ret) {
> +		xe_err(xe, "sysctrl: clear counter command failed with status %u, err %d\n",

'%#x' specifier for status, it comes from the hardware. Also, I think
err is redundant here since it's just our interpretation of status (which
is already present) and it doesn't really help debug anything.

> +		       response.status, ret);
> +		return ret;
> +	}

Reviewed-by: Raag Jadav <raag.jadav@intel.com>

  reply	other threads:[~2026-05-28  9:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-27  6:02 [PATCH v7 0/6] Add get-error-counter and clear-error-counter support for CRI Riana Tauro
2026-05-27  5:34 ` ✗ CI.checkpatch: warning for Add get-error-counter and clear-error-counter support for CRI (rev6) Patchwork
2026-05-27  5:36 ` ✓ CI.KUnit: success " Patchwork
2026-05-27  6:02 ` [PATCH v7 1/6] drm/xe/uapi: Add additional error components to xe drm_ras Riana Tauro
2026-05-27 15:44   ` Rodrigo Vivi
2026-05-27  6:02 ` [PATCH v7 2/6] drm/xe/xe_ras: Add support to get error counter in CRI Riana Tauro
2026-05-28  9:01   ` Raag Jadav
2026-05-27  6:02 ` [PATCH v7 3/6] drm/xe/xe_ras: Add support to clear error counter Riana Tauro
2026-05-28  9:29   ` Raag Jadav [this message]
2026-05-28  9:39     ` Raag Jadav
2026-05-27  6:02 ` [PATCH v7 4/6] drm/xe/xe_drm_ras: Wire get/clear counter callbacks Riana Tauro
2026-05-27  6:02 ` [PATCH v7 5/6] drm/xe: Move xe drm_ras initialization Riana Tauro
2026-05-27  6:02 ` [PATCH v7 6/6] drm/xe/xe_ras: Add drm_ras feature flag Riana Tauro
2026-05-27  6:14 ` ✓ Xe.CI.BAT: success for Add get-error-counter and clear-error-counter support for CRI (rev6) Patchwork
2026-05-27  8:21 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahgK4dvEKdSWnN7e@black.igk.intel.com \
    --to=raag.jadav@intel.com \
    --cc=anshuman.gupta@intel.com \
    --cc=aravind.iddamsetty@linux.intel.com \
    --cc=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=mallesh.koujalagi@intel.com \
    --cc=ravi.kishore.koppuravuri@intel.com \
    --cc=riana.tauro@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=soham.purkait@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.