From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f52.google.com (mail-ej1-f52.google.com [209.85.218.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58F3D368D6F for ; Thu, 28 May 2026 22:30:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780007416; cv=none; b=fZMP0TTBXXONDuW721hG3bEHdLrHOXIMMuURnZZJQ6vPU/AL/MDKoDxPMFAU8OFk1UkyUZSPX4DVH8Ff82xt3aGTv5/HV9bkMvu6C+qyCwdJpdknEWdmU/rNUt/BVXdgC5X+yxCby0neCU5EbsGM4HM0NDjWlVoXYqKoW42wM0o= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780007416; c=relaxed/simple; bh=XE2Nz8XY3jfeATNv6GLApHENG4QyQDJPsi8VaxfTPGU=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=XPFrRTQojItVtth0GQUmWSg5yctvDKh5rDfRfDaAkGK5VcsLtTq7RipmVbg733Etuan+WMQLcrpGCEkJ2J0jaIALkCOn75EbCX2PcnqXOdIeBTSStIR+qwxtoZUQ2NkipjeaNfcF0Cisry37zQhWtCBTX8Eu0OWK+9ZCfIK4lBQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fTusoSH/; arc=none smtp.client-ip=209.85.218.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fTusoSH/" Received: by mail-ej1-f52.google.com with SMTP id a640c23a62f3a-bcda7765d64so2489598266b.1 for ; Thu, 28 May 2026 15:30:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780007414; x=1780612214; darn=vger.kernel.org; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=IiJpfn9/OPGvc7lLpZ8Q6/8VjpgeaL3UxQCz6z34DRA=; b=fTusoSH/yR8iRjMuEGolfK9IdvTG98QnfWNc5ntZmmtvFNYpX+XZ3Zt8Z8RuEHKgY5 pgurGfE59frtj1mn3DMs2GYMIHnrIW5eAuETCT+Zw8vzB3I+jUX/TAt1NwK2AdkHzg3D nrKx9G3+JKcXt1VEthRd2X21kk3tHZLruFchaYF5HWU8EC9mdD++jQI3TJaXUfw/4D1Y GjJtSJ5G/3w4eFGmObcsjd09fNw/ZSf6mngyWIeix4ZZlzi1df0w8TMexlXXxx7i65Yy 6+KLzuUxiRBRwon1I3880/LRzoxghuKIAwxUwENexKS5aXtKDQPyuvAXBrv6GlfcPGIZ PRUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780007414; x=1780612214; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=IiJpfn9/OPGvc7lLpZ8Q6/8VjpgeaL3UxQCz6z34DRA=; b=iZrp5IU48BTmzztEBsRo4Yvsm8XyToCukRokf+ik4nBsFS8s10dbY1gmCfTVhXV5g9 DsEsZV4BlVdcaK9B/QhYrk9Sqre3552N2IvtUmTkC4iFm+4z18t1EIgfPMxwM8EhPKpu nxCjRGkezeyT/NYOg2CzCknpICS9YDOmPzX90IVeIgfh6gBlNCjikzc96WOUzyBT4i/R oPdfYVLBbpxDKW3UW2KjhWU+6++XN35M9IG6hRBOOYNV1pfLVZsh/VO9zW+ry4ENVk7X f0Bdf/Q7rsbyYeyxrKgMFtOtAwjiW8anJ3e/kDqEpDD0XZp5dV4jtq9EKCutGTmfIZXH 0D+g== X-Forwarded-Encrypted: i=1; AFNElJ9PH137jPJrgtEMhtPXghD3FGLstLEqwQi8UIqcg9Vl2x/aTc3505VC4daipdlxUcUWLo6KYbvjVnbtSQs=@vger.kernel.org X-Gm-Message-State: AOJu0YwSR1ImDpa376/4SiEs47M1a/QUkIQ8MQSYLP2bCRS6GjoM+DZ+ 3daOp9xJPHQCZI0nY3YtJuziFqngdcbJawzWi3vb8R8wtx+r4PB7Hazd X-Gm-Gg: Acq92OFxrVA0fGtGoTheel7cUaFdrRn5CkyLnVBtfTQRpImmOvDhHoIzoSqjINpHXf6 WCb5o45CgPRF3uTb4QRTK8KdBDweqhOkVKyff+vjS+bBFYOUJ7zKE3LjWlLNmw2UdEgvRb+dU2I KglpMBfMxI/VzpCnhh398di7t4hTB+YeFfKkEUjFqsODRZQSlCbu3k+0KZsmQxg+AM2S+Z9MCdl 1X2drXQEIPO8R4vNqFr4X68GUpqZm6V/1LtL9m5Qqv+mrkS5vWICi9mM4EjbzjZtqUhcaOEr9nS O2rHEiMTOud/cgqV/kJ0+00TUTCYQfWO2ieSIwynYihWwFFjad1mtdzx6OaCYKBTcZMo1b+kvcf 3EkktJbXca7+oIx4t9Rm7ek5oXGCERFF13tHK0dqA3lx5CPkX+5qi7IDLn9ZjKhu1XXj2EZ106A UG90B0ApCpYYFfWi3KSG/DHmZt9Nvp5tZYVtE= X-Received: by 2002:a17:907:75e4:b0:bc5:2352:555c with SMTP id a640c23a62f3a-be9ac78d0b2mr11752866b.14.1780007413511; Thu, 28 May 2026 15:30:13 -0700 (PDT) Received: from grain.localdomain ([5.18.255.97]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-be9b2bc9b50sm6105166b.0.2026.05.28.15.30.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 28 May 2026 15:30:13 -0700 (PDT) Received: by grain.localdomain (Postfix, from userid 1000) id 977B85A0061; Fri, 29 May 2026 01:30:11 +0300 (MSK) Date: Fri, 29 May 2026 01:30:11 +0300 From: Cyrill Gorcunov To: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Czurylo , Tatyana Nikolova , Jason Gunthorpe , Leon Romanovsky Subject: [PATCH] RDMA/irdma: Fix typo in SQ completions generation Message-ID: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/2.3.1 (2026-03-20) When we generate completion for SQ the opcode while being properly read from ring buffer is ignored when written back to completion. Seems to be a simple typo. Signed-off-by: Cyrill Gorcunov --- Hopefully I didn't miss something obvious here, found it while been fighting with unrelated issue. drivers/infiniband/hw/irdma/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: linux-tip.git/drivers/infiniband/hw/irdma/utils.c =================================================================== --- linux-tip.git.orig/drivers/infiniband/hw/irdma/utils.c +++ linux-tip.git/drivers/infiniband/hw/irdma/utils.c @@ -2442,7 +2442,7 @@ void irdma_generate_flush_completions(st cmpl->cpi.wr_id = qp->sq_wrtrk_array[wqe_idx].wrid; sw_wqe = qp->sq_base[wqe_idx].elem; get_64bit_val(sw_wqe, 24, &wqe_qword); - cmpl->cpi.op_type = (u8)FIELD_GET(IRDMAQPSQ_OPCODE, IRDMAQPSQ_OPCODE); + cmpl->cpi.op_type = (u8)FIELD_GET(IRDMAQPSQ_OPCODE, wqe_qword); cmpl->cpi.q_type = IRDMA_CQE_QTYPE_SQ; /* remove the SQ WR by moving SQ tail*/ IRDMA_RING_SET_TAIL(*sq_ring,