Re: [kvm-unit-tests PATCH] x86/run: Use separate "-accel" option to configure the accelerator

[Sean Christopherson <seanjc@google.com>]

On Fri, May 29, 2026, Xiaoyao Li wrote:
> On 5/28/2026 9:00 PM, Sean Christopherson wrote:
> > On Thu, May 28, 2026, Xiaoyao Li wrote:
> > > When configuring accelerator via machine's "accel" property, it cannot
> > > pass additional ACCEL_PROPS. For example, it hits following error when
> > > configuring KVM with "notify-vmexit":
> > > 
> > >    # ACCEL="kvm,notify-vmexit=internal-error" ./x86-run x86/apic.c
> > >    #   qemu-system-x86_64: Property 'pc-i440fx-11.1-machine.notify-vmexit' not found
> > > 
> > > Switch to use separate "-accel" option to configure the accelerator.
> > > 
> > > Signed-off-by: Xiaoyao Li <xiaoyao.li@intel.com>
> > > ---
> > >   x86/run | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/x86/run b/x86/run
> > > index dd38f14c871f..a68d469dd1b8 100755
> > > --- a/x86/run
> > > +++ b/x86/run
> > > @@ -43,7 +43,7 @@ fi
> > >   pit="-global kvm-pit.lost_tick_policy=discard"
> > >   command="${qemu} --no-reboot -nodefaults $pit $pc_testdev -display none -serial stdio $pci_testdev"
> > > -command+=" -machine accel=$ACCEL$ACCEL_PROPS"
> > > +command+=" -accel $ACCEL$ACCEL_PROPS"
> > 
> > This breaks my setup for specifying kernel_irqchip=split.
> > 
> >    qemu: -accel kvm,kernel_irqchip=split: Property 'kvm-accel.kernel_irqchip' not found
> 
> If you switch "kernel_irqchip" to "kernel-irqchip", it should work again.

Oh, nice.  Yep, that works for me.