From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28893CD6E4A for ; Fri, 29 May 2026 13:18:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id DD3D110FF05; Fri, 29 May 2026 13:18:19 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="bGnC4wI6"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D76710FF05; Fri, 29 May 2026 13:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780060698; x=1811596698; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=LJXOiMU2LL4+JHwscwwLC7lfN3QSz201pmuFCVcj/Qw=; b=bGnC4wI6iNxM8s6TDDD5DfGPyf3l8NHblXxX0ol9KYu5YYKy1rWbYgip Y3GX6O2S80bVnSRYzYbDOjRqagAbVosEsjNg8xnAKR456omlh7AEnnOwd T9AK/cxJhRQYALcTNWimy6s9SP2FtpebXcozlgNYLVEFtFipEi1bnHKNZ ZiyqIbEFa8VuM876I9mSNXS9n3umWTf96rkaKGwbkUNUg7qrcf/znEoXG 5CGkT+E/9x6DhAZ9DQrkG185V7/aFe6GyBAFSLvxzsxOoEgDOmZSOMypm mzJbaqZXg6IIAq7gZc7yuQ4Y3yRU2f3TUx+MxMyqXGu0t0+8yTPoDumRC g==; X-CSE-ConnectionGUID: hZmC97o3SrGEkXCxWgnxtA== X-CSE-MsgGUID: GhfUDvjbRzSHlhHwdln4Jw== X-IronPort-AV: E=McAfee;i="6800,10657,11801"; a="84798704" X-IronPort-AV: E=Sophos;i="6.24,175,1774335600"; d="scan'208";a="84798704" Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2026 06:18:18 -0700 X-CSE-ConnectionGUID: GNQLEPT7Rd2+BhZPwmnAOQ== X-CSE-MsgGUID: WSW92OdRRcuQthrEUBoSmw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,175,1774335600"; d="scan'208";a="247939098" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.244.182]) by fmviesa005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 May 2026 06:18:16 -0700 Date: Fri, 29 May 2026 16:18:13 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, imre.deak@intel.com Subject: Re: [PATCH 04/24] drm/xe/display: remove intel_display_flush_cleanup_work() calls on suspend/shutdown Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Patchwork-Hint: comment Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, May 29, 2026 at 02:03:48PM +0300, Jani Nikula wrote: > intel_display_driver_suspend() already has drm_atomic_helper_suspend() > and cleanup workqueue flush. The intel_display_flush_cleanup_work() > calls on suspend/shutdown should be redundant. Remove. > > Link: https://lore.kernel.org/r/agRp6Was9FCQbKee@intel.com > Suggested-by: Ville Syrjälä > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/xe/display/xe_display.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c > index c0d3e7d12823..6e82dc70ca89 100644 > --- a/drivers/gpu/drm/xe/display/xe_display.c > +++ b/drivers/gpu/drm/xe/display/xe_display.c > @@ -312,8 +312,6 @@ void xe_display_pm_suspend(struct xe_device *xe) > intel_display_driver_suspend(display); > } > > - intel_display_flush_cleanup_work(display); > - > intel_encoder_block_all_hpds(display); > > intel_hpd_cancel_work(display); > @@ -344,7 +342,6 @@ void xe_display_pm_shutdown(struct xe_device *xe) > intel_display_driver_suspend(display); > } > > - intel_display_flush_cleanup_work(display); Hmm, apparently the super funky d3cold path still has one call remaining so can't remove it completely quite yet. Oh well, at least we're moving to a better direction. Reviewed-by: Ville Syrjälä > intel_dp_mst_suspend(display); > intel_encoder_block_all_hpds(display); > intel_hpd_cancel_work(display); > -- > 2.47.3 -- Ville Syrjälä Intel