All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	imre.deak@intel.com
Subject: Re: [PATCH 23/24] drm/xe/display: separate d3cold handling from xe_display_pm_runtime_suspend_late()
Date: Fri, 29 May 2026 22:05:42 +0300	[thread overview]
Message-ID: <ahnjhi6FKMywQvNS@intel.com> (raw)
In-Reply-To: <5a604a4b846ef69f26586ba00a08961a82990713.1780051905.git.jani.nikula@intel.com>

On Fri, May 29, 2026 at 02:04:07PM +0300, Jani Nikula wrote:
> Make the special d3cold paths completely separate from the rest of the
> runtime pm calls.
> 
> The intel_dmc_wl_flush_release_work() call right after
> xe_display_pm_suspend_late() might be completely redundant, but this
> avoids any functional changes.
> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>

Acked-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

> ---
>  drivers/gpu/drm/xe/display/xe_display.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/display/xe_display.c b/drivers/gpu/drm/xe/display/xe_display.c
> index b153bf9c83d8..0fadc62e1cdd 100644
> --- a/drivers/gpu/drm/xe/display/xe_display.c
> +++ b/drivers/gpu/drm/xe/display/xe_display.c
> @@ -373,8 +373,11 @@ void xe_display_pm_runtime_suspend_late(struct xe_device *xe)
>  	if (!xe->info.probe_display)
>  		return;
>  
> -	if (xe->d3cold.allowed)
> +	if (xe->d3cold.allowed) {
>  		xe_display_pm_suspend_late(xe);
> +		intel_dmc_wl_flush_release_work(display);
> +		return;
> +	}
>  
>  	/*
>  	 * If xe_display_pm_suspend_late() is not called, it is likely
> -- 
> 2.47.3

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-05-29 19:05 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-29 11:03 [PATCH 00/24] drm/{i915, xe}: display (runtime) suspend/resume/shutdown unification Jani Nikula
2026-05-29 11:03 ` [PATCH 01/24] drm/i915: Keep display IRQs enabled for encoder suspend/shutdown Jani Nikula
2026-05-29 11:03 ` [PATCH 02/24] drm/i915/xe: Enable HPD polling later during system resume Jani Nikula
2026-05-29 11:03 ` [PATCH 03/24] drm/i915: add flush_workqueue(display->wq.cleanup) on shutdown Jani Nikula
2026-05-29 13:07   ` Ville Syrjälä
2026-05-29 11:03 ` [PATCH 04/24] drm/xe/display: remove intel_display_flush_cleanup_work() calls on suspend/shutdown Jani Nikula
2026-05-29 13:18   ` Ville Syrjälä
2026-05-29 11:03 ` [PATCH 05/24] drm/xe/display: drop duplicate intel_dp_mst_suspend() call Jani Nikula
2026-05-29 13:18   ` Ville Syrjälä
2026-05-29 11:03 ` [PATCH 06/24] drm/i915/display: add "pm" to intel_display_driver_{suspend, resume}() names Jani Nikula
2026-05-29 13:30   ` [PATCH 06/24] drm/i915/display: add "pm" to intel_display_driver_{suspend,resume}() names Ville Syrjälä
2026-05-29 11:03 ` [PATCH 07/24] drm/xe/display: rename xe_display_pm_shutdown*() to xe_display_shutdown*() Jani Nikula
2026-05-29 13:30   ` Ville Syrjälä
2026-05-29 11:03 ` [PATCH 08/24] drm/xe/display: relocate the xe_display_shutdown*() functions Jani Nikula
2026-06-02  7:22   ` Michał Grzelak
2026-05-29 11:03 ` [PATCH 09/24] drm/xe/display: relocate the xe_display_pm_runtime_*() functions Jani Nikula
2026-06-02  7:23   ` Michał Grzelak
2026-05-29 11:03 ` [PATCH 10/24] drm/{i915, xe}: move more calls inside intel_display_driver_pm_suspend() Jani Nikula
2026-05-29 13:36   ` [PATCH 10/24] drm/{i915,xe}: " Ville Syrjälä
2026-05-29 11:03 ` [PATCH 11/24] drm/{i915, xe}: move more calls inside intel_display_driver_pm_resume() Jani Nikula
2026-05-29 13:38   ` [PATCH 11/24] drm/{i915,xe}: " Ville Syrjälä
2026-05-29 11:03 ` [PATCH 12/24] drm/{i915, xe}: add intel_display_driver_pm_{suspend_late, resume_early}() Jani Nikula
2026-05-29 13:39   ` [PATCH 12/24] drm/{i915,xe}: add intel_display_driver_pm_{suspend_late,resume_early}() Ville Syrjälä
2026-05-29 11:03 ` [PATCH 13/24] drm/{i915, xe}: move more calls inside intel_display_driver_{register, unregister}() Jani Nikula
2026-05-29 14:04   ` [PATCH 13/24] drm/{i915,xe}: move more calls inside intel_display_driver_{register,unregister}() Ville Syrjälä
2026-05-29 11:03 ` [PATCH 14/24] drm/{i915, xe}: add intel_display_driver_shutdown_late() Jani Nikula
2026-05-29 14:05   ` [PATCH 14/24] drm/{i915,xe}: " Ville Syrjälä
2026-05-29 11:03 ` [PATCH 15/24] drm/i915: add intel_display_driver_shutdown() Jani Nikula
2026-05-29 17:57   ` Ville Syrjälä
2026-05-29 11:04 ` [PATCH 16/24] drm/i915/display: deduplicate suspend and shutdown a bit Jani Nikula
2026-05-29 17:59   ` Ville Syrjälä
2026-05-29 11:04 ` [PATCH 17/24] drm/xe/display: use intel_display_driver_pm_shutdown() Jani Nikula
2026-05-29 18:02   ` Ville Syrjälä
2026-05-29 11:04 ` [PATCH 18/24] drm/{i915, xe}: move more stuff to __intel_display_driver_pm_suspend() Jani Nikula
2026-05-29 18:03   ` [PATCH 18/24] drm/{i915,xe}: " Ville Syrjälä
2026-05-29 11:04 ` [PATCH 19/24] drm/{i915, xe}: make intel_dmc_suspend() part of display suspend/shutdown calls Jani Nikula
2026-05-29 14:16   ` [PATCH 19/24] drm/{i915,xe}: " Ville Syrjälä
2026-06-01  8:14     ` Imre Deak
2026-05-29 11:04 ` [PATCH 20/24] drm/{i915, xe}: move intel_opregion_suspend() to intel_display_driver_pm_suspend_late() Jani Nikula
2026-05-29 14:42   ` [PATCH 20/24] drm/{i915,xe}: " Ville Syrjälä
2026-05-29 11:04 ` [PATCH 21/24] drm/{i915, xe}: keep moving stuff to intel_display_driver_pm_resume() Jani Nikula
2026-05-29 18:45   ` [PATCH 21/24] drm/{i915,xe}: " Ville Syrjälä
2026-05-29 11:04 ` [PATCH 22/24] drm/i915: add intel_display_driver_pm_runtime*() functions Jani Nikula
2026-05-29 19:05   ` Ville Syrjälä
2026-05-29 11:04 ` [PATCH 23/24] drm/xe/display: separate d3cold handling from xe_display_pm_runtime_suspend_late() Jani Nikula
2026-05-29 19:05   ` Ville Syrjälä [this message]
2026-05-29 11:04 ` [PATCH 24/24] drm/xe/display: unify runtime suspend/resume with i915 for non-d3cold Jani Nikula
2026-05-29 19:12   ` Ville Syrjälä
2026-06-05 16:04     ` Jani Nikula
2026-05-29 11:13 ` ✓ CI.KUnit: success for drm/{i915, xe}: display (runtime) suspend/resume/shutdown unification Patchwork
2026-05-29 11:59 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-05-29 12:23 ` ✗ i915.CI.BAT: " Patchwork
2026-05-29 14:07 ` ✗ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahnjhi6FKMywQvNS@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=imre.deak@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.