Re: [PATCH 3/6] Revert "drm/xe/nvls: Define GuC firmware for NVL-S"

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Fri, May 29, 2026 at 12:36:02PM -0700, Daniele Ceraolo Spurio wrote:
> This reverts commit 4e88de313ff4d1c67b644b1f39f9fb4089711b71.
> 
> The early GuC FW definition meant for our CI branch was accidentally
> merged to the drm-xe-next branch instead. This GuC FW will never be
> released to linux-firmware, so we do not want the definition to be
> available in the mainline Linux codebase.
> 
> Fixes: 4e88de313ff4 ("drm/xe/nvls: Define GuC firmware for NVL-S")
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Julia Filipchuk <julia.filipchuk@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Matt Roper <matthew.d.roper@intel.com>
> Cc: <stable@vger.kernel.org> # v7.0+

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

Thanks for that and sorry for the accidental miss-merge!

> ---
>  drivers/gpu/drm/xe/xe_uc_fw.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_uc_fw.c b/drivers/gpu/drm/xe/xe_uc_fw.c
> index 70bccbc1af82..498c89452779 100644
> --- a/drivers/gpu/drm/xe/xe_uc_fw.c
> +++ b/drivers/gpu/drm/xe/xe_uc_fw.c
> @@ -115,7 +115,6 @@ struct fw_blobs_by_type {
>  #define XE_GT_TYPE_ANY XE_GT_TYPE_UNINITIALIZED
>  
>  #define XE_GUC_FIRMWARE_DEFS(fw_def, mmp_ver, major_ver)					\
> -	fw_def(NOVALAKE_S,	GT_TYPE_ANY,	mmp_ver(xe,	guc,	nvl,	70, 55, 4))	\
>  	fw_def(PANTHERLAKE,	GT_TYPE_ANY,	major_ver(xe,	guc,	ptl,	70, 54, 0))	\
>  	fw_def(BATTLEMAGE,	GT_TYPE_ANY,	major_ver(xe,	guc,	bmg,	70, 54, 0))	\
>  	fw_def(LUNARLAKE,	GT_TYPE_ANY,	major_ver(xe,	guc,	lnl,	70, 53, 0))	\
> -- 
> 2.43.0
>