Re: [Buildroot] [PATCH 1/1] package/micropython: bump to version 1.28.0

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello Daniel,

Thanks for patch, and the very good commit log. Nevertheless, I have a
few questions, see below.

On Fri, May 08, 2026 at 07:52:36PM -0400, Daniel Houck wrote:

> +if BR2_PACKAGE_MICROPYTHON_LIB
> +
> +config BR2_PACKAGE_MICROPYTHON_LIB_UNIXFFI
> +	bool "micropython-lib unix-ffi modules"
> +	default y
> +	select BR2_PACKAGE_LIBFFI
> +	select BR2_PACKAGE_PCRE2 # runtime

So libffi is only needed as a dependency when
BR2_PACKAGE_MICROPYTHON_LIB_UNIXFFI=y?

>  # When building from a tarball we don't have some of the dependencies that are in
>  # the git repository as submodules
>  MICROPYTHON_MAKE_OPTS += \
> @@ -71,7 +64,8 @@ ifeq ($(BR2_PACKAGE_MICROPYTHON_LIB),y)
>  define MICROPYTHON_COLLECT_LIBS
>  	$(EXTRA_ENV) PYTHONPATH=$(@D)/tools \
>  		package/micropython/collect_micropython_lib.py \
> -		$(@D) $(@D)/.built_pylib
> +		$(@D) $(@D)/.built_pylib \
> +		$(if $(BR2_PACKAGE_MICROPYTHON_LIB_UNIXFFI),--ffi,--no-ffi)

If yes, then this change is not needed. Indeed:

ifeq ($(BR2_PACKAGE_LIBFFI),y)
MICROPYTHON_DEPENDENCIES += host-pkgconf libffi
MICROPYTHON_MAKE_OPTS += MICROPY_PY_FFI=1
else
MICROPYTHON_MAKE_OPTS += MICROPY_PY_FFI=0
endif

will continue to bring libffi as a dependency if BR2_PACKAGE_LIBFFI is
enabled.

> diff --git a/package/micropython/collect_micropython_lib.py b/package/micropython/collect_micropython_lib.py
> index 8dce78337a..5fb74787a9 100755
> --- a/package/micropython/collect_micropython_lib.py
> +++ b/package/micropython/collect_micropython_lib.py

Could you perhaps improve a tiny bit the commit message to explain the
changes being brought to this script?

Thanks a lot!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot