All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Bernd Kuhls <bernd@kuhls.net>
Cc: buildroot@buildroot.org, Fabio Estevam <festevam@gmail.com>
Subject: Re: [Buildroot] [PATCH v2 1/1] package/crucible: needs NPTL
Date: Sun, 31 May 2026 08:31:44 +0200	[thread overview]
Message-ID: <ahvVqPi5qI7zbOTZ@windsurf> (raw)
In-Reply-To: <20260531061840.6748-1-bernd@kuhls.net>

Hello,

On Sun, May 31, 2026 at 08:18:40AM +0200, Bernd Kuhls wrote:
> gcc_stack_unix.c: In function 'x_cgo_getstackbound':
> gcc_stack_unix.c:28:9: error: implicit declaration of function 'pthread_getattr_np';
>  did you mean 'pthread_attr_init'? [-Wimplicit-function-declaration]
>    28 |         pthread_getattr_np(pthread_self(), &attr);  // GNU extension
> 
> Fixes:
> https://autobuild.buildroot.net/results/e07/e07198d7864331027d21cd2109054d86e7ac1c3d/
> 
> The build error also occured in Oct 2024 so a backport to buildroot
> LTS branches should be considered:
> https://autobuild.buildroot.net/results/ebb/ebbd051010c27f97fafc0b203b22c8b0af7e5ccd/
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Thanks, applied to master, after fixing one small thing.

> diff --git a/package/crucible/Config.in b/package/crucible/Config.in
> index 1e1b29c3df..e18e393a05 100644
> --- a/package/crucible/Config.in
> +++ b/package/crucible/Config.in
> @@ -1,9 +1,13 @@
>  config BR2_PACKAGE_CRUCIBLE
>  	bool "crucible"
>  	depends on BR2_PACKAGE_HOST_GO_TARGET_ARCH_SUPPORTS

You forgot to replicate this dependency...

> +	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # pthread_getattr_np()
>  	select BR2_PACKAGE_HOST_GO
>  	help
>  	  Crucible is a One-Time-Programmable (OTP) fusing tool for the
>  	  i.MX family.
>  
>  	  https://github.com/usbarmory/crucible
> +
> +comment "crucible needs a toolchain w/ NPTL"

...here.

> +	depends on !BR2_TOOLCHAIN_HAS_THREADS_NPTL

Fixed while applying.

Thanks again!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-05-31  6:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-31  6:18 [Buildroot] [PATCH v2 1/1] package/crucible: needs NPTL Bernd Kuhls
2026-05-31  6:31 ` Thomas Petazzoni via buildroot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ahvVqPi5qI7zbOTZ@windsurf \
    --to=buildroot@buildroot.org \
    --cc=bernd@kuhls.net \
    --cc=festevam@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.