From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C895432470A for ; Sun, 31 May 2026 07:05:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780211106; cv=none; b=Z06rxV2JILI8/NDM7QhzgdMVxvzQi4FaWY6Z0VzO6KYzTuqJrOjcXv8bBfgBFiCHuR5niPXL3INA9NmMxQOioTKCiqkuAvLw4duiGFbbZ66QkvYf2ct9SRLMM5PnHErSgJPL9DZHnByRAmxeZRX+Rer6EQYy821DDEQte9nYR+0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780211106; c=relaxed/simple; bh=N7CLKGZbO/To7MWm6f46pV4DOUUodj89uruRQZhcMlY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=J6zu3lSyq1q22SNBAX/4kGdWuLIQe8rrSTSAVmPemyud5EzTWaNWvCo5LPPJhfLHDufjsGTRLGp1vtC5A2V21XtKwY43+4V0UeufuJ/nycudZc5+Tr3jmah5JJ7l9K3GuoZwj+3V217NXRqTuKcGoTXT9qu/yM2s4rvnA7fBZTA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jLVnfsCe; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jLVnfsCe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8BFF11F00893; Sun, 31 May 2026 07:05:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1780211105; bh=YpCz0UWAsi5M0t3Pe9yoe67kdhzJq/Fef4PzJ0CjfS4=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=jLVnfsCenwCorIXJh22/gCEEXkSYH419e0k83JEjJwkMRXH/nerRnTNFm+gJzmjv+ 01AxfIgyS7X924o/FmVL2KgAcAq/xIwNkiuqC83m6qwB/Pw9FbSNwi7sJ9aqWNWcCB evFR08h4zcdocZ6p5zjg3xjbGfnE1NU9+23lsPNQ9qNFL8zwM5wdG9Bm1nLRdB/e8p zcGadqHuDygN61fYs0NPPVPv5xSalTfQF3Grg+lnSPmuRozkQn9HrLc4a1ecLeggRO igyo6jcKJImNeJKwOgtZnpwioGtHq3kpwIp5MvmBsMYVTh6cVS6mTqkl+S+oB55GAK REHr5tywcU0xQ== Date: Sun, 31 May 2026 09:05:00 +0200 From: Ingo Molnar To: Julian Braha Cc: tglx@kernel.org, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/cpu: cleanup duplicate dependencies in Kconfig Message-ID: References: <20260531065743.1408481-1-julianbraha@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260531065743.1408481-1-julianbraha@gmail.com> * Julian Braha wrote: > The Kconfig in the choice menu already has an 'if X86' > affecting all of the config options within the choice, meaning that each > of the individual 'depends on' statements in this file is a duplicate > dependency (dead code). > > Let's leave the initial 'depends on X86_32' in the choice menu, > and remove the individual dependencies from each option. > > This dead code was found by kconfirm, a static analysis tool for Kconfig. > > Signed-off-by: Julian Braha > --- > arch/x86/Kconfig.cpu | 16 ---------------- > 1 file changed, 16 deletions(-) > > diff --git a/arch/x86/Kconfig.cpu b/arch/x86/Kconfig.cpu > index 1377edd9a997..36c8007c1559 100644 > --- a/arch/x86/Kconfig.cpu > +++ b/arch/x86/Kconfig.cpu > @@ -45,21 +45,18 @@ choice > > config M586TSC > bool "Pentium-Classic" > - depends on X86_32 > help > Select this for a Pentium Classic processor with the RDTSC (Read > Time Stamp Counter) instruction for benchmarking. > > config M586MMX > bool "Pentium-MMX" > - depends on X86_32 > help > Select this for a Pentium with the MMX graphics/multimedia > extended instructions. Dunno, I don't really like this change, because it obfuscates the dependency. Yes, technically the dependency is already expressed shared, but in practice it's useful to see 'at a glance' whether such a CPU config option is 32-bit only, 64-bit only or generic. Thanks, Ingo